[bug #62575] Garbled ANSI color codes in Cygwin mintty

[Paul D. Smith]

Update of bug #62575 (project make):

  Item Group:None => Enhancement


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #62575] Garbled ANSI color codes in Cygwin mintty

[Eli Zaretskii]

Follow-up Comment #4, bug #62575 (project make):

AFAIK, ENABLE_VIRTUAL_TERMINAL_PROCESSING is supported only since Windows 10,
so using it unconditionally is out of the question.

Moreover, I don't understand why should Make do anything about that , instead
of leaving it to the user to set up the terminal so that escape sequences are
automatically handled by the terminal, the same way as this happens on Unix. 
Am I missing something?



___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #62575] Garbled ANSI color codes in Cygwin mintty

[Paul D. Smith]

Follow-up Comment #3, bug #62575 (project make):

Just to clarify: Stephan is running make with the -O option.  It may have
escaped your notice Gisle.  Any testing of the problem reported needs to use
that option as well, or you won't see the issue I'm sure.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #62575] Garbled ANSI color codes in Cygwin mintty

[Gisle Vanem]

Follow-up Comment #2, bug #62575 (project make):

> sh -c 'clang -fansi-escape-codes -fcolor-diagnostics'

Why this when `clang` is giving nice colours w/o any problems
on Windows anyway? 

Please do not add this patch without checking that the
`ENABLE_VIRTUAL_TERMINAL_PROCESSING` works. And it does not work
when "Use legacy console" is in effect. Ref:
https://techcult.com/enable-or-disable-legacy-console-for-command-prompt-and-powershell-in-windows-10/


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #62575] Garbled ANSI color codes in Cygwin mintty

[Paul D. Smith]

Update of bug #62575 (project make):

Operating System:None => MS Windows 

___

Follow-up Comment #1:

I'll have to let @eliz comment on whether this should be enabled for all
Windows builds, or not.


___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/

[bug #62575] Garbled ANSI color codes in Cygwin mintty

[Stephan Bergmann]

URL:
  

 Summary: Garbled ANSI color codes in Cygwin mintty
 Project: make
   Submitter: sberg
   Submitted: Fri 03 Jun 2022 01:24:26 PM UTC
Severity: 3 - Normal
  Item Group: None
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
   Component Version: 4.3
Operating System: None
   Fixed Release: None
   Triage Status: None


___

Follow-up Comments:


---
Date: Fri 03 Jun 2022 01:24:26 PM UTC By: Stephan Bergmann 
I experienced this with `make` built for native Windows (not Cygwin), and run
in Cygwin mintty 3.6.1 on Windows 11:

$ cat Makefile
.PHONY test:
sh -c 'clang -fansi-escape-codes -fcolor-diagnostics'
$ make -O -j2
sh -c 'clang -fansi-escape-codes -fcolor-diagnostics'
clang: ←[0;1;31merror: ←[0m←[1mno input files←[0m
make: *** [Makefile:2: test] Error 1

where clang's ANSI color-coded "error: no input files" stderr output was not
displaying in red and bold, but rather with verbatim "←[0;1;31m".

What would fix it for me (but see my "I don't know if it is appropriate to
execute this unconditionally on Windows") is the attached
0001-Enable-ANSI-color-codes-in-pump_from_tmp-on-Windows.patch.






___
File Attachments:


---
Date: Fri 03 Jun 2022 01:24:26 PM UTC  Name:
0001-Enable-ANSI-color-codes-in-pump_from_tmp-on-Windows.patch  Size: 2KiB  
By: sberg



___

Reply to this item at:

  

___
Message sent via Savannah
https://savannah.gnu.org/