Re: [PATCH 1/2] * src/function.c: Introduce the 'let' built-in function
On Fri, 2020-10-23 at 09:14 -0400, Paul Smith wrote: > On Fri, 2020-10-09 at 16:36 +0200, Jouke Witteveen wrote: > > > This was sent before at the end of last year. Meanwhile, the > > copyright of my contributions is assigned to the FSF, so I picked > > this up again and added some documentation (next patch). > > Sorry for the delay. This new feature has been pushed. I tweaked some of the documentation, hopefully for the better, and added a few tests. Thanks for your work, Jouke!
Re: [PATCH 1/2] * src/function.c: Introduce the 'let' built-in function
On Fri, 2020-10-09 at 16:36 +0200, Jouke Witteveen wrote: > This was sent before at the end of last year. Meanwhile, the > copyright of my contributions is assigned to the FSF, so I picked > this up again and added some documentation (next patch). Sorry for the delay. I have been super-busy (you'd think working from home would give one _more_ time but it seems not). Thanks for the docs! Very helpful. The thing most critically missing is a set of regression tests we can use to ensure that the feature is working (including various corner cases you would like to ensure), so that we can be sure it _keeps_ working. Also I run these tests under valgrind and ASAN and similar to check for memory leaks and other errors. If you need some pointers on writing tests (it's not always so simple and the test suite has evolved and changed over time, with older tests not being rewritten to the new format) let me know.
Re: [PATCH 1/2] * src/function.c: Introduce the 'let' built-in function
On Fri, Oct 9, 2020 at 4:36 PM Jouke Witteveen wrote: > > --- > This was sent before at the end of last year. Meanwhile, the copyright of my > contributions is assigned to the FSF, so I picked this up again and added some > documentation (next patch). > > The previous discussion was titled "[RFC] Scoped variables, supercharged". > Any news on this? There was some minor discussion on the second version of the second half of this patch, but that was not really related to this patch series. These patches fix bug 51286. Regards, - Jouke
