Re: GNU Make 4.3.92 release candidate available

2022-10-25 Thread Eli Zaretskii
> From: Paul Smith 
> Date: Mon, 24 Oct 2022 02:59:18 -0400
> 
> I expect this to be the final release candidate before GNU Make 4.4.
> I will probably allow for testing for about a week.
> 
> 
> GNU make is a tool which controls the generation of executables and
> other non-source files of a program from the program's source files.
> 
> You can learn more at: https://www.gnu.org/software/make/
> 
> 
> A new release candidate for GNU make 4.4 is available now for download:
> 
>   724e9144fa841bb1315aee1f2fd8e1d2  make-4.3.92.tar.lz
>   09a2bb194655c99cd9eff23a9128df7f  make-4.3.92.tar.gz
> 
> You can obtain a copy from:  https://alpha.gnu.org/gnu/make/

The MinGW port of this builds cleanly and passes the test suite (after
my usual patching of it).



Re: GNU Make 4.3.92 release candidate available

2022-10-25 Thread Paul Smith
On Tue, 2022-10-25 at 08:42 +0200, Martin Reinders wrote:
> but from what Paul said in https://lists.gnu.org/archive/html/bug-
> make/2019-05/msg00017.html
> 
> > Argh, another glob.c issue.  I really need to figure out how to
> > update to a newer version, preferably without breaking Windows AND
> > pulling in 75% of gnulib stuff in the process.
> 
> I assume we still have to live with these warnings?

Yes, I have no plans to try to resolve this before 4.4.  I've been
noodling it over in the back of my brain but so far no epiphanies.

> Apart from that, there is only one compiler warning:
> 
>   src/getopt.c:685:6: warning: add explicit braces to avoid dangling
> else [-Wdangling-else]
>    else
>    ^
> 
> A fix had been posted in
> https://savannah.gnu.org/bugs/?func=detailitem_id=58075. That
> looks like a "small effort" change to me, perhaps it can be
> incorporated into GNU Make 4.4?

The thing is that getopt.c is also an external file, like glob.c.  It's
not developed by GNU make, it was pulled in from an external toolset
(like gnulib--but a long time ago so it's not receiving updates).

I prefer to not make changes to these types of files locally but
instead find a way to import newer versions.

In any event, the C code here is correct, regardless of the warning.

Cheers!



Re: GNU Make 4.3.92 release candidate available

2022-10-25 Thread Martin Reinders
Am 24.10.22 um 08:59 schrieb Paul Smith:
> I expect this to be the final release candidate before GNU Make 4.4.
> I will probably allow for testing for about a week.

(I had accidentally posted this yesterday as reply to an older thread, but it 
was meant as feedback to make-4.3.92.)

On macOS, compiling "glob.c" gives these warnings:

  glob.c:823:27: warning: incompatible pointer types passing 'char **' to 
parameter of type 'char *'; dereference with * [-Wincompatible-pointer-types]
= (char **) realloc (pglob->gl_pathv,
 ^~~
 *
  glob.c:942:24: warning: incompatible pointer types passing 'char **' to 
parameter of type 'char *'; dereference with * [-Wincompatible-pointer-types]
= (char **) realloc (pglob->gl_pathv,
 ^~~
 *
  glob.c:997:39: warning: incompatible pointer types passing 'char **' to 
parameter of type 'char *'; dereference with * [-Wincompatible-pointer-types]
  new_pathv = (char **) realloc (pglob->gl_pathv,
 ^~~
 *
  glob.c:1388:23: warning: incompatible pointer types passing 'char **' to 
parameter of type 'char *'; dereference with * [-Wincompatible-pointer-types]
= (char **) realloc (pglob->gl_pathv,
 ^~~
 *

but from what Paul said in 
https://lists.gnu.org/archive/html/bug-make/2019-05/msg00017.html

> Argh, another glob.c issue.  I really need to figure out how to update
> to a newer version, preferably without breaking Windows AND pulling in
> 75% of gnulib stuff in the process.

I assume we still have to live with these warnings?

Apart from that, there is only one compiler warning:

  src/getopt.c:685:6: warning: add explicit braces to avoid dangling else 
[-Wdangling-else]
   else
   ^

A fix had been posted in 
https://savannah.gnu.org/bugs/?func=detailitem_id=58075. That looks like a 
"small effort" change to me, perhaps it can be incorporated into GNU Make 4.4?

Regards, Martin




Re: GNU Make 4.3.92 release candidate available

2022-10-24 Thread Sam James


> On 24 Oct 2022, at 14:17, Frank Heckenbach  wrote:
> 
> Paul Smith wrote:
> 
>> I expect this to be the final release candidate before GNU Make 4.4.
>> I will probably allow for testing for about a week.

> All problems I reported appear fixed, thanks.
> 

Indeed, me too. I'd forgotten I was even using it :)



signature.asc
Description: Message signed with OpenPGP


Re: GNU Make 4.3.92 release candidate available

2022-10-24 Thread Paul Smith
On Mon, 2022-10-24 at 15:17 +0200, Frank Heckenbach wrote:
> Paul Smith wrote:
> > I expect this to be the final release candidate before GNU Make
> > 4.4.  I will probably allow for testing for about a week.
> 
> All problems I reported appear fixed, thanks.

Nice, thanks for checking!  And big thanks to Dmitry for finding (and
patching) most of those issues.



Re: GNU Make 4.3.92 release candidate available

2022-10-24 Thread Frank Heckenbach
Paul Smith wrote:

> I expect this to be the final release candidate before GNU Make 4.4.
> I will probably allow for testing for about a week.

All problems I reported appear fixed, thanks.