Re: Problem with CURDIR variable

[Paul Smith]

On Mon, 2006-12-11 at 15:36 +0100, Sombat Ketrat wrote:

 the error msg. is
 ---
 GNUmakefile:3: *** Sorry, your version of GNU make (3.81) is too old.
 You need one that defines the CURDIR variable.  Stop.
 ---

 ifneq (default,$(origin CURDIR))
 $(error Sorry, your version of GNU make ($(MAKE_VERSION)) is too old.
 You need one that defines the CURDIR variable)

 Is it the problem with version of the make (make v.3.8.1-23)?
 Do you have any idea how to overcome the problem?

In GNU make 3.81, the origin of the CURDIR variable was changed from
default to file (this was so that an environment variable CURDIR
wouldn't override the value make set).

This test is kind of strange.  Unless there's some specific reason the
makefile REQUIRES the CURDIR variable to be set by make, it should be
rewritten:

ifndef CURDIR
$(error Please define the CURDIR variable (or use a newer version of GNU make))
endif

Please contact the developers of the molpro software and notify them of
this issue.  If you don't want to change the makefile you'll have to
find an older version of GNU make (3.80 would be OK) and use that
instead.

-- 
---
 Paul D. Smith [EMAIL PROTECTED]  Find some GNU make tips at:
 http://www.gnu.org  http://make.paulandlesley.org
 Please remain calm...I may be mad, but I am a professional. --Mad Scientist


___
Bug-make mailing list
Bug-make@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-make

Re: Problem with CURDIR variable

[Eli Zaretskii]

 From: Paul Smith [EMAIL PROTECTED]
 Date: Mon, 11 Dec 2006 19:42:51 -0500
 Cc: bug-make@gnu.org
 
 This test is kind of strange.  Unless there's some specific reason the
 makefile REQUIRES the CURDIR variable to be set by make, it should be
 rewritten:
 
 ifndef CURDIR
 $(error Please define the CURDIR variable (or use a newer version of GNU 
 make))
 endif

But this test could be defeated if CURDIR was defined in the
environment, right?  If so, the test should make sure CURDIR doesn't
come from the environment.


___
Bug-make mailing list
Bug-make@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-make

Re: Problem with CURDIR variable

[Paul Smith]

On Tue, 2006-12-12 at 06:29 +0200, Eli Zaretskii wrote:

 But this test could be defeated if CURDIR was defined in the
 environment, right?  If so, the test should make sure CURDIR doesn't
 come from the environment.

I was assuming that if it was defined, someone set it.  But I guess
you're right; it could just be set in the environment, to something
that's incorrect.  They should probably check it to be extra-safe.

-- 
---
 Paul D. Smith [EMAIL PROTECTED]  Find some GNU make tips at:
 http://www.gnu.org  http://make.paulandlesley.org
 Please remain calm...I may be mad, but I am a professional. --Mad Scientist


___
Bug-make mailing list
Bug-make@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-make