Patches need to stay on parted-devel only; the bug tracker mangles them.
If the actual test fails when ss != 512, we probably shouldn't bother
calling it in the first place. In other words, swap the order of
get_sector_size() != 512 and the test, and change from != to ==.
Also Sebastian had a point about the main partition table commit lacking
a full message. Could y
Hi Colin!
On 12/09/2016 01:57 PM, Colin Watson wrote:
> Thanks for this. I've satisfied myself that it shouldn't cause problems
> on other systems, so I've gone ahead and applied these patches to Debian
> unstable, though I expect I may need to refresh them at some point.
Thanks a lot, this is a
Thanks for this. I've satisfied myself that it shouldn't cause problems
on other systems, so I've gone ahead and applied these patches to Debian
unstable, though I expect I may need to refresh them at some point.
A few minor comments, although I haven't reviewed the Atari-specific
details:
On Su
On 04.12.2016 17:12, John Paul Adrian Glaubitz wrote:
> Signed-off-by: John Paul Adrian Glaubitz
Please write a long commit description for this one and link to specs.
Please make clear why this is needed.
Please show how many and which kind of users are waiting for this.
Please show how many
On 05.12.2016 16:20, John Paul Adrian Glaubitz wrote:
[snip]
Thanks for the explanations! I'll talk to Andreas and look at your commit.
> Are you one of the parted maintainers?
I'm maintaining SUSE parted since this year but don't have any upstream
commit rights. I took that over from Petr Uzel.
On 12/05/2016 04:40 PM, Sebastian Parschauer wrote:
>> Are you one of the parted maintainers?
>
> I'm maintaining SUSE parted since this year but don't have any upstream
> commit rights. I took that over from Petr Uzel.
>
> I'm just wondering if this could be interesting for us as well and I try
Btw, there is already lots of discussion regarding this in [1].
This change has already been planned to be merged two years ago. I just
didn't have the time to pick up the work again.
Thanks,
Adrian
> [1] http://bugs.debian.org/239816
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Develop
On 12/05/2016 04:15 PM, Sebastian Parschauer wrote:
> On 04.12.2016 17:12, John Paul Adrian Glaubitz wrote:
>> Signed-off-by: John Paul Adrian Glaubitz
>
> Please write a long commit description for this one and link to specs.
Can do.
> Please make clear why this is needed.
Debian/m68k.
> Ple
Signed-off-by: John Paul Adrian Glaubitz
---
libparted/labels/Makefile.am|1 +
libparted/labels/atari.c| 1969 +++
libparted/labels/pt-limit.gperf |1 +
libparted/libparted.c |4 +
libparted/tests/common.c|3 +
po/P
Hi!
This is the fourth revision of my patch to add support for atari
partition tables in parted. With this update, I have included
atari labels in the t9021-maxima.sh test. For this, I had to move
get_sector_size() to a common location so it can be used in
_implemented_disk_label().
Both patches
Moving get_sector_size() from disk.c to common.c allows
us to use it in _implemented_disk_label() to test for
512-byte sectors. This change is required to be able to
enable this test for atari partition tables for which
support is added in a follow-up patch.
Signed-off-by: John Paul Adrian Glaubit
Use get_sector_size() to ensure we're testing on 512-byte
sectors only.
Signed-off-by: John Paul Adrian Glaubitz
---
libparted/tests/common.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libparted/tests/common.c b/libparted/tests/common.c
index 8ef3915..2be0e3a 100644
-
Signed-off-by: John Paul Adrian Glaubitz
---
libparted/labels/Makefile.am |1 +
libparted/labels/atari.c | 1969 ++
libparted/libparted.c|4 +
libparted/tests/common.c |1 +
po/POTFILES.in |1 +
tests/t3310-flag
Moving get_sector_size() to common.c allows us to use it
in _implemented_disk_label to test for 512-byte sectors.
Signed-off-by: John Paul Adrian Glaubitz
---
libparted/tests/common.c | 14 ++
libparted/tests/common.h | 5 +
libparted/tests/disk.c | 15 ---
3 files
Hi!
This is my third revision of this patch series which enables both the
tests for partition flags (tests/t3310-flags.sh) as well as the
test _implemented_disk_label from the libparted test suite.
For the latter to work, I needed to move get_sector_size() from disk.c
to common.c so it could be u
Thorsten,
Am 16.10.2016 um 11:42 schrieb Thorsten Glaser:
> Michael Schmitz dixit:
>
>> Did you write the table on the host and then had to byte swap to get it
>> read in ARAnyM?
>>
>> Just checked - Atari byte order disk image files of IDE disks don't need
>> byte swapping. Host native byte orde
Michael Schmitz dixit:
>Did you write the table on the host and then had to byte swap to get it
>read in ARAnyM?
>
>Just checked - Atari byte order disk image files of IDE disks don't need
>byte swapping. Host native byte order ones do, that suggests your
ARAnyM writes in byte-swapped order by de
On 10/15/2016 09:15 PM, Michael Schmitz wrote:
> good to see you managed to fix the libparted issues!
Thanks. I just happened to be in the situation that I'm writing a guide
how to set up a minimal Debian/m68k system on ARAnyM from scratch.
>> Ah, it works after enabling byte-swapping in ARAnyM :
Hi Adrian,
Am 16.10.2016 um 08:32 schrieb John Paul Adrian Glaubitz:
> On 10/15/2016 09:15 PM, Michael Schmitz wrote:
>> good to see you managed to fix the libparted issues!
>
> Thanks. I just happened to be in the situation that I'm writing a guide
> how to set up a minimal Debian/m68k system on
Adrian,
good to see you managed to fix the libparted issues!
Am 16.10.2016 um 02:53 schrieb John Paul Adrian Glaubitz:
> On 10/15/2016 03:11 PM, John Paul Adrian Glaubitz wrote:
>> I then tried the image on Aranym but to my disappointment, the kernel did
>> not recognize the partition table, so t
On 10/15/2016 03:11 PM, John Paul Adrian Glaubitz wrote:
> I then tried the image on Aranym but to my disappointment, the kernel did
> not recognize the partition table, so there is still something wrong with
> the patch as-is.
Ah, it works after enabling byte-swapping in ARAnyM :).
Alright, will
Fixed the description at the top of libparted/labels/atari.c.
Adrian
Signed-off-by: John Paul Adrian Glaubitz
---
libparted/labels/Makefile.am |1 +
libparted/labels/atari.c | 1969 ++
libparted/libparted.c|4 +
po/POTFILES.in |1 +
4 files changed, 1975 insertions(+)
create mode 100644
Signed-off-by: John Paul Adrian Glaubitz
---
libparted/labels/Makefile.am |1 +
libparted/labels/atari.c | 1969 ++
libparted/libparted.c|4 +
po/POTFILES.in |1 +
4 files changed, 1975 insertions(+)
create mode 100644
Hi!
The following patch adds support for Atari partition tables as used
on classic Atari computers like the Atari ST or Falcon as well
as the ARAnyM Atari emulator.
This patch was originally written by Guillaume Knispel in 2005 [1]
for parted 1.6.6. I have ported the patch to parted 3.2.x and cle
Hi!
I just stumbled into this bug again since I wanted to use parted today to
create a disk image that would be recognized by ARAnyM with a kernel with
just Atari partition support.
I pulled the old patch from Stephen's git repository, applied it to the
current git version of parted which surpris
Warm feelings to 680X0, TOS etc. come up again. I had an ST at that time.
On 18.12.2013 09:06, Michael Schmitz wrote:
Yep, that's seriously borked up.
What does that mean?
http://dict.leo.org/ende/index_de.html#/search=borked&searchLoc=0&resultOrder=basic&multiwordShowSingle=on
Someone traded
Philip,
On 12/17/2013 2:17 PM, Thorsten Glaser wrote:
I thought so too, but it turns out that the Atari IDE interface is
literally wired “the wrong way”, so you do need to bswap the entire
disc – not just partition table or filesystem metadata – but also
user data – before exchanging it between
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 12/17/2013 2:17 PM, Thorsten Glaser wrote:
> I thought so too, but it turns out that the Atari IDE interface is
> literally wired “the wrong way”, so you do need to bswap the entire
> disc – not just partition table or filesystem metadata – but also
Phillip Susi dixit:
>> John Paul Adrian Glaubitz dixit:
>>
>>> But, of course, you could apply the patch to gparted, rebuild
>>> it, then create a partition table on a hard disk and hook it up
>>> to your ATARI and see if it's being recognized.
>>
>> Before hooking it up, bswap the disc if it’s
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On 12/16/2013 04:19 PM, Thorsten Glaser wrote:
> John Paul Adrian Glaubitz dixit:
>
>> But, of course, you could apply the patch to gparted, rebuild
>> it, then create a partition table on a hard disk and hook it up
>> to your ATARI and see if it's
John Paul Adrian Glaubitz dixit:
>But, of course, you could apply the patch to gparted, rebuild it,
>then create a partition table on a hard disk and hook it up to
>your ATARI and see if it's being recognized.
Before hooking it up, bswap the disc if it’s IDE, though.
bye,
//mirabilos
--
Yay for
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 12/16/2013 2:45 PM, John Paul Adrian Glaubitz wrote:
> I'm pretty sure that Philipp was talking about tests which are run
> during build time to check the code, hence the name "make check".
Yes. You should start with the current git head preferab
On 12/16/2013 08:31 PM, Stefan Niestegge wrote:
> Am 16.12.2013 19:18, schrieb Phillip Susi:
>> Would you be able to write a test case so make check verifies it is
>> working?
>>
>
> If i can help in any way, please explain what to do.
> (I am the one with the Falcon 060).
I'm pretty sure that Ph
On 12/16/2013 07:18 PM, Phillip Susi wrote:
> Would you be able to write a test case so make check verifies it is
> working?
What kind of checks does libparted perform during build to verify
it's doing what it's supposed to do. Is there any documentation
or do I need to dig into the code?
Adrian
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 12/13/2013 6:32 PM, Michael Schmitz wrote:
> John,
>
> as long as libparted (or some other PC side kernel magic
> automagically invoked by libparted - dm??) does take care of
> byte-swapping IDE data on the fly, go for it. I had a quick glance
> at
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Would you be able to write a test case so make check verifies it is
working?
On 12/13/2013 5:54 PM, John Paul Adrian Glaubitz wrote:
> Hi!
>
> While chatting with someone who was trying to install Linux onto
> his ATARI Falcon 060, we stumbled into t
John,
as long as libparted (or some other PC side kernel magic automagically
invoked by libparted - dm??) does take care of byte-swapping IDE data
on the fly, go for it. I had a quick glance at the code and could find
nothing to that effect.
Otherwise, your only option would be to run gparte
Hi!
While chatting with someone who was trying to install Linux onto his
ATARI Falcon 060, we stumbled into the task getting the hard disk
partitioned for the ATARI Falcon to be used.
Since I already successfully created an Amiga partition table with
the help of gparted and libparted, I thought i
40 matches
Mail list logo
