Re: [bug-patch] [patch] patch-2.6.1: avoid memory leak

2011-05-23 Thread Bruno Haible
Hi, Tim Waugh wrote: This was spotted by Coverity. In this particular error condition, we end up leaking memory. This memory leak has been fixed in gnulib, on 2009-06-19, by Eric Blake. http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=91fbe86568250b8a159337e5583387306a03b76d

[bug-patch] [PATCH] Don't use an undocumented Autoconf macro.

2018-01-23 Thread Bruno Haible
AC_CONFIG_HEADER has been replaced with AC_CONFIG_HEADERS in 2001 and is no longer documented. >From a017bc672e4a1522d14b2317c48e6de2819aaf59 Mon Sep 17 00:00:00 2001 From: Bruno Haible <br...@clisp.org> Date: Tue, 23 Jan 2018 09:07:26 +0100 Subject: [PATCH] Don't use an undocumented

Re: [bug-patch] ed scripts allow arbitrary code execution

2018-04-06 Thread Bruno Haible
Hello Andreas, > I see that my patch [1] was overlooked and then [2] was written the next > day. It introduces at least 2 new code executions vulnerabilities > relating to filenames containing $(..). Indeed, the gnulib module 'sh-quote' [1] can help to avoid misquoting in shell command-lines.

Re: [bug-patch] Replace some loops with string.h functions

2018-10-26 Thread Bruno Haible
Hi, Kapus Timotej wrote: > @@ -488,8 +488,7 @@ ifetch (lin line, bool whichbuf, size_t *psize) > if (line == input_lines) > *psize = last_line_size; > else { > - for (q = p; *q++ != '\n'; ) > - /* do nothing */ ; > + q = rawmemchr(p,'\n') + 1; > *psize = q - p; > } >

modernize bootstrap.conf

2022-07-24 Thread Bruno Haible
Hi, The 'bootstrap' script from Gnulib has been reorganized to work in two phases: (1) Fetch auxiliary files that are not in the git checkout. This is the part that requires network access and that has supply-chain concerns. (2) Generate files such as configure, config.h,

Re: Patch bug

2023-04-22 Thread Bruno Haible
Amin Chaloukh wrote: > I have found when you use the command in this format patch [original file > [patchfile]] it does not find the patchfile with the autocompletion Completions are — assuming you use GNU bash — part of the 'bash-completion' package. For example, the completions for the 'patch'

Re: bizarre failures on NetBSD 9.3 x86_64

2023-05-12 Thread Bruno Haible
Dennis Clarke wrote: > > The error messages "shift: can't shift that many" and > > "test: ==: unexpected operator" indicate another shell problem. > > I see that and have no idea why that happens. In fact, it's already fixed in git as well. Since 2018-02-07 already. > So maybe we need to > test

Re: bizarre failures on NetBSD 9.3 x86_64

2023-05-10 Thread Bruno Haible
Dennis Clarke wrote: > bash-5.1$ echo $CONFIG_SHELL > /usr/pkg/bin/bash > bash-5.1$ > > Guess what ? > > > Testsuite summary for GNU patch 2.7.6 >

Re: bizarre failures on NetBSD 9.3 x86_64

2023-05-09 Thread Bruno Haible
Dennis Clarke wrote: > Seems to be a problem where a trivial Bourne shell for the user is not > good enough? What if you install GNU bash: # PKG_PATH=http://ftp.netbsd.org/pub/pkgsrc/packages/NetBSD/`uname -m`/9.3/All # export PKG_PATH # pkg_add bash and then repeat the build attempt?