SunOS 4 stopped being a reasonable portability target many
years ago, so this should be uncontroversial:
>From 8678ae92eac4712eadeeb72cec1b53b395a0e546 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Sun, 20 Feb 2011 11:00:59 +0100
Subject: [PATCH] maint: remove unnecessary tests before f
I noticed/fixed a minor leak:
>From 55d16c63f13898351cbd8c2d2309295c0d9507a8 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Thu, 10 Mar 2011 19:23:28 +0100
Subject: [PATCH] avoid a minor leak
* src/util.c (parse_c_string): Avoid a leak when realloc-to-smaller
returns a different poin
Bert Wesarg wrote:
> That would hit me by surprise. Quoting POSIX.1-2008 for realloc(3):
>
> If the new size of the memory object would require movement of the
> object, the space for the previous instantiation of the object is
> freed.
Indeed. Retracted.
Thanks.
st gnulib, since without
that, I get warnings (fixed long ago in gnulib) when running autoconf.
=======
>From 764d0ea12e5fd8b15ab32f724ffcba0be33dd73f Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Thu, 17 Mar 2011 11:01:49 +0100
Subject: [PATCH 1/2] do not version-control ChangeLog; instead, gene
anges from there.
How about this?
[I've deliberately not updated copyright year lists;
I have a patch to update all of those at once. ]
>From 7d41c04e7b98f360b52b3cb77b71860183c44042 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Mon, 21 Mar 2011 18:39:22 +0100
Subject: [PATCH] doc:
From: Jim Meyering
* cfg.mk (local-checks-to-skip): Define, to skip all of the
currently-failing syntax-check rules. We'll reenable them
one by one, as problems are addressed.
---
cfg.mk | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/cfg.mk b/c
From: Jim Meyering
* cfg.mk: New file, to configure maint.mk.
* Makefile.am (EXTRA_DIST): Add, so the new file is distributed.
(config_h_header): Define, to make the sc_require_config_h_first
syntax-check test pass.
* pc/chdirsaf.c: Include .
---
Makefile.am |1 +
cfg.mk| 21
From: Jim Meyering
* configure.ac (WERROR_CFLAGS): Don't turn off -Wmissing-prototypes.
* src/pch.c (skip_hex_digits): Declare static.
* src/bestmatch.h (bestmatch): Likewise.
---
configure.ac|1 -
src/bestmatch.h |2 +-
src/pch.c |2 +-
3 files changed, 2 insertions(
From: Jim Meyering
* bootstrap.conf (gnulib_modules): Add maintainer-makefile.
---
bootstrap.conf |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/bootstrap.conf b/bootstrap.conf
index 376e26e..f132349 100644
--- a/bootstrap.conf
+++ b/bootstrap.conf
@@ -36,6 +36,7
From: Jim Meyering
* src/patch.c (mangled_patch): Add "noreturn" attribute.
* src/pch.h (pch_timestamp): Remove ignored "const" attribute.
* src/version.c (XTERN): Remove unused #undef and #define.
---
src/patch.c |2 +-
src/pch.h |2 +-
src/version.c |2 --
other GNU packages.
Jim Meyering (15):
maint: use gnulib's maintainer-makefile module
maint: arrange for the sc_require_config_h_first test to pass
maint: add some m4 quoting
maint: remove trailing blanks
maint: allow the sc_prohibit_empty_lines_at_EOF test to pass
maint: avoid no
From: Jim Meyering
* bootstrap.conf: Remove trailing blanks.
* tests/reject-format: Define a dummy, empty variable, and use it in
here-doc to protect required trailing blanks from accidental removal.
* tests/no-newline-triggers-assert: Likewise.
* tests/preserve-c-function-names: Likewise
From: Jim Meyering
* m4/setmode.m4 (AC_FUNC_SETMODE_DOS): Use proper M4 quoting.
---
m4/setmode.m4 |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/m4/setmode.m4 b/m4/setmode.m4
index 74ead44..9b6e6b4 100644
--- a/m4/setmode.m4
+++ b/m4/setmode.m4
@@ -18,7 +18,7
From: Jim Meyering
* bootstrap.conf (gnulib_modules): Include gnulib's signal module,
so that signal.h guarantees definition of certain macros.
* src/util.c (SIG_BLOCK, SIG_UNBLOCK, SIG_SETMASK): Remove definition.
Now, gnulib guarantees that these are defined.
* src/common.h (SIZ
From: Jim Meyering
* bootstrap: Update from gnulib.
* cfg.mk (local-checks-to-skip): Remove (thus, enable)
sc_copyright_check, now that the gnulib submodule is up to date.
---
bootstrap | 223 -
cfg.mk|1 -
gnulib
From: Jim Meyering
* src/patch.c (main): Call set_program_name rather than
initializing program_name explicitly.
* src/common.h: Include progname.h rather than declaring the extern,
program_name.
* bootstrap.conf (gnulib_modules): Add progname.
* cfg.mk (local-checks-to-skip): Remove
From: Jim Meyering
* configure.ac (WERROR_CFLAGS): Don't turn off -Wmissing-declarations
and admit that it's not worth fixing the few warnings triggered
by -Wmissing-format-attribute.
---
configure.ac |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/conf
From: Jim Meyering
* tests/test-lib.sh: Remove empty line at end of file.
---
tests/test-lib.sh |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/tests/test-lib.sh b/tests/test-lib.sh
index 712bcd4..2dbfbcd 100644
--- a/tests/test-lib.sh
+++ b/tests/test-lib.sh
@@ -169,4
From: Jim Meyering
* bootstrap.conf (gnulib_modules): Add update-copyright.
Run "make update-copyright".
---
Makefile.am |4 ++--
NEWS |4 ++--
README|4 ++--
README-hacking
From: Jim Meyering
With these changes, "make sc_prohibit_test_minus_ao" almost passes.
Uses of "test -o" remain.
Note: unchecked uses of test -ot/-nt also remain.
* tests/empty-files: Use "test C1 && test C2", not "test C1 -a C2"
* tests/merge: Li
From: Jim Meyering
* configure.ac: Enable many options.
* bootstrap.conf (gnulib_modules): Add manywarnings.
* src/Makefile.am (AM_CFLAGS): Use $(WARN_CFLAGS) and $(WERROR_CFLAGS).
---
bootstrap.conf |1 +
configure.ac| 91 +++
m4
Andreas Gruenbacher wrote:
> Jim,
>
> On Saturday 26 March 2011 14:31:55 Jim Meyering wrote:
>> In the interest of getting patch into a form
>> that will integrate more easily with diffutils,
>> here are some changes that make most of gnulib's
>> syntax-ch
I ran coverity against patch and it reported this legitimate leak.
It was even triggered by the 'merge" test.
Here's the fix:
>From bc8a1013dfbdbb8fb103ba855283d2f22358e995 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Tue, 24 May 2011 11:47:25 +0200
Subject: [PATCH]
I did not try to see if fixing this bug changes how patch works.
>From f263642b2bfb76efca6d7df1d35f54bd10d81b2b Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Tue, 24 May 2011 12:11:32 +0200
Subject: [PATCH] avoid a used-uninitialized error
* src/util.c (fetchname): Avoid a u
Also reported by coverity, this leak was not triggered by "make check":
>From 0e2f8b74f81893e3bee59c891b6ecdc2d2d4a00f Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Tue, 24 May 2011 13:16:27 +0200
Subject: [PATCH] plug a leak in fetchname
* src/util.c (fetchname): Don't l
coverity griped about this, but it's obviously not a problem
to ignore any failure of this particular close call (we're already
reporting a prior read failure), so I've marked it as explicitly ignored:
>From 450cb907cc988a5cb8a729f0f8e3ad96d2bfb628 Mon Sep 17 00:00:00 2001
ions would have impacted correctness.
Here's the fix:
>From 508b50df8241456ab0a3a4829d3501cddf1167b9 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Tue, 24 May 2011 15:35:50 +0200
Subject: [PATCH] remove side effect from assert
* src/util.c (parse_c_string): Don't increment "s&q
I noticed the lone use of "perror" to diagnose this failure.
Here's a fix:
>From b74c057c3581666773150c53736791d2cdb22137 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Tue, 24 May 2011 15:51:51 +0200
Subject: [PATCH] emit one more diagnostic with the required "program
Another coverity-spotted buglet:
>From 12ee710119356ccb31ef02d324596b982734db9b Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Tue, 24 May 2011 16:20:59 +0200
Subject: [PATCH] don't call fdopen with a negative FD upon dup failure
* src/patch.c (open_outfile): If dup fails, don'
Andreas Gruenbacher wrote:
> On Wednesday 25 May 2011 15:41:47 Jim Meyering wrote:
>> Andreas Gruenbacher wrote:
>> > On Wednesday 25 May 2011 15:12:35 Jim Meyering wrote:
>> >> I can see the advantage of using the goto (single point of return and *PY
>> >
Andreas Gruenbacher wrote:
> On Tuesday 24 May 2011 13:15:37 Jim Meyering wrote:
>> I did not try to see if fixing this bug changes how patch works.
>
> It doesn't as far as I can see. It doesn't fix a real bug either, but avoids
> a static checker error (so it&
Andreas Gruenbacher wrote:
> On Tuesday 24 May 2011 12:02:02 Jim Meyering wrote:
>> I ran coverity against patch and it reported this legitimate leak.
>> It was even triggered by the 'merge" test.
>
> looks correct, but can we use the existing exit path in this f
Andreas Gruenbacher wrote:
> On Wednesday 25 May 2011 15:12:35 Jim Meyering wrote:
>> I can see the advantage of using the goto (single point of return and *PY is
>> always set). However, using the goto suggests you'd have to update the
>> description to say what *P
Andreas Gruenbacher wrote:
> On Wednesday 25 May 2011 16:21:42 Jim Meyering wrote:
>> Here's the result:
>
> Great, thanks.
I've pushed those 8 patches.
Here are two patches:
The first prevents make distcheck failure,
and the second helps Mac OS 10.5 users who use patch
to operate on very large files.
>From f935ba6ad3b2e2962a7ca7d7204d168a6c008d53 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Mon, 1 Aug 2011 10:09:25 +0200
Subject: [PATC
Andreas Gruenbacher wrote:
> On Wed, 2011-08-10 at 16:55 +0200, Jim Meyering wrote:
>> Here are two patches:
>>
>> The first prevents make distcheck failure,
>> and the second helps Mac OS 10.5 users who use patch
>> to operate on very large files.
>
> both p
gt; Input file attached.
>
> Original bug report:
> https://bugzilla.redhat.com/show_bug.cgi?id=738959
Hi Tim,
Thanks for forwarding that.
Here's a proposed patch:
>From dbcd5ea048f26caa3f6aa08ca883aedae58d88f0 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Sat, 8 Oct 2011 23
I've disabled that one.
There were also a couple of false-positives to new syntax-check
rules, which I've exempted.
Ok to push?
>From 5cb38ce3903b5c33750cd52f983a8f68f945c7dd Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Sun, 9 Oct 2011 11:40:42 +0200
Subject: [PATCH] build: updat
Andreas Gruenbacher wrote:
> Jim,
>
> On Wed, 2011-12-14 at 16:40 +0100, Jim Meyering wrote:
>> There have been a lot of changes in gnulib (over 650 change sets),
>> so I updated. That pulled in a few new gcc warning options that
>> suggest additions of the const and p
I've done this:
maint: update all copyright year number ranges
Run "make update-copyright".
>From d504183866dccdf8e7c09522b601236d91591141 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Sun, 1 Jan 2012 10:54:51 +0100
Subject: [PATCH 1/2] maint: enable the useless_cpp_parens syntax-check rule
* cfg.mk (local-checks-to-skip): Remove sc_useless_cpp_parens,
thus enabling this syntax-check rule.
* src
Andreas Gruenbacher wrote:
> On Sun, 2012-01-01 at 22:40 +0100, Jim Meyering wrote:
>> These seem uncontroversial
>
> yes, the changes look fine.
Thanks for the review. Pushed.
2 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Thu, 16 Feb 2012 14:36:11 +0100
Subject: [PATCH 1/2] build: update bootstrap from gnulib and adapt
* bootstrap: Update from gnulib.
* bootstrap.conf (gnulib_tool_option_extras): Define.
* lib/Makefile.am: Initialize numerous automake vari
Andreas Grünbacher wrote:
> Am 6. April 2012 14:09 schrieb Jean Delvare :
>> This commit [...] is broken.
>> bad[] holds pointers to the name strings, and these get freed
>> when switching to the next hunk in the patch file (if I read the code
>> properly...) So you end up accessing freed memory. V
Andreas Grünbacher wrote:
> Jean,
>
> Am 6. April 2012 14:09 schrieb Jean Delvare :
>> This commit [...] is broken.
>> bad[] holds pointers to the name strings, and these get freed
>> when switching to the next hunk in the patch file (if I read the code
>> properly...) So you end up accessing free
Andreas Gruenbacher wrote:
> Jim,
>
> On Friday 06 April 2012 15:25:30 Jim Meyering wrote:
>> +static void
>> +add_bad (char *bad[], char const *name)
>> +{
>> + char **p = &bad[!! bad[0]];
>
> we remember the first and last bad name here, not all t
Andreas Gruenbacher wrote:
> On Friday 06 April 2012 18:41:46 Jim Meyering wrote:
>> Andreas Gruenbacher wrote:
>> > we remember the first and last bad name here, not all the bad names of the
>> > last patch (bad[0] is never cleared), so that's a bug.
>>
&
This probably counts as trivial, but with an impending release
I'll wait for an ACK before pushing it.
>From 7ce9bbfdb5d671702e3eabc921fb99b195367e91 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Wed, 1 Aug 2012 14:33:39 +0200
Subject: [PATCH] build: remove unnecessary if-before-fre
ribute=pure]
>From 4b53f76083b1557b529968159fe88581d89058a4 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Wed, 1 Aug 2012 14:32:33 +0200
Subject: [PATCH] build: mark an internal function as "pure"
* src/pch.c (sha1_says_nonexistent): Apply _GL_ATTRIBUTE_PURE,
to avoid failure wi
> 2012/8/1 Jim Meyering :
>> This probably counts as trivial, but with an impending release
>> I'll wait for an ACK before pushing it.
>
> this looks okay.
Thanks. I've pushed both.
-p0 --dry-run
==11391== Command: patch -f -e
==11460== Command: patch -f -p0 --dry-run
==11491== Command: patch f
==11721== Command: patch -f -p0
==11729== Command: patch c
This patch fixes it:
>From 94aaeff8afa7e1cf1c5107470644f8b374d9cc00 Mon Sep 17 00:00:00 2001
From:
Paul Eggert wrote:
> On 08/02/2012 01:02 PM, Andreas Grünbacher wrote:
>> Paul and Jim, any thoughts about adding filename quoting to GNU diff anytime
>> soon, or about the format?
>
> The git format looks OK. I don't have time right now to add it to GNU diff,
> tho.
I agree, and have no more fr
file has the same size:
$ wc t/gettext-macros*
11 42 370 t/gettext-macros.sh.rej
105 5673802 t/gettext-macros.sh.~1~
...
Here is the contents of the file, "k":
>From 73cc55ac3a3102ec02df88823ebb0ff650b25de7 Mon Sep 17 00:00:0
Andreas Grünbacher wrote:
> 2012/9/12 Jim Meyering :
>> This takes place on automake's "maint" branch:
>> commit 9c4ad6973eedb074a9381e14a6c1eeeb285c2465
>>
>> It looks like when patch application fails, patch renames the
>> target to the
n similar code in coreutils, it was not
worthwhile)
>From b272c2d535c3d9d6ff30ec83b5fa6e97aa3545f1 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Sat, 22 Sep 2012 21:35:04 +0200
Subject: [PATCH] build: avoid gcc warnings from -Wsuggest-attribute=format
* configure.ac (WARN_CFLAGS): Disable -Wsuggest-attribute=for
Mateusz Cieciura wrote:
> Hello,
>
> I have been trying to use Patch 2.6.1 on Grml 3.7.9 in order to patch
> a Xserver configuration file.
> I would like to do it in a shell script:
>
> #!/bin/sh
> #grml-patch-xserverrc
>
> patch -p0 < --- /etc/X11/xinit/xserverrc2012-06-16 23:54:02.0
Stefano Lattarini wrote:
> On 04/24/2013 01:19 PM, Stefano Lattarini wrote:
>> Doing so prevents bootstrapping with bleeding-edge autotools,
>> because of harmless deprecation warnings (that are not planned
>> to become hard errors for at least a few years to come). And
>> unfortunately, options
Jim Meyering wrote:
> Stefano Lattarini wrote:
>> On 04/24/2013 01:19 PM, Stefano Lattarini wrote:
>>> Doing so prevents bootstrapping with bleeding-edge autotools,
>>> because of harmless deprecation warnings (that are not planned
>>> to become hard errors for
last update):
[PATCH 1/4] gnulib: update to latest
[PATCH 2/4] maint: avoid new warning-errors from gcc-6.1
[PATCH 3/4] maint: placate a "make syntax-check" rule
[PATCH 4/4] tests: use $PATCH rather than hard-coded path
From a1a8908992368a74b62ce8ec22429a5639dd95fb Mon Sep 17 00:00:00 200
Hi Andreas,
I configured with --enable-gcc-warnings and bleeding-edge gcc
(version 8.0.1 20180406) and hit some warning-escalated-to-errors.
This fixes them:
>From a71ddb200dbe7ac0f9258796b5a51979b2740e88 Mon Sep 17 00:00:00 2001
From: Jim Meyering
Date: Fri, 6 Apr 2018 16:47:00 -0700
Subj
60 matches
Mail list logo
