Re: Patch 2.7.6 and deep-directories failed test
Am Do., 7. Jan. 2021 um 23:17 Uhr schrieb Jeffrey Walton : > On Thu, Jan 7, 2021 at 4:57 PM Andreas Grünbacher wrote: > > ... > > > > That again doesn't reproduce for me (on Fedora 32). Did you try a > > > > fresh checkout of the patch git repository? Are you possibly on a > > > > different version of gnulib (should be > > > > 48e8cffee6a67859119e7df9dc53c8f775daba89)? > > > > > > I believe Gnulib is the tip of master. I did not do anything special > > > with Gnulib. Bootstrap fetched Gnulib for me. > > > > If the bootstrap script did the gnulib checkout for you, you should > > end up with the matching version of gnulib. > > OK, Ubuntu was not able to compile master. Fedora 33 was able to compile > master. I don't have Ubuntu, so I can't easily check what's going wrong there. I'm getting the same result with Fedora 33 here, though. > Fedora 33 patch master also failed deep-directories. Not here, interestingly. I wonder what the difference in our setups is. > Running the test > manually is shown below. This error was present regardless of where I > ran the tests from: > > tests$ ./deep-directories > ./deep-directories: line 7: /test-lib.sh: No such file or directory > ./deep-directories: line 9: require: command not found > ./deep-directories: line 10: use_local_patch: command not found > ./deep-directories: line 11: use_tmpdir: command not found > ./deep-directories: line 26: check: command not found > > $ ./tests/deep-directories > ./tests/deep-directories: line 7: /test-lib.sh: No such file or directory > ./tests/deep-directories: line 9: require: command not found > ./tests/deep-directories: line 10: use_local_patch: command not found > ./tests/deep-directories: line 11: use_tmpdir: command not found > ./tests/deep-directories: line 26: check: command not found > > patch-master$ find . -name test-libs.sh > patch-master$ You can run the test manually as follows: srcdir=tests abs_top_builddir=$PWD tests/deep-directories Andreas
Re: Patch 2.7.6 and deep-directories failed test
On Thu, Jan 7, 2021 at 4:57 PM Andreas Grünbacher wrote: > ... > > > That again doesn't reproduce for me (on Fedora 32). Did you try a > > > fresh checkout of the patch git repository? Are you possibly on a > > > different version of gnulib (should be > > > 48e8cffee6a67859119e7df9dc53c8f775daba89)? > > > > I believe Gnulib is the tip of master. I did not do anything special > > with Gnulib. Bootstrap fetched Gnulib for me. > > If the bootstrap script did the gnulib checkout for you, you should > end up with the matching version of gnulib. OK, Ubuntu was not able to compile master. Fedora 33 was able to compile master. Fedora 33 patch master also failed deep-directories. Running the test manually is shown below. This error was present regardless of where I ran the tests from: tests$ ./deep-directories ./deep-directories: line 7: /test-lib.sh: No such file or directory ./deep-directories: line 9: require: command not found ./deep-directories: line 10: use_local_patch: command not found ./deep-directories: line 11: use_tmpdir: command not found ./deep-directories: line 26: check: command not found $ ./tests/deep-directories ./tests/deep-directories: line 7: /test-lib.sh: No such file or directory ./tests/deep-directories: line 9: require: command not found ./tests/deep-directories: line 10: use_local_patch: command not found ./tests/deep-directories: line 11: use_tmpdir: command not found ./tests/deep-directories: line 26: check: command not found patch-master$ find . -name test-libs.sh patch-master$ Jeff
Re: Patch 2.7.6 and deep-directories failed test
Am Do., 7. Jan. 2021 um 22:42 Uhr schrieb Jeffrey Walton : > On Thu, Jan 7, 2021 at 4:39 PM Andreas Grünbacher wrote: > > Am Do., 7. Jan. 2021 um 22:24 Uhr schrieb Jeffrey Walton > > : > > > On Thu, Jan 7, 2021 at 4:09 PM Andreas Grünbacher wrote: > > > > Am Do., 7. Jan. 2021 um 20:40 Uhr schrieb Jeffrey Walton > > > > : > > > > > Hi Everyone, > > > > > > > > > > I'm testing Patch 2.7.6 on Ubuntu 18.05, x86_64 fully patched. Patch > > > > > is failing one self test: > > > > > > > > > > # TOTAL: 44 > > > > > # PASS: 41 > > > > > # SKIP: 0 > > > > > # XFAIL: 2 > > > > > # FAIL: 1 > > > > > # XPASS: 0 > > > > > # ERROR: 0 > > > > > > > > > > And: > > > > > > > > > > $ cat patch-2.7.6/tests/deep-directories.log > > > > > [26] patch -p1 < ab.diff || echo Status: $? -- FAILED > > > > > --- expected > > > > > +++ got > > > > > @@ -1 +1,2 @@ > > > > > -patching file 1/2/3/4/5/6/7/8/9/foo > > > > > +/home/jwalton/Build-Scripts/patch-2.7.6/src/patch: Can't create > > > > > temporary file 1/2/3/4/5/6/7/8/9/foo.oV1sAfd : Too many open files > > > > > +Status: 2 > > > > > 1 tests (0 passed, 1 failed) > > > > > FAIL deep-directories (exit status: 1) > > > > > > > > > > If deep-directories can fail, it seems like it should be an XFAIL, > > > > > not a FAIL. > > > > > > > > The test shouldn't fail, but I also don't think this is a known defect > > > > in patch 2.7.6, and the bug doesn't trigger here for me, either. > > > > > > > > What do you get with the latest code from patch's git repository? > > > > > > I was able to bootstrap and configure, but make failed: > > > > > > ... > > > /usr/bin/cc -DHAVE_CONFIG_H -I. -I.. > > > -I/home/jwalton/ok2delete/include -DNDEBUG -g2 -O2 -march=native > > > -fPIC -pthread -MT parse-datetime.o -MD -MP -MF > > > .deps/parse-datetime.Tpo -c -o parse-datetime.o parse-datetime.c > > > parse-datetime.tab.c:646:10: fatal error: parse-datetime.tab.h: No > > > such file or directory > > > compilation terminated. > > > Makefile:1731: recipe for target 'parse-datetime.o' failed > > > make[3]: *** [parse-datetime.o] Error 1 > > > make[3]: *** Waiting for unfinished jobs > > > mv -f .deps/opendirat.Tpo .deps/opendirat.Po > > > mv -f .deps/gl_linked_list.Tpo .deps/gl_linked_list.Po > > > mv -f .deps/progname.Tpo .deps/progname.Po > > > mv -f .deps/hash.Tpo .deps/hash.Po > > > mv -f .deps/nstrftime.Tpo .deps/nstrftime.Po > > > make[3]: Leaving directory '/home/jwalton/Build-Scripts/patch-master/lib' > > > Makefile:1514: recipe for target 'all' failed > > > > That again doesn't reproduce for me (on Fedora 32). Did you try a > > fresh checkout of the patch git repository? Are you possibly on a > > different version of gnulib (should be > > 48e8cffee6a67859119e7df9dc53c8f775daba89)? > > :) > > I believe Gnulib is the tip of master. I did not do anything special > with Gnulib. Bootstrap fetched Gnulib for me. If the bootstrap script did the gnulib checkout for you, you should end up with the matching version of gnulib. Andreas
Re: Patch 2.7.6 and deep-directories failed test
Am Do., 7. Jan. 2021 um 22:24 Uhr schrieb Jeffrey Walton : > On Thu, Jan 7, 2021 at 4:09 PM Andreas Grünbacher wrote: > > Am Do., 7. Jan. 2021 um 20:40 Uhr schrieb Jeffrey Walton > > : > > > Hi Everyone, > > > > > > I'm testing Patch 2.7.6 on Ubuntu 18.05, x86_64 fully patched. Patch > > > is failing one self test: > > > > > > # TOTAL: 44 > > > # PASS: 41 > > > # SKIP: 0 > > > # XFAIL: 2 > > > # FAIL: 1 > > > # XPASS: 0 > > > # ERROR: 0 > > > > > > And: > > > > > > $ cat patch-2.7.6/tests/deep-directories.log > > > [26] patch -p1 < ab.diff || echo Status: $? -- FAILED > > > --- expected > > > +++ got > > > @@ -1 +1,2 @@ > > > -patching file 1/2/3/4/5/6/7/8/9/foo > > > +/home/jwalton/Build-Scripts/patch-2.7.6/src/patch: Can't create > > > temporary file 1/2/3/4/5/6/7/8/9/foo.oV1sAfd : Too many open files > > > +Status: 2 > > > 1 tests (0 passed, 1 failed) > > > FAIL deep-directories (exit status: 1) > > > > > > If deep-directories can fail, it seems like it should be an XFAIL, not a > > > FAIL. > > > > The test shouldn't fail, but I also don't think this is a known defect > > in patch 2.7.6, and the bug doesn't trigger here for me, either. > > > > What do you get with the latest code from patch's git repository? > > I was able to bootstrap and configure, but make failed: > > ... > /usr/bin/cc -DHAVE_CONFIG_H -I. -I.. > -I/home/jwalton/ok2delete/include -DNDEBUG -g2 -O2 -march=native > -fPIC -pthread -MT parse-datetime.o -MD -MP -MF > .deps/parse-datetime.Tpo -c -o parse-datetime.o parse-datetime.c > parse-datetime.tab.c:646:10: fatal error: parse-datetime.tab.h: No > such file or directory > compilation terminated. > Makefile:1731: recipe for target 'parse-datetime.o' failed > make[3]: *** [parse-datetime.o] Error 1 > make[3]: *** Waiting for unfinished jobs > mv -f .deps/opendirat.Tpo .deps/opendirat.Po > mv -f .deps/gl_linked_list.Tpo .deps/gl_linked_list.Po > mv -f .deps/progname.Tpo .deps/progname.Po > mv -f .deps/hash.Tpo .deps/hash.Po > mv -f .deps/nstrftime.Tpo .deps/nstrftime.Po > make[3]: Leaving directory '/home/jwalton/Build-Scripts/patch-master/lib' > Makefile:1514: recipe for target 'all' failed That again doesn't reproduce for me (on Fedora 32). Did you try a fresh checkout of the patch git repository? Are you possibly on a different version of gnulib (should be 48e8cffee6a67859119e7df9dc53c8f775daba89)? Thanks, Andreas
Re: Patch 2.7.6 and deep-directories failed test
On Thu, Jan 7, 2021 at 4:09 PM Andreas Grünbacher wrote: > > ... > > If deep-directories can fail, it seems like it should be an XFAIL, not a > > FAIL. > > The test shouldn't fail, but I also don't think this is a known defect > in patch 2.7.6, and the bug doesn't trigger here for me, either. I probably should have mentioned... I am seeing the failure on Ubuntu 18 and Fedora 33. Jeff
Re: Patch 2.7.6 and deep-directories failed test
On Thu, Jan 7, 2021 at 4:09 PM Andreas Grünbacher wrote: > > Am Do., 7. Jan. 2021 um 20:40 Uhr schrieb Jeffrey Walton : > > Hi Everyone, > > > > I'm testing Patch 2.7.6 on Ubuntu 18.05, x86_64 fully patched. Patch > > is failing one self test: > > > > # TOTAL: 44 > > # PASS: 41 > > # SKIP: 0 > > # XFAIL: 2 > > # FAIL: 1 > > # XPASS: 0 > > # ERROR: 0 > > > > And: > > > > $ cat patch-2.7.6/tests/deep-directories.log > > [26] patch -p1 < ab.diff || echo Status: $? -- FAILED > > --- expected > > +++ got > > @@ -1 +1,2 @@ > > -patching file 1/2/3/4/5/6/7/8/9/foo > > +/home/jwalton/Build-Scripts/patch-2.7.6/src/patch: Can't create > > temporary file 1/2/3/4/5/6/7/8/9/foo.oV1sAfd : Too many open files > > +Status: 2 > > 1 tests (0 passed, 1 failed) > > FAIL deep-directories (exit status: 1) > > > > If deep-directories can fail, it seems like it should be an XFAIL, not a > > FAIL. > > The test shouldn't fail, but I also don't think this is a known defect > in patch 2.7.6, and the bug doesn't trigger here for me, either. > > What do you get with the latest code from patch's git repository? I was able to bootstrap and configure, but make failed: ... /usr/bin/cc -DHAVE_CONFIG_H -I. -I.. -I/home/jwalton/ok2delete/include -DNDEBUG -g2 -O2 -march=native -fPIC -pthread -MT parse-datetime.o -MD -MP -MF .deps/parse-datetime.Tpo -c -o parse-datetime.o parse-datetime.c parse-datetime.tab.c:646:10: fatal error: parse-datetime.tab.h: No such file or directory compilation terminated. Makefile:1731: recipe for target 'parse-datetime.o' failed make[3]: *** [parse-datetime.o] Error 1 make[3]: *** Waiting for unfinished jobs mv -f .deps/opendirat.Tpo .deps/opendirat.Po mv -f .deps/gl_linked_list.Tpo .deps/gl_linked_list.Po mv -f .deps/progname.Tpo .deps/progname.Po mv -f .deps/hash.Tpo .deps/hash.Po mv -f .deps/nstrftime.Tpo .deps/nstrftime.Po make[3]: Leaving directory '/home/jwalton/Build-Scripts/patch-master/lib' Makefile:1514: recipe for target 'all' failed Jeff
Re: Patch 2.7.6 and deep-directories failed test
Hi, Am Do., 7. Jan. 2021 um 20:40 Uhr schrieb Jeffrey Walton : > Hi Everyone, > > I'm testing Patch 2.7.6 on Ubuntu 18.05, x86_64 fully patched. Patch > is failing one self test: > > # TOTAL: 44 > # PASS: 41 > # SKIP: 0 > # XFAIL: 2 > # FAIL: 1 > # XPASS: 0 > # ERROR: 0 > > And: > > $ cat patch-2.7.6/tests/deep-directories.log > [26] patch -p1 < ab.diff || echo Status: $? -- FAILED > --- expected > +++ got > @@ -1 +1,2 @@ > -patching file 1/2/3/4/5/6/7/8/9/foo > +/home/jwalton/Build-Scripts/patch-2.7.6/src/patch: Can't create > temporary file 1/2/3/4/5/6/7/8/9/foo.oV1sAfd : Too many open files > +Status: 2 > 1 tests (0 passed, 1 failed) > FAIL deep-directories (exit status: 1) > > If deep-directories can fail, it seems like it should be an XFAIL, not a FAIL. The test shouldn't fail, but I also don't think this is a known defect in patch 2.7.6, and the bug doesn't trigger here for me, either. What do you get with the latest code from patch's git repository? Thanks, Andreas
