Sorry for trashing CC list, recovering..
> > It seems that it comes from mailutils (but not mentioned in your patch
> > - not in mailutils)
>
> Actually it is not. It comes from one of my projects:
>
>https://puszcza.gnu.org.ua/projects/grecs
>
> and I synchronize it with mailutils from ti
Pavel Raiskup ha escrit:
> Isn't that nice candidate for gnulib then?
Yes, quite probably. I haven't yet thought about it, thanks for the
suggestion :)
> Yes, maybe not complete list of warnings/errors:
Obviously, you use -Werror, which I'd rather recommend against.
Making something like
>
Pavel Raiskup ha escrit:
> It seems that it comes from mailutils (but not mentioned in your patch
> - not in mailutils)
Actually it is not. It comes from one of my projects:
https://puszcza.gnu.org.ua/projects/grecs
and I synchronize it with mailutils from time to time. In the future I
pl
On 02/20/2013 11:30 AM, Sergey Poznyakoff wrote:
> Hi Paul,
>
>> Developers are assumed to have up-to-date systems where -Werror is
>> appropriate.
>
> Frankly, I cannot imagine a situation where treaing a warning as an
> error can be appropriate. That's why I consider it unfortunate.
If code c
Pavel Raiskup ha escrit:
> Do not call wordsplit on multiple places when not necessary.
>
> (run_decompress_program): Do not call wordsplit - rather reuse xexec.
That's wrong. The intent of the function is to try all matching
decompressors and find the one which works. Xexec cannot be used her
Hi Paul,
> Developers are assumed to have up-to-date systems where -Werror is
> appropriate.
Frankly, I cannot imagine a situation where treaing a warning as an
error can be appropriate. That's why I consider it unfortunate.
> I'm surprised you didn't run into this.
That's quite simple. Confi
On Wed, 2013-02-20 at 14:42 +0300, Sergey Poznyakoff wrote:
>> Yes, maybe not complete list of warnings/errors:
>
> Obviously, you use -Werror, which I'd rather recommend against.
> Making something like
It was just sugestion as tar uses -Werror by default since this commit:
http://git.savanna
Do not call wordsplit on multiple places when not necessary.
Move the xexec function into #ifndef MSDOS part of file.
* system.c (try_exec): New function - modified previous xexec.
(xexec): Re-use try_exec and fail when not try_exec unsuccessful.
(run_decompress_program): Do not call wordsplit - r
On 02/20/2013 05:15 AM, Sergey Poznyakoff wrote:
> Pavel Raiskup ha escrit:
>
>> It was just sugestion as tar uses -Werror by default since this commit:
>
> Ouch! A very unfortunate move, I must say.
It works well in other projects, such as coreutils: 'make' uses -Werror
only for developers, wh
On Wed, 2013-02-20 at 16:28 +0300, Sergey Poznyakoff wrote:
> Pavel Raiskup ha escrit:
>
> > Move the xexec function into #ifndef MSDOS part of file.
>
> Yes, that's reasonable.
>
> > * system.c (try_exec): New function - modified previous xexec.
>
> This will cause a memory leak and imply unn
Pavel Raiskup ha escrit:
> Move the xexec function into #ifndef MSDOS part of file.
Yes, that's reasonable.
> * system.c (try_exec): New function - modified previous xexec.
This will cause a memory leak and imply unnecessary memory
reallocations.
What happens here is:
487 if (wordsplit
Pavel Raiskup ha escrit:
> It was just sugestion as tar uses -Werror by default since this commit:
Ouch! A very unfortunate move, I must say.
Regards,
Sergey
>> In short, there would be nice to allow maintainers to specify something
>> like this:
>>
>> ./configure --with-lzma="xz --format=lzma"
>
> I have pushed the necessary fixes (commit 7b5e8039). Any option taking
> a command name as its argument now accepts a full command line as well.
Do not call wordsplit on multiple places when not necessary.
* system.c (sys_child_open_for_compress): Trim line.
(run_decompress_program): Do not call wordsplit - rather reuse xexec.
(sys_exec_command): Remove unused variable argv.
---
src/system.c | 40 +---
14 matches
Mail list logo
