Re: [Bug-tar] [patch v3] Bug / question in tar

2014-03-13 Thread Pavel Raiskup
On Thursday, March 13, 2014 17:19:10 Paul Eggert wrote: > Pavel Raiskup wrote: > > Do you feel the patch is acceptable, you feel (or just plan > > to) prepare some patch or possibly - should I fix something > > in the patch? > > I'd like to see Sergey's opinion. I wanted to say the same :). Serg

Re: [Bug-tar] [patch v3] Bug / question in tar

2014-03-13 Thread Paul Eggert
Pavel Raiskup wrote: Do you feel the patch is acceptable, you feel (or just plan to) prepare some patch or possibly - should I fix something in the patch? I'd like to see Sergey's opinion.

Re: [Bug-tar] [patch v3] Bug / question in tar

2014-03-13 Thread Pavel Raiskup
On Thursday, March 13, 2014 13:56:25 Paul Eggert wrote: > Thanks, you've convinced me I would be proud to see something like the proposed patch pushed upstream then. At least bugreports relevant to this incorrect use will never occur again. Do you feel the patch is acceptable, you feel (or just

[Bug-tar] infinite loop in sparse_dump_region()

2014-03-13 Thread François Ouellet
When dumping a file which is being actively updated by an application (in our case it was an outlook pst file on our samba server), safe_read() can sometimes return 0. When it happens, sparse_dump_region() goes into an infinite loop. I don't know what the proper fix would be. I just fixed it on

Re: [Bug-tar] [patch v3] Bug / question in tar

2014-03-13 Thread Markus Steinborn
Pavel Raiskup schrieb: Marcus, you are still able to 'cat | tar -x -f -'. I also don't think that 'tar -x' differs from 'tar -x -f -' because the '-f -' is just an './configure' time default which may differ from setup to setup (yes, yes, the default seems to be always '-f -', though). BTW, fro

Re: [Bug-tar] [patch v3] Bug / question in tar

2014-03-13 Thread Paul Eggert
On 03/13/2014 01:32 PM, Pavel Raiskup wrote: But I would like to convince you once more, Paul. Thanks, you've convinced me that your original idea is better and that we don't need to go the xargs route. The difference is that tar input is binary, typically, and it'd be pretty rare for someon

Re: [Bug-tar] [patch v3] Bug / question in tar

2014-03-13 Thread Pavel Raiskup
Eric Blake: > On 03/13/2014 12:00 PM, Paul Eggert wrote: > > On 03/13/2014 10:32 AM, Pavel Raiskup wrote: > >> Strictly > >> speaking, GNU Coding Guidelines are talking about program_output_ > > > > You're right, and I hadn't noticed that. How about doing things the way > > xargs does them, as Er

Re: [Bug-tar] [patch v3] Bug / question in tar

2014-03-13 Thread Eric Blake
On 03/13/2014 12:00 PM, Paul Eggert wrote: > On 03/13/2014 10:32 AM, Pavel Raiskup wrote: >> Strictly >> speaking, GNU Coding Guidelines are talking about program_output_ > > You're right, and I hadn't noticed that. How about doing things the way > xargs does them, as Eric Blake pointed out? Tha

Re: [Bug-tar] [patch v3] Bug / question in tar

2014-03-13 Thread Markus Steinborn
Hi Paul, Hi Pavel, Paul Eggert wrote On 03/13/2014 10:32 AM, Pavel Raiskup wrote: Strictly speaking, GNU Coding Guidelines are talking about program_output_ You're right, and I hadn't noticed that. How about doing things the way xargs does them, as Eric Blake pointed out? That seems like a

Re: [Bug-tar] [patch v3] Bug / question in tar

2014-03-13 Thread Paul Eggert
On 03/13/2014 10:32 AM, Pavel Raiskup wrote: Strictly speaking, GNU Coding Guidelines are talking about program_output_ You're right, and I hadn't noticed that. How about doing things the way xargs does them, as Eric Blake pointed out? That seems like a nice compromise.

Re: [Bug-tar] Bug / question in tar

2014-03-13 Thread Eric Blake
On 03/13/2014 10:35 AM, Paul Eggert wrote: > On 03/13/2014 01:21 AM, Pavel Raiskup wrote: >>> We could detect that archive contents are coming from terminal input and >>> fail immediately (IIRC tar waits indefinitely ATM until it's input is >>> cut >>> by ctrl+d or it is killed). >> I meant somethi

Re: [Bug-tar] [patch v3] Bug / question in tar

2014-03-13 Thread Pavel Raiskup
On Thursday, March 13, 2014 09:35:26 Paul Eggert wrote: > On 03/13/2014 01:21 AM, Pavel Raiskup wrote: > >> We could detect that archive contents are coming from terminal input and > >> fail immediately (IIRC tar waits indefinitely ATM until it's input is cut > >> by ctrl+d or it is killed). > > I

Re: [Bug-tar] solaris 9 compile failure

2014-03-13 Thread Jesse C
this compiles gnu tar 1.27.1 without complaint for me: env CC='gcc -Dstrtoimax=strtoll -Dstrtoumax=strtoull' ./configure; gmake thank you!

Re: [Bug-tar] Bug / question in tar

2014-03-13 Thread Paul Eggert
On 03/13/2014 01:21 AM, Pavel Raiskup wrote: We could detect that archive contents are coming from terminal input and fail immediately (IIRC tar waits indefinitely ATM until it's input is cut by ctrl+d or it is killed). I meant something like the patch attached, could you please consider? I tri

Re: [Bug-tar] [patch v2] Archive contents should not go to/from terminal (was: Bug / question in tar)

2014-03-13 Thread Pavel Raiskup
On Thursday, March 13, 2014 09:21:44 Pavel Raiskup wrote: > > We could detect that archive contents are coming from terminal input and > > fail immediately (IIRC tar waits indefinitely ATM until it's input is cut > > by ctrl+d or it is killed). > > I meant something like the patch attached, could

Re: [Bug-tar] Bug / question in tar

2014-03-13 Thread Antonio Diaz Diaz
Pavel Raiskup wrote: We could detect that archive contents are coming from terminal input and fail immediately (IIRC tar waits indefinitely ATM until it's input is cut by ctrl+d or it is killed). I think this may be a good idea. It is a common feature among the compressors used by tar: $ l

Re: [Bug-tar] Bug / question in tar

2014-03-13 Thread Pavel Raiskup
> We could detect that archive contents are coming from terminal input and > fail immediately (IIRC tar waits indefinitely ATM until it's input is cut > by ctrl+d or it is killed). I meant something like the patch attached, could you please consider? I tried to write testcase for this and I faile