Re: Skip filename recoding tests on MS-Windows

2022-10-23 Thread Gavin Smith
On Sun, Oct 23, 2022 at 08:13:24PM +0300, Eli Zaretskii wrote: > > I am pretty sure that this file is correctly generated, I guess that > > מ corresponds to the same octet than î in latin1, which is 0xEE unless I > > missed something, and your codepage would be Windows-1255, maybe? > > Yes, it

texindex awk syntax error

2022-10-23 Thread Gavin Smith
On Sun, Oct 23, 2022 at 04:59:46PM +0200, Bruno Haible wrote: > Once the compilation error is fixed, "gmake check" fails: > > FAIL: tests/ti-helpversion.sh > > Find attached the log. > > On this platform, awk is /usr/bin/awk. Not GNU awk. If 'texindex' works only > with GNU awk, it ought to

Re: Skip filename recoding tests on MS-Windows

2022-10-23 Thread pertusus
On Sun, Oct 23, 2022 at 05:30:24PM +0300, Eli Zaretskii wrote: > > Date: Sun, 23 Oct 2022 14:44:33 +0200 > > From: pertu...@free.fr > > Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org > > > Thanks, I've done that, and now at least the first part of the test > suite, in test_scripts/, does run.

Re: texinfo-6.8.90 pretest

2022-10-23 Thread pertusus
On Sun, Oct 23, 2022 at 04:54:31PM +0300, Eli Zaretskii wrote: > > My guess is that it is a bug, as in HTML it seems to me that there > > should only be forward slashes. > > Yes. > > Any hints where I should look for the source of these backslashes? I tracked it down to tp/ext/epub3.pm and

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Gavin Smith
On Sun, Oct 23, 2022 at 03:03:27PM +0300, Eli Zaretskii wrote: > If you mean the message strings (as in error messages etc.), I'm not > sure I understand. No, strings for documents. For example, "Next: " in a navigation header in an HTML file, which should be translated appropriately if the

Re: Skip filename recoding tests on MS-Windows

2022-10-23 Thread pertusus
On Sun, Oct 23, 2022 at 11:45:15AM +0100, Gavin Smith wrote: > With your setup, it breaks at the very beginning, in the Makefile > rule. It would seem to be simple to eliminate the reference to > "included_latîn1.texi" from the Makefile. Then we have to make > sure the tests are skipped. I

macOS test failures - LC_ALL / LC_CTYPE / LC_MESSAGES

2022-10-23 Thread Gavin Smith
On Sun, Oct 23, 2022 at 12:49:26AM +0200, Bruno Haible wrote: > On macOS 10.13, with perl v5.28.3, two tests fail: > > FAIL: test_scripts/layout_formatting_info.sh > FAIL: test_scripts/layout_formatting_plaintext.sh > > Find attached the logs. It looks like the line breaking is different than >

Re: texinfo-6.8.90 pretest on mingw

2022-10-23 Thread Gavin Smith
On Sun, Oct 23, 2022 at 11:55:09AM +0100, Gavin Smith wrote: > There doesn't appear to be a similar option for 'grep'. However, > since it is just the one test, we can easily work around the problem > by taking the '$' out - the test in question would still work properly. Done in commit

Re: texinfo-6.8.90 pretest and BSD make

2022-10-23 Thread Gavin Smith
On Sat, Oct 22, 2022 at 11:43:55PM +0200, Bruno Haible wrote: > Texinfo/Commands.pm: Texinfo/XS/parsetexi/command_data.txt > $(MKDIR_P) Texinfo > - $(srcdir)/maintain/regenerate_commands_perl_info.pl < $< > + $(srcdir)/maintain/regenerate_commands_perl_info.pl < >

Re: Skip filename recoding tests on MS-Windows

2022-10-23 Thread Eli Zaretskii
> Date: Sun, 23 Oct 2022 17:25:26 +0200 > From: pertu...@free.fr > Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org > > On Sun, Oct 23, 2022 at 06:19:19PM +0300, Eli Zaretskii wrote: > > > Date: Sun, 23 Oct 2022 17:15:45 +0200 > > > From: pertu...@free.fr > > > Cc: gavinsmith0...@gmail.com,

Re: free used incorrectly in api.c

2022-10-23 Thread Eli Zaretskii
> From: Gavin Smith > Date: Sun, 23 Oct 2022 13:02:27 +0100 > Cc: pertu...@free.fr, bug-texinfo@gnu.org > > > reset_parser (); > > > > And reset_parser calls a bunch of functions from indices.c, which use > > malloc/realloc/free without redirecting them to the Perl allocation > > functions.

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Eli Zaretskii
> From: Gavin Smith > Date: Sat, 22 Oct 2022 20:14:59 +0100 > Cc: Patrice Dumas , bug-texinfo@gnu.org > > On Sat, Oct 22, 2022 at 11:57:36AM +0300, Eli Zaretskii wrote: > > > --- ./tp/Texinfo/XS/XSParagraph.c~0 2022-02-12 00:01:48.0 +0200 > > +++ ./tp/Texinfo/XS/XSParagraph.c

Re: Skip filename recoding tests on MS-Windows

2022-10-23 Thread pertusus
On Sun, Oct 23, 2022 at 06:19:19PM +0300, Eli Zaretskii wrote: > > Date: Sun, 23 Oct 2022 17:15:45 +0200 > > From: pertu...@free.fr > > Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org > > > > On Sun, Oct 23, 2022 at 05:30:24PM +0300, Eli Zaretskii wrote: > > > > > > Out of 144 tests in

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Eli Zaretskii
> Date: Sun, 23 Oct 2022 10:39:57 +0300 > From: Eli Zaretskii > Cc: pertu...@free.fr, bug-texinfo@gnu.org > > $ ./run_parser_all.sh -dir contents > sed: can't read input_file_names_recoded_stamp.txt: No such file or > directory > D: contents//diffs/contents_at_begin.diff (printed below) >

Re: Skip filename recoding tests on MS-Windows

2022-10-23 Thread Eli Zaretskii
> Date: Sun, 23 Oct 2022 17:15:45 +0200 > From: pertu...@free.fr > Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org > > On Sun, Oct 23, 2022 at 05:30:24PM +0300, Eli Zaretskii wrote: > > > > Out of 144 tests in test_scripts/, 105 pass, 31 are skipped, and 8 > > fail. The failed ones are all

Re: Directory separator for INFO_JS_DIR

2022-10-23 Thread pertusus
On Sun, Oct 23, 2022 at 05:53:01PM +0100, Gavin Smith wrote: > On Sun, Oct 23, 2022 at 04:47:50PM +0200, pertu...@free.fr wrote: > > > > I tracked it down to tp/ext/epub3.pm and there is actually already a > > FIXME, I knew that something like that was bound to happen: > > > > # FIXME

diff wrapper for install-info tests

2022-10-23 Thread Gavin Smith
On Sun, Oct 23, 2022 at 12:30:23PM +0200, Bruno Haible wrote: > Eli Zaretskii wrote: > > > - nearly all of the 'ii--test' tests fail, > > > > This could be due to Diff. I have long ago replaced the MSYS Diff > > with the following shell script (and gladly forgot about this issue): > > > >

Re: texindex awk syntax error

2022-10-23 Thread Gavin Smith
On Sun, Oct 23, 2022 at 08:36:04PM +0200, Bruno Haible wrote: > Therefore, on this platform, instead of picking the 'awk' that is found > in $PATH, it is a better strategy to look for 'nawk' or 'gawk' in $PATH. Thanks for investigating this. I've made it try nawk as well: diff --git

Re: texinfo-6.8.90 pretest on mingw

2022-10-23 Thread Eli Zaretskii
> From: Bruno Haible > Cc: e...@gnu.org > Date: Sun, 23 Oct 2022 01:43:34 +0200 > > - nearly all of the 'ii--test' tests fail, This could be due to Diff. I have long ago replaced the MSYS Diff with the following shell script (and gladly forgot about this issue): #! /bin/sh # diff ---

Re: texinfo-6.8.90 pretest on mingw

2022-10-23 Thread Bruno Haible
Eli Zaretskii wrote: > > with a line ending of , which is why > > grep 't/infodir/file1.info$' > > fails. > > I guess Grep that I have (from MSYS) is more tolerant to Windows-style > CRLF end-of-line format, because it succeeds in that case. Apparently so, yes. I use the 'grep' from Cygwin,

Re: Skip filename recoding tests on MS-Windows

2022-10-23 Thread pertusus
On Sun, Oct 23, 2022 at 05:54:30PM +0300, Eli Zaretskii wrote: > > Date: Sun, 23 Oct 2022 14:44:33 +0200 > > From: pertu...@free.fr > > Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org > > > > I think that it does not depend on other changes. You'll also need to > > remove

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Gavin Smith
On Sun, Oct 23, 2022 at 03:23:57PM +0300, Eli Zaretskii wrote: > > From: Gavin Smith > > Date: Sun, 23 Oct 2022 13:13:57 +0100 > > Cc: pertu...@free.fr, bug-texinfo@gnu.org > > > > The translation is done by setting the LANGUAGE environment variable > > but this does not work if the locale is C.

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Eli Zaretskii
> From: Gavin Smith > Date: Sun, 23 Oct 2022 13:13:57 +0100 > Cc: pertu...@free.fr, bug-texinfo@gnu.org > > The translation is done by setting the LANGUAGE environment variable > but this does not work if the locale is C. All it needs is LC_MESSAGES > to not be "C" (or "POSIX") for LANGUAGE to

Re: texinfo-6.8.90 pretest on Solaris 11.4

2022-10-23 Thread Bruno Haible
Once the compilation error is fixed, "gmake check" fails: FAIL: tests/ti-helpversion.sh Find attached the log. On this platform, awk is /usr/bin/awk. Not GNU awk. If 'texindex' works only with GNU awk, it ought to be documented in the manual. solaris114-failures.tar.gz Description:

Re: texindex awk syntax error

2022-10-23 Thread Bruno Haible
Gavin Smith wrote: > It is not supposed to only run on GNU awk. In fact, it should prefer > awk to gawk. I prefer not to run texindex with gawk because mawk is > much faster. OK. > Do you have any idea why awk is saying there is a syntax error? > > awk: syntax error near line 1 > awk: bailing

Re: mingw-w64 CR handling

2022-10-23 Thread Bruno Haible
Gavin Smith wrote: > In info.c the file name is printed with a simple printf: > > printf ("%s\n", ref_list[i]->filename); > > We don't deal with line endings or "text mode" at all here - just > printing a string to stdout in the most straightforward way. > > It appears that there is

Re: mingw-w64 CR handling

2022-10-23 Thread Eli Zaretskii
> From: Gavin Smith > Date: Sun, 23 Oct 2022 10:52:19 +0100 > Cc: bug-texinfo@gnu.org, e...@gnu.org > > In info.c the file name is printed with a simple printf: > > printf ("%s\n", ref_list[i]->filename); > > We don't deal with line endings or "text mode" at all here - just >

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Eli Zaretskii
> From: Gavin Smith > Date: Sun, 23 Oct 2022 12:55:34 +0100 > Cc: pertu...@free.fr, bug-texinfo@gnu.org > > On Sun, Oct 23, 2022 at 02:40:10PM +0300, Eli Zaretskii wrote: > > Does the current code avoid invoking 'locale'? > > For MS-Windows, yes. I guess I will see that in the next pretest, as

Re: Skip filename recoding tests on MS-Windows

2022-10-23 Thread Eli Zaretskii
> Date: Sun, 23 Oct 2022 17:06:55 +0200 > From: pertu...@free.fr > Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org > > On Sun, Oct 23, 2022 at 05:30:24PM +0300, Eli Zaretskii wrote: > > > Date: Sun, 23 Oct 2022 14:44:33 +0200 > > > From: pertu...@free.fr > > > Cc: gavinsmith0...@gmail.com,

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Eli Zaretskii
> From: Gavin Smith > Date: Sun, 23 Oct 2022 12:21:05 +0100 > > On Sun, Oct 23, 2022 at 01:08:14PM +0200, pertu...@free.fr wrote: > > I am not sure that this patch is needed, as it seems to me that it > > modifies a code that is no longer run on windows with a patch Gavin > > applied very

Re: Skip filename recoding tests on MS-Windows

2022-10-23 Thread Eli Zaretskii
> Date: Sun, 23 Oct 2022 14:44:33 +0200 > From: pertu...@free.fr > Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org > > I think that it does not depend on other changes. You'll also need to > remove input_file_names_recoded_stamp.txt manually, or it will remain > with FAIL even if it now

Re: Skip filename recoding tests on MS-Windows

2022-10-23 Thread pertusus
On Sun, Oct 23, 2022 at 07:10:57PM +0300, Eli Zaretskii wrote: > > > > Which is problematic, it means that with a correctly setup input file > > with latin1 encoded character in the name, something wrong is going on. > > The character is supposed to be encoded in Latin1, but I don't think > it

Re: Skip filename recoding tests on MS-Windows

2022-10-23 Thread pertusus
On Sun, Oct 23, 2022 at 06:41:34PM +0100, Gavin Smith wrote: > On Sun, Oct 23, 2022 at 08:13:24PM +0300, Eli Zaretskii wrote: > > > I am pretty sure that this file is correctly generated, I guess that > > > מ corresponds to the same octet than î in latin1, which is 0xEE unless I > > > missed

Re: texinfo-6.8.90 pretest on mingw

2022-10-23 Thread Gavin Smith
On Sun, Oct 23, 2022 at 01:43:34AM +0200, Bruno Haible wrote: > On mingw (the 'w64' flavour, that can be installed with Cygwin 2.9.0) > - the compilation succeeds, > - there is 1 test failure for 'info', > - nearly all of the 'ii--test' tests fail, > - no test failures in tp/tests/. I wonder

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Gavin Smith
> Not for Windows, because Windows lacks the nl_langinfo function, for > which this module is a think wrapper on Unix. > > AFAIU, on Windows this module is available only starting from v5.28. Can we use LC_CTYPE, like: diff --git a/tp/texi2any.pl b/tp/texi2any.pl index d6061bd8f0..8864ebeedc

mingw-w64 CR handling

2022-10-23 Thread Gavin Smith
On Sun, Oct 23, 2022 at 01:43:34AM +0200, Bruno Haible wrote: > On mingw (the 'w64' flavour, that can be installed with Cygwin 2.9.0) > - the compilation succeeds, > - there is 1 test failure for 'info', > - nearly all of the 'ii--test' tests fail, > - no test failures in tp/tests/. > > The

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Eli Zaretskii
> Date: Sun, 23 Oct 2022 14:39:30 +0200 > From: pertu...@free.fr > Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org > > On Sun, Oct 23, 2022 at 02:26:22PM +0300, Eli Zaretskii wrote: > > The tests that report diffs are as follows: > > > > In 'layout', I see differences like the below: > > > >

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Eli Zaretskii
> Date: Sat, 22 Oct 2022 13:06:15 +0200 > From: Patrice Dumas > > On Sat, Oct 22, 2022 at 11:54:47AM +0100, Gavin Smith wrote: > > > Can't locate I18N/Langinfo.pm in @INC (you may need to install the > > > I18N::Langinfo module) (@INC contains: d:/usr/Perl/site/lib > > > d:/usr/Perl/lib

Re: Skip filename recoding tests on MS-Windows

2022-10-23 Thread pertusus
On Sun, Oct 23, 2022 at 05:30:24PM +0300, Eli Zaretskii wrote: > > Out of 144 tests in test_scripts/, 105 pass, 31 are skipped, and 8 > fail. The failed ones are all about non-ASCII characters, it seems. Sorry, there are 3 tests to check formatting/manual_include_accented_file_name_latin1

Re: texinfo-6.8.90 pretest on OpenSolaris

2022-10-23 Thread Bruno Haible
On the OpenSolaris derivates Solaris 11 OmniOS Solaris 11 OpenIndiana (both in 64-bit mode and in 32-bit mode), 1 test fails: FAIL: t/dir-file-sloppily.sh Find attached the log file. When I redirect the output of the command $ginfo --output - FiLe-M to a file, I see that is it empty.

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Eli Zaretskii
> Date: Sun, 23 Oct 2022 13:42:22 +0300 > From: Eli Zaretskii > CC: pertu...@free.fr, bug-texinfo@gnu.org > > On a hunch, I did two things: > > . created a file tp/tests/input_file_names_recoded_stamp.txt with > the text FAILED in it; > . made the change below in

Re: Skip filename recoding tests on MS-Windows

2022-10-23 Thread pertusus
On Sun, Oct 23, 2022 at 05:54:30PM +0300, Eli Zaretskii wrote: > > Date: Sun, 23 Oct 2022 14:44:33 +0200 > > From: pertu...@free.fr > > Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org > > > > I think that it does not depend on other changes. You'll also need to > > remove

Re: texinfo-6.8.90 pretest on mingw

2022-10-23 Thread Eli Zaretskii
> Date: Sun, 23 Oct 2022 09:02:29 +0300 > From: Eli Zaretskii > Cc: bug-texinfo@gnu.org, gavinsmith0...@gmail.com > > > - there is 1 test failure for 'info', > > Isn't that a test of interactive Info commands? Apologies: in my "make test" run, all Info tests succeed, including this one (55

Re: texinfo-6.8.90 pretest on mingw

2022-10-23 Thread Eli Zaretskii
> From: Bruno Haible > Cc: e...@gnu.org > Date: Sun, 23 Oct 2022 01:43:34 +0200 > > The output of the command > $ginfo --where file1 > is > ./../../info/t/infodir/file1.info > with a line ending of , which is why > grep 't/infodir/file1.info$' > fails. I guess Grep that I have (from MSYS)

Re: texinfo-6.8.90 pretest

2022-10-23 Thread pertusus
On Sun, Oct 23, 2022 at 04:54:31PM +0300, Eli Zaretskii wrote: > > My guess is that it is a bug, as in HTML it seems to me that there > > should only be forward slashes. > > Yes. > > Any hints where I should look for the source of these backslashes? I don't know. I'll have a look at this bug.

Re: Skip filename recoding tests on MS-Windows

2022-10-23 Thread Eli Zaretskii
> Date: Sun, 23 Oct 2022 14:13:55 +0200 > From: pertu...@free.fr > > I eliminated the reference to "included_latîn1.texi" from the Makefile > in > https://git.savannah.gnu.org/cgit/texinfo.git/commit/?id=d9a947dd76999d0f84499f4cac048363957305bc > However, I do not know if the corresponding tests

Re: free used incorrectly in api.c

2022-10-23 Thread Eli Zaretskii
> From: Gavin Smith > Date: Sun, 23 Oct 2022 13:55:43 +0100 > Cc: pertu...@free.fr, bug-texinfo@gnu.org > > On Sun, Oct 23, 2022 at 03:05:56PM +0300, Eli Zaretskii wrote: > > OK, I can try a patch to that effect if/when you have it. > > > > Thanks. > > It's quite a long patch: Thanks, the

Re: Skip filename recoding tests on MS-Windows

2022-10-23 Thread pertusus
On Sun, Oct 23, 2022 at 10:00:19PM +0300, Eli Zaretskii wrote: > > Date: Sun, 23 Oct 2022 20:22:29 +0200 > > From: pertu...@free.fr > > Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org > > > > On Sun, Oct 23, 2022 at 07:10:57PM +0300, Eli Zaretskii wrote: > > > > > > > > Which is problematic,

Re: Directory separator for INFO_JS_DIR

2022-10-23 Thread pertusus
On Sun, Oct 23, 2022 at 08:11:30PM +0300, Eli Zaretskii wrote: > Yes, forward slashes should work. (They should also work on the > command line, as long as we don't involve cmd.exe, because the > programs we use all support forward slashes.) This issue should be fixed, at least partly, in

Re: prove.sh test fails with MinGW

2022-10-23 Thread Patrice Dumas
On Sun, Oct 23, 2022 at 06:38:15PM +0300, Eli Zaretskii wrote: > The prove.sh test fails here, because the version of 'prove' I have > with MSYS is too old (1.04), and it doesn't support the -w switch. I > do have 'prove' as part of the newer Perl I use with texi2any, but > it's a Windows batch

Re: free used incorrectly in api.c

2022-10-23 Thread pertusus
On Sun, Oct 23, 2022 at 01:55:43PM +0100, Gavin Smith wrote: > It's quite a long patch: I think that it could also be good to separate more perl specific from non-perl specific code, as is done in that patch, in particular if we want to have other language bindings one day. Can wait, but changes

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Gavin Smith
On Sat, Oct 22, 2022 at 09:39:14PM +0300, Eli Zaretskii wrote: > > If this works then we could switch to it and not use I18N::Langinfo at > > all. > > This works here, and produces the codepage number. But (due to the > Windows peculiarities which I won't go into), it isn't the same > codepage

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Gavin Smith
On Sun, Oct 23, 2022 at 04:30:18PM +0300, Eli Zaretskii wrote: > > From: Gavin Smith > > Date: Sun, 23 Oct 2022 14:05:55 +0100 > > Cc: pertu...@free.fr, bug-texinfo@gnu.org > > > > > Don't translations use some general Perl capabilities? And if so, do > > > those capabilities not work on

Re: Directory separator for INFO_JS_DIR

2022-10-23 Thread Eli Zaretskii
> From: Gavin Smith > Date: Sun, 23 Oct 2022 17:53:01 +0100 > > > To me the basic issue is that INFO_JS_DIR is used, in HTML.pm in > > output(), both as an HTML path l 8941 and to copy local files near l > > 10184 of HTML.pm. As a local file path, it would make sense to > > use backward slash,

Re: texinfo-6.8.90 pretest on Solaris 11.4

2022-10-23 Thread Gavin Smith
On Sun, Oct 23, 2022 at 04:50:10PM +0200, Bruno Haible wrote: > This is now fixed in Gnulib. > > Please update to the newest Gnulib. > > Bruno Thanks, done.

Skip filename recoding tests on MS-Windows

2022-10-23 Thread Gavin Smith
On Sun, Oct 23, 2022 at 10:15:30AM +0300, Eli Zaretskii wrote: > So this is a mess on MS-Windows, and I really am at a loss how to > solve it reliably. I don't want to lose the ability of running the > texi2any test suite with the native MS-Windows port, so perhaps some > way of skipping the

Re: texinfo-6.8.90 pretest on mingw

2022-10-23 Thread Gavin Smith
On Sun, Oct 23, 2022 at 12:58:34PM +0300, Eli Zaretskii wrote: > This could be due to Diff. I have long ago replaced the MSYS Diff > with the following shell script (and gladly forgot about this issue): > > #! /bin/sh > # diff --- like diff.exe but ignore trailing CR characters >

Re: diff wrapper for install-info tests

2022-10-23 Thread Bruno Haible
Gavin Smith wrote: > Could you try a change like the one at the end of this mail? > > If that works, then we can make this change throughout the install-info > test suite. With the attached patch, all ii--test tests pass on mingw. > The test for mingw may need tweaking to include/exclude

Re: texinfo-6.8.90 pretest on Solaris 11.4

2022-10-23 Thread Bruno Haible
On Solaris 11.4, the compilation fails: gcc -O2 -DHAVE_CONFIG_H -I. -I../../../gnulib/lib -I../.. -I/export/home/bruno/prefix64/include -Wall -D_REENTRANT -Wno-cast-qual -Wno-conversion -Wno-float-equal -Wno-sign-compare -Wno-undef -Wno-unused-function -Wno-unused-parameter

Re: Skip filename recoding tests on MS-Windows

2022-10-23 Thread Eli Zaretskii
> Date: Sun, 23 Oct 2022 18:52:58 +0200 > From: pertu...@free.fr > Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org > > On Sun, Oct 23, 2022 at 06:18:09PM +0300, Eli Zaretskii wrote: > > > It depends whether a file with latin1 name was copied or not. If the > > > file was copied, it is normal

prove.sh test fails with MinGW

2022-10-23 Thread Eli Zaretskii
The prove.sh test fails here, because the version of 'prove' I have with MSYS is too old (1.04), and it doesn't support the -w switch. I do have 'prove' as part of the newer Perl I use with texi2any, but it's a Windows batch file, so it will be difficult to invoke that from a Bash shell script.

Re: prove.sh test fails with MinGW

2022-10-23 Thread Gavin Smith
On Sun, Oct 23, 2022 at 06:38:15PM +0300, Eli Zaretskii wrote: > The prove.sh test fails here, because the version of 'prove' I have > with MSYS is too old (1.04), and it doesn't support the -w switch. I > do have 'prove' as part of the newer Perl I use with texi2any, but > it's a Windows batch

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Eli Zaretskii
> Date: Sun, 23 Oct 2022 13:42:22 +0300 > From: Eli Zaretskii > CC: pertu...@free.fr, bug-texinfo@gnu.org > > On a hunch, I did two things: > > . created a file tp/tests/input_file_names_recoded_stamp.txt with > the text FAILED in it; > . made the change below in

Re: mingw-w64 CR handling

2022-10-23 Thread Eli Zaretskii
> From: Bruno Haible > Date: Sun, 23 Oct 2022 12:25:59 +0200 > > It is also possible to do like Eli does: Use special mingw versions of > the tools (grep, awk, etc.). That's not what I do, though. I use the MSYS tools. The reason is simple: when the test suite runs Posix shell scripts, it is

Re: texinfo-6.8.90 pretest on mingw

2022-10-23 Thread Bruno Haible
Eli Zaretskii wrote: > Which version of Perl did you use in this build? It's the perl built for and shipped by Cygwin: $ perl -V Summary of my perl5 (revision 5 version 26 subversion 1) configuration: Platform: osname=cygwin osvers=2.9.0(0.31853)

Re: free used incorrectly in api.c

2022-10-23 Thread Gavin Smith
On Sun, Oct 23, 2022 at 03:05:56PM +0300, Eli Zaretskii wrote: > OK, I can try a patch to that effect if/when you have it. > > Thanks. It's quite a long patch: diff --git a/ChangeLog b/ChangeLog index 2db2d8ad94..c72c83ddeb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,26 @@ +2022-10-23

Re: texinfo-6.8.90 pretest on mingw

2022-10-23 Thread Bruno Haible
Eli Zaretskii wrote: > > - nearly all of the 'ii--test' tests fail, > > This could be due to Diff. I have long ago replaced the MSYS Diff > with the following shell script (and gladly forgot about this issue): > > #! /bin/sh > # diff --- like diff.exe but ignore trailing CR characters >

Re: texinfo-6.8.90 pretest on mingw

2022-10-23 Thread Eli Zaretskii
> From: Gavin Smith > Date: Sun, 23 Oct 2022 11:01:42 +0100 > Cc: Bruno Haible , bug-texinfo@gnu.org > > On Sun, Oct 23, 2022 at 09:02:29AM +0300, Eli Zaretskii wrote: > > > - nearly all of the 'ii--test' tests fail, > > > > What version of Gawk do you have? > > I don't think Gawk is

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Eli Zaretskii
> From: Gavin Smith > Date: Sun, 23 Oct 2022 12:45:28 +0100 > Cc: pertu...@free.fr, bug-texinfo@gnu.org > > On Sun, Oct 23, 2022 at 02:36:30PM +0300, Eli Zaretskii wrote: > > Which commit is that? > > 178d1f4d6f4c5f10657e891a1a85, 2022-10-21 22:03:56. That still invokes "locale -a", doesn't

I18N::Langinfo on MS-Windows

2022-10-23 Thread Gavin Smith
On Sun, Oct 23, 2022 at 08:56:13AM +0300, Eli Zaretskii wrote: > I don't know if any native Windows ports of Perl have Langinfo. I > seem to be unable to find specific information about this on the > Internet, but given that it's a thin wrapper around the nl_langinfo > libc function, which

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Eli Zaretskii
> From: Gavin Smith > Date: Sun, 23 Oct 2022 14:43:54 +0100 > Cc: pertu...@free.fr, bug-texinfo@gnu.org > > On Sun, Oct 23, 2022 at 04:30:18PM +0300, Eli Zaretskii wrote: > > > We bundle the libintl-perl library, which isn't part of a core Perl > > > installation as far as I know. > > > > > >

Re: texinfo-6.8.90 pretest on mingw

2022-10-23 Thread Eli Zaretskii
> From: Bruno Haible > Cc: bug-texinfo@gnu.org, gavinsmith0...@gmail.com > Date: Sun, 23 Oct 2022 12:12:03 +0200 > > Eli Zaretskii wrote: > > Which version of Perl did you use in this build? > > It's the perl built for and shipped by Cygwin: This AFAIU means you will be unable to build Texinfo

Re: texinfo-6.8.90 pretest

2022-10-23 Thread pertusus
On Sun, Oct 23, 2022 at 01:42:22PM +0300, Eli Zaretskii wrote: > On a hunch, I did two things: > > . created a file tp/tests/input_file_names_recoded_stamp.txt with > the text FAILED in it; Ok. I'll try to change the generation of input_file_names_recoded_stamp.txt such that there is no

Re: texinfo-6.8.90 pretest

2022-10-23 Thread pertusus
On Sun, Oct 23, 2022 at 02:26:22PM +0300, Eli Zaretskii wrote: > The tests that report diffs are as follows: > > In 'layout', I see differences like the below: > > - > - > - > + > + > + > > They are all due to '/' vs '\' (slash vs backslash) issue. My guess is that it is a bug, as

Re: texinfo-6.8.90 pretest on mingw

2022-10-23 Thread Eli Zaretskii
> From: Bruno Haible > Cc: e...@gnu.org > Date: Sun, 23 Oct 2022 01:43:34 +0200 > > On mingw (the 'w64' flavour, that can be installed with Cygwin 2.9.0) > - the compilation succeeds, Which version of Perl did you use in this build? If that's the MSYS2 Perl, then AFAIU the resulting makeinfo

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Eli Zaretskii
> From: Gavin Smith > Date: Sat, 22 Oct 2022 21:01:01 +0100 > Cc: pertu...@free.fr, bug-texinfo@gnu.org > > If you can confirm that the warnings are gone with the lines > > GL_GNULIB_MDA_FDOPEN=0 > GL_GNULIB_MDA_MKTEMP=0 > GL_GNULIB_MDA_PUTENV=0 > > (added in commit 02022a38e48) then we can

Re: texinfo-6.8.90 pretest on OpenSolaris

2022-10-23 Thread Gavin Smith
On Sun, Oct 23, 2022 at 01:04:47AM +0200, Bruno Haible wrote: > On the OpenSolaris derivates > Solaris 11 OmniOS > Solaris 11 OpenIndiana > (both in 64-bit mode and in 32-bit mode), 1 test fails: > > FAIL: t/dir-file-sloppily.sh > > Find attached the log file. > > When I redirect the

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Eli Zaretskii
> From: Gavin Smith > Date: Sun, 23 Oct 2022 14:05:55 +0100 > Cc: pertu...@free.fr, bug-texinfo@gnu.org > > > Don't translations use some general Perl capabilities? And if so, do > > those capabilities not work on Windows? > > We bundle the libintl-perl library, which isn't part of a core Perl

Re: texinfo-6.8.90 pretest

2022-10-23 Thread pertusus
On Sun, Oct 23, 2022 at 08:56:13AM +0300, Eli Zaretskii wrote: > AFAIU, the Win32::API module is present in all native Perl versions > for Windows (I'm using ActiveState Perl). It is not clear to me which > was the earliest version of Perl which came with it built-in (mine is > 5.20.1, and it

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Eli Zaretskii
> The next problem is all the non-ASCII file names in tp/tests/ and its > subdirectories: they cause failures like this one: > > make[2]: Entering directory `/d/gnu/texinfo-6.8.90/tp/tests' > Making check in . > make[3]: Entering directory `/d/gnu/texinfo-6.8.90/tp/tests' > make

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Gavin Smith
On Sun, Oct 23, 2022 at 02:40:10PM +0300, Eli Zaretskii wrote: > Does the current code avoid invoking 'locale'? For MS-Windows, yes. The problem with the current code might be that texi2any may not translate strings to languages other than English in output documents for MS-Windows.

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Eli Zaretskii
> Date: Sun, 23 Oct 2022 01:42:14 +0200 > From: pertu...@free.fr > > > Could you try the following? > > In case this works I will try this later today and let you know. > could you tell use, Eli, if there is a need to > document something about Win32::API being needed, or is it automatically >

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Gavin Smith
On Sat, Oct 22, 2022 at 10:38:07PM +0300, Eli Zaretskii wrote: > No, those #undef's must be after including perl.h and before XSUB.h. > That's because the Gnulib's stdlib.h is included by Perl's perl.h: I've revised it in commit 5edc09c5bd. > > So I expect we can deal with putenv and mktemp the

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Gavin Smith
On Sat, Oct 22, 2022 at 11:57:36AM +0300, Eli Zaretskii wrote: > I don't understand why this happens now whereas it didn't happen in > Texinfo-6.8; both XSParagraph.xs and Gnulib's stdlib.h seem to be > identical in both versions of Texinfo. I fixed this temporarily by > adding the following in

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Eli Zaretskii
> From: Gavin Smith > Date: Sat, 22 Oct 2022 18:16:35 +0100 > Cc: Patrice Dumas , bug-texinfo@gnu.org > > > Not for Windows, because Windows lacks the nl_langinfo function, for > > which this module is a think wrapper on Unix. > > > > AFAIU, on Windows this module is available only starting

Re: texinfo-6.8.90 pretest

2022-10-23 Thread pertusus
On Sat, Oct 22, 2022 at 09:36:20PM +0100, Gavin Smith wrote: > On Sat, Oct 22, 2022 at 09:39:14PM +0300, Eli Zaretskii wrote: > > > If this works then we could switch to it and not use I18N::Langinfo at > > > all. > > > > This works here, and produces the codepage number. But (due to the > >

Re: texinfo-6.8.90 pretest on macOS

2022-10-23 Thread Bruno Haible
On macOS 10.13, with perl v5.28.3, two tests fail: FAIL: test_scripts/layout_formatting_info.sh FAIL: test_scripts/layout_formatting_plaintext.sh Find attached the logs. It looks like the line breaking is different than expected. In case it matters: The Gnulib replacement function 'rpl_wcwidth'

Re: texinfo-6.8.90 pretest on mingw

2022-10-23 Thread Bruno Haible
On mingw (the 'w64' flavour, that can be installed with Cygwin 2.9.0) - the compilation succeeds, - there is 1 test failure for 'info', - nearly all of the 'ii--test' tests fail, - no test failures in tp/tests/. The failing 'info' test is: FAIL: t/where-dir-file.sh Find attached the log

Re: Skip filename recoding tests on MS-Windows

2022-10-23 Thread pertusus
On Sun, Oct 23, 2022 at 05:38:37PM +0100, Gavin Smith wrote: > On Sun, Oct 23, 2022 at 05:25:26PM +0200, pertu...@free.fr wrote: > > Which is right. > > > > > and the first two fail if it says "OK". > > > > Which is problematic, it means that with a correctly setup input file > > with latin1

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Gavin Smith
> > I believe it is tested by test_scripts/layout_formatting_fr_icons.sh. > > That one passes here. That's good, it should be fine then. > > You can see in the reference file > > > > tp/tests/layout/res_parser/formatting_fr_icons/formatting.html > > > > the use of translated strings, e.g.

Re: texinfo-6.8.90 pretest

2022-10-23 Thread Eli Zaretskii
> Date: Sun, 23 Oct 2022 16:07:00 +0200 > From: pertu...@free.fr > Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org > > > I've run "make check" in many_input_files, and it reported 3 failed > > tests: input_dir_nonascii, output_dir_nonascii, and > > output_dir_file_nonascii. Given the

Re: Skip filename recoding tests on MS-Windows

2022-10-23 Thread Eli Zaretskii
> Date: Sun, 23 Oct 2022 14:44:33 +0200 > From: pertu...@free.fr > Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org > > > Thanks. Do you want me to try patching the current pretest and > > testing the change, or should I wait for the next pretest? If the > > former, is it enough to apply only