Re: not using OUTPUT_PERL_ENCODING to determine if _stream_encode should encode

2024-02-20 Thread Patrice Dumas
On Mon, Feb 19, 2024 at 10:45:22PM +0100, Patrice Dumas wrote: > Another issue, maybe it would be better to reset encoding_disabled to > leave a clean state in conversion_finalization(), do something like > > if (...) { > $self->{'encoding_disabled'}++; > } > > in

Re: not using OUTPUT_PERL_ENCODING to determine if _stream_encode should encode

2024-02-19 Thread Patrice Dumas
On Mon, Feb 19, 2024 at 09:01:07PM +, Gavin Smith wrote: > On Sun, Feb 18, 2024 at 10:57:22PM +0100, Patrice Dumas wrote: > > On Sun, Feb 18, 2024 at 06:09:23PM +, Gavin Smith wrote: > > > If this is ok, then "convert" could set $self->{'encoding_disabled'}. > > > > Should I do that part?

Re: not using OUTPUT_PERL_ENCODING to determine if _stream_encode should encode

2024-02-19 Thread Gavin Smith
On Sun, Feb 18, 2024 at 10:57:22PM +0100, Patrice Dumas wrote: > On Sun, Feb 18, 2024 at 06:09:23PM +, Gavin Smith wrote: > > If this is ok, then "convert" could set $self->{'encoding_disabled'}. > > Should I do that part? I tried making the change myself. Do you think the following is

Re: not using OUTPUT_PERL_ENCODING to determine if _stream_encode should encode

2024-02-18 Thread Patrice Dumas
On Sun, Feb 18, 2024 at 06:09:23PM +, Gavin Smith wrote: > If this is ok, then "convert" could set $self->{'encoding_disabled'}. Should I do that part? -- Pat

Re: not using OUTPUT_PERL_ENCODING to determine if _stream_encode should encode

2024-02-18 Thread Patrice Dumas
On Sun, Feb 18, 2024 at 06:09:23PM +, Gavin Smith wrote: > What you propose sounds reasonable. I understand the idea of 'convert' > always returning an unencoded string regardless of output format, although > the Info converter will have incorrect tag tables so is not a widely > useful

Re: not using OUTPUT_PERL_ENCODING to determine if _stream_encode should encode

2024-02-18 Thread Gavin Smith
On Sun, Feb 18, 2024 at 02:13:13PM +0100, Patrice Dumas wrote: > Hello, > > This is in the new encode once only stream code, so I ask here before > making a change, I could be missing something, Gavin you probably > will have comments/advices. > > I do not think that it is a good thing to set

not using OUTPUT_PERL_ENCODING to determine if _stream_encode should encode

2024-02-18 Thread Patrice Dumas
Hello, This is in the new encode once only stream code, so I ask here before making a change, I could be missing something, Gavin you probably will have comments/advices. I do not think that it is a good thing to set OUTPUT_PERL_ENCODING to an empty string to prevent _stream_encode to encode if