Re: texinfo-6.0.91 pretest

On 2 January 2016 at 21:50, Andreas Schwab wrote: > Gavin Smith writes: > >> I don't see why it's a problem. > > Anything that is installed but unused is bad. What I'll try is deleting the files after they are installed using the

Re: texinfo-6.0.91 pretest

> Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org > From: Ken Brown > Date: Tue, 5 Jan 2016 17:15:35 -0500 > > > I think the Windows ports will have to use PERL_EXT_LDFLAGS when > > configuring Texinfo. > > I tested this on Cygwin by doing > > ./configure

Re: texinfo-6.0.91 pretest

On 1/2/2016 8:53 AM, Eli Zaretskii wrote: Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org From: Ken Brown Date: Sat, 2 Jan 2016 08:31:26 -0500 -XSParagraph_la_LDFLAGS=-no-undefined -avoid-version -module $(PERL_CONF_cccdlflags) +XSParagraph_la_LDFLAGS=-no-undefined

Re: texinfo-6.0.91 pretest

On 2 January 2016 at 21:48, Andreas Schwab wrote: > Gavin Smith writes: > >> I wonder what's gone wrong. > > The (unexecuted) AC_SUBST in gl_CONFIGMAKE_PREP overrides automake's > definition. A bad gnulib bug. OK thanks, I've changed it to use

Re: texinfo-6.0.91 pretest

> Date: Fri, 1 Jan 2016 21:23:28 + > From: Gavin Smith > Cc: Texinfo > > On 1 January 2016 at 21:19, Eli Zaretskii wrote: > >> No Perl header files are included in text.c. > > > > Why can't we include Perl headers there? > > No

Re: texinfo-6.0.91 pretest

> Date: Sat, 02 Jan 2016 11:44:35 +0200 > From: Eli Zaretskii > Cc: bug-texinfo@gnu.org > > "make install" installs the XSParagraph shared libraries into > ${prefix}/libexec/texinfo -- is that the correct place? Will Perl > find these modules when texi2any runs it? > > Also,

Re: texinfo-6.0.91 pretest

> Cc: bug-texinfo@gnu.org > From: Ken Brown > Date: Fri, 1 Jan 2016 17:45:28 -0500 > > There is a similar linking problem on Cygwin, but the following patch fixes > it: > > Index: tp/Texinfo/Convert/XSParagraph/Makefile.am >

Re: texinfo-6.0.91 pretest

On 2 January 2016 at 09:44, Eli Zaretskii wrote: > I applied the latest changes from the repository, and the crashes are > gone! Awesome. > A few observations and issues with the rest of the build: > > "make install" installs the XSParagraph shared libraries into >

Re: texinfo-6.0.91 pretest

On 2 January 2016 at 09:44, Eli Zaretskii wrote: > The failures in htmlxref tests are due to a formatting issue. The > diffs look like this: > > diff --strip-trailing-cr -a -u -r > .//diffs/staging_res/htmlxref_nodes/test_refs.2 > .//out_parser/htmlxref_nodes/test_refs.2 >

Re: texinfo-6.0.91 pretest

> Date: Sat, 2 Jan 2016 10:05:22 + > From: Gavin Smith > Cc: Texinfo > > On 2 January 2016 at 09:44, Eli Zaretskii wrote: > > I applied the latest changes from the repository, and the crashes are > > gone! > > Awesome. I agree.

Re: texinfo-6.0.91 pretest

On 2 January 2016 at 09:58, Eli Zaretskii wrote: > Another minor nit is that the *.la files are also installed, although > I'm quite sure they will never be used. This is a libtool thing, I'm > not sure there's a way to avoid that easily. They are needed because the Perl code to

Re: texinfo-6.0.91 pretest

> Date: Sat, 2 Jan 2016 10:07:11 + > From: Gavin Smith > Cc: Texinfo > > On 2 January 2016 at 09:58, Eli Zaretskii wrote: > > Another minor nit is that the *.la files are also installed, although > > I'm quite sure they will

Re: texinfo-6.0.91 pretest

On 2 January 2016 at 11:26, Eli Zaretskii wrote: > > One way is to run the output through Sed, before comparing, to replace > "^htmlxref" with "./htmlxref". > That's a good suggestion, and in fact looking at the code this is done already for other tests. Below is what I came up

Re: texinfo-6.0.91 pretest

> Date: Sat, 2 Jan 2016 10:45:39 + > From: Gavin Smith > Cc: Texinfo > > > diff --strip-trailing-cr -a -u -r > > .//diffs/staging_res/htmlxref_nodes/test_refs.2 > > .//out_parser/htmlxref_nodes/test_refs.2 > > ---

Re: texinfo-6.0.91 pretest

> Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org > From: Ken Brown > Date: Sat, 2 Jan 2016 08:31:26 -0500 > > >> -XSParagraph_la_LDFLAGS=-no-undefined -avoid-version -module > >> $(PERL_CONF_cccdlflags) > >> +XSParagraph_la_LDFLAGS=-no-undefined -avoid-version -module >

Re: texinfo-6.0.91 pretest

> Date: Sat, 2 Jan 2016 17:57:23 + > From: Gavin Smith > Cc: Texinfo > > On 2 January 2016 at 09:44, Eli Zaretskii wrote: > > Also, "make install" seems to install the TestXS shared library as > > well -- is that intended? > >

Re: texinfo-6.0.91 pretest

On 1/2/2016 8:53 AM, Eli Zaretskii wrote: Cc: gavinsmith0...@gmail.com, bug-texinfo@gnu.org From: Ken Brown Date: Sat, 2 Jan 2016 08:31:26 -0500 -XSParagraph_la_LDFLAGS=-no-undefined -avoid-version -module $(PERL_CONF_cccdlflags) +XSParagraph_la_LDFLAGS=-no-undefined

Re: texinfo-6.0.91 pretest

On 2 January 2016 at 09:44, Eli Zaretskii wrote: > Also, "make install" seems to install the TestXS shared library as > well -- is that intended? I've remembered that if you don't specify an installation directory for a Libtool library, some of the Makefile rules aren't generated

Re: texinfo-6.0.91 pretest

tp/Makefile.am uses @pkglibexecdir@, but pkglibexecdir is never AC_SUBSTed (it is only set if either mbrtowc or wcwidth are unavailable or must be replaced). Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for

Re: texinfo-6.0.91 pretest

Gavin Smith writes: > I don't see why it's a problem. Anything that is installed but unused is bad. > Installing it in some other directory wouldn't help either. No, you never run make install in that directory. Andreas. -- Andreas Schwab, sch...@linux-m68k.org

Re: texinfo-6.0.91 pretest

On 2 January 2016 at 20:14, Andreas Schwab wrote: > tp/Makefile.am uses @pkglibexecdir@, but pkglibexecdir is never > AC_SUBSTed (it is only set if either mbrtowc or wcwidth are unavailable > or must be replaced). I checked tp/Makefile and there's the following:

Re: texinfo-6.0.91 pretest

On 2 January 2016 at 20:58, Andreas Schwab wrote: > Gavin Smith writes: > >> I've remembered that if you don't specify an installation directory >> for a Libtool library, some of the Makefile rules aren't generated >> properly. I can't remember

Re: texinfo-6.0.91 pretest

Gavin Smith writes: > I wonder what's gone wrong. The (unexecuted) AC_SUBST in gl_CONFIGMAKE_PREP overrides automake's definition. A bad gnulib bug. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B

Re: texinfo-6.0.91 pretest

Gavin Smith writes: > I've remembered that if you don't specify an installation directory > for a Libtool library, some of the Makefile rules aren't generated > properly. I can't remember the details but I thought it was a bug in > Libtool at the time. A uninstalled

Re: texinfo-6.0.91 pretest

> Date: Fri, 1 Jan 2016 21:10:05 + > From: Gavin Smith > Cc: Texinfo > > On 1 January 2016 at 20:30, Eli Zaretskii wrote: > > If Perl uses its own malloc/free, then we cannot pass to Perl memory > > allocated in XSParagraph that

Re: texinfo-6.0.91 pretest

On 1 January 2016 at 19:15, Eli Zaretskii wrote: > Call stack: > 66D287C6 perl520.dll:66D287C6 Perl_drand48_r > 68741736 XSParagraph.dll:68741736 > XS_Texinfo__Convert__XSParagraph__XSParagraph_new > > There's also an error message printed on stderr: > > Free to wrong

Re: texinfo-6.0.91 pretest

> Date: Fri, 1 Jan 2016 19:50:18 + > From: Gavin Smith > Cc: Texinfo > > > Free to wrong pool 3f5d18 not 60e011e at > > ../tp/Texinfo/Convert/Plaintext.pm line 663. > > > > This seems to be related to some memory problem. Any suggestions

Re: texinfo-6.0.91 pretest

On 1/1/2016 6:08 AM, Eli Zaretskii wrote: > The next problem was with linking TestXS as a shared library. Because > no undefined references are allowed when linking a shared library on > MS-Windows, the linker needs to see an import library which tells it > where to find the Perl functions at run

Re: texinfo-6.0.91 pretest

On 1 January 2016 at 20:30, Eli Zaretskii wrote: > If Perl uses its own malloc/free, then we cannot pass to Perl memory > allocated in XSParagraph that Perl could free, and we cannot free any > memory Perl passes to us. Is such a scenario plausible? Are we sure > that we only ever

Re: texinfo-6.0.91 pretest

On 1 January 2016 at 21:19, Eli Zaretskii wrote: >> No Perl header files are included in text.c. > > Why can't we include Perl headers there? No reason. If the latest change I committed doesn't work, it's worth trying. > No, it's coming from

Re: texinfo-6.0.91 pretest

> Date: Tue, 29 Dec 2015 18:16:17 + > From: Gavin Smith > > The next pretest for the next Texinfo release has been uploaded to > > ftp://alpha.gnu.org/gnu/texinfo/texinfo-6.0.91.tar.xz > http://alpha.gnu.org/gnu/texinfo/texinfo-6.0.91.tar.xz > > Please send any

Re: texinfo-6.0.91 pretest

> Date: Fri, 1 Jan 2016 12:31:15 + > From: Gavin Smith > Cc: Texinfo > > > When linking a shared library on MS-Windows, one needs to pass the > > '-no-undefined' switch to libtool. I hacked > > tp/Texinfo/Convert/XSParagraph/Makefile.in to add

Re: texinfo-6.0.91 pretest

On 1 January 2016 at 14:36, Eli Zaretskii wrote: > Can you tell a few words about the design of the XSParagraph code and > how it's supposed to work? (If there's an explanation available > somewhere, please just point to it.) I'd like to have a high-level > view of this stuff when

Re: texinfo-6.0.91 pretest

> Date: Fri, 1 Jan 2016 15:29:12 + > From: Gavin Smith > Cc: Texinfo > > BTW this strikes me as strange: > > Reading from location 01a4 > > The would make sense if memory protection was done in blocks of > 1 (hex), and here we've

Re: texinfo-6.0.91 pretest

> Date: Fri, 1 Jan 2016 12:42:54 + > From: Gavin Smith > Cc: Texinfo > > On 1 January 2016 at 11:08, Eli Zaretskii wrote: > > Or maybe you have other ideas for possible reasons. (I don't have a > > debuggable version of Perl, so

Re: texinfo-6.0.91 pretest

On 1 January 2016 at 14:53, Eli Zaretskii wrote: > Any ideas? There are several calls to mbrtowc in xspara__add_next. > > Btw, why is mbrtowc called with its 3rd argument 10? There are no > such long multibyte sequences, AFAIK, and the value should IMO never > be greater than the

Re: texinfo-6.0.91 pretest

> Date: Fri, 1 Jan 2016 18:18:34 + > From: Gavin Smith > Cc: Texinfo > > I had an idea for how that value could be obtained. The pointer is > advanced according to the return value of mbrtowc, and mbrtowc returns > -1 for an error. But the

Re: texinfo-6.0.91 pretest

> Date: Fri, 01 Jan 2016 20:35:24 +0200 > From: Eli Zaretskii > Cc: bug-texinfo@gnu.org > > I'm quite sure this crash is related to the version mbrtowc we have in > xspara.c, I just need to devise a way to catch it. Unfortunately, > using fprintf and sprintf cause compilation

Re: texinfo-6.0.91 pretest

On 1 January 2016 at 11:08, Eli Zaretskii wrote: > The next problem was with linking TestXS as a shared library. Because > no undefined references are allowed when linking a shared library on > MS-Windows, the linker needs to see an import library which tells it > where to find the

Re: texinfo-6.0.91 pretest

On 1 January 2016 at 16:11, Eli Zaretskii wrote: >> BTW this strikes me as strange: >> >> Reading from location 01a4 >> >> The would make sense if memory protection was done in blocks of >> 1 (hex), and here we've strayed into a protected part of memory. >> But I expect

Re: texinfo-6.0.91 pretest

> Date: Fri, 1 Jan 2016 16:20:27 + > From: Gavin Smith > Cc: Texinfo > > On 1 January 2016 at 11:08, Eli Zaretskii wrote: > > The next problem was with linking TestXS as a shared library. Because > > no undefined references are

Re: texinfo-6.0.91 pretest

> Date: Fri, 01 Jan 2016 18:11:30 +0200 > From: Eli Zaretskii > Cc: bug-texinfo@gnu.org > > Btw, in case it wasn't clear: the mbrtowc that's used here is the one > from Gnulib, not from the MS-Windows runtime. Sorry, my mistake: we have a private implementation in xspara.c. Maybe

Re: texinfo-6.0.91 pretest

On 30 December 2015 at 07:00, Norbert Preining wrote: > Thanks, the old tests now all suceed here, but a new one fails: > FAIL: test_scripts/coverage_formatting_utf8_enable_encoding.sh Thanks, you must have run the long checks. I know why this is failing: it's due to a

texinfo-6.0.91 pretest

The next pretest for the next Texinfo release has been uploaded to ftp://alpha.gnu.org/gnu/texinfo/texinfo-6.0.91.tar.xz http://alpha.gnu.org/gnu/texinfo/texinfo-6.0.91.tar.xz Please send any comments to bug-texinfo@gnu.org. Changes since last time include a fix for a bad Info display bug which

Re: texinfo-6.0.91 pretest

Dear Gavin, On Tue, 29 Dec 2015, Gavin Smith wrote: > http://alpha.gnu.org/gnu/texinfo/texinfo-6.0.91.tar.xz Thanks, the old tests now all suceed here, but a new one fails: FAIL: test_scripts/coverage_formatting_utf8_enable_encoding.sh