Re: PACKAGE_VERSION should not be renamed

2023-11-12 Thread Patrice Dumas
On Sun, Nov 12, 2023 at 11:05:18AM +, Gavin Smith wrote: > > However, I doubt that it is justified to rename it. We know it is an > option, so what is the point of putting _OPTION on the end to get > PACKAGE_VERSION_OPTION? Thinking more about it, I think that there is a point in having a

Re: PACKAGE_VERSION should not be renamed

2023-11-12 Thread Patrice Dumas
On Sun, Nov 12, 2023 at 11:05:18AM +, Gavin Smith wrote: > However, I doubt that it is justified to rename it. We know it is an > option, so what is the point of putting _OPTION on the end to get > PACKAGE_VERSION_OPTION? I chose that way because I imagined that using PACKAGE_VERSION only

Re: set_labels_identifiers_target -fsanitize=undefined error

2023-11-12 Thread John Paul Adrian Glaubitz
Hi! On Sat, 2023-11-04 at 16:38 +, Gavin Smith wrote: > On Sat, Nov 04, 2023 at 01:10:47PM +, Sam James wrote: > > > > John Paul Adrian Glaubitz writes: > > > > > Hi Gavin! > > > > > > On Sat, 2023-11-04 at 11:00 +, Gavin Smith wrote: > > > > The line in question is: > > > > > >

Re: set_labels_identifiers_target -fsanitize=undefined error

2023-11-12 Thread John Paul Adrian Glaubitz
Hi! On Sat, 2023-11-04 at 12:03 +0100, John Paul Adrian Glaubitz wrote: > Hi Gavin! > > On Sat, 2023-11-04 at 11:00 +, Gavin Smith wrote: > > The line in question is: > > > > memcpy (targets, list_of_labels, labels_number * sizeof(LABEL)); > > > > - again, the second argument of memcpy.

Re: c32width gives incorrect return values in C locale

2023-11-12 Thread Gavin Smith
On Sat, Nov 11, 2023 at 11:54:52PM +0100, Bruno Haible wrote: > [CCing bug-libunistring] > Gavin Smith wrote: > > I did not understand why uc_width was said to be "locale dependent": > > > > "These functions are locale dependent." > > > > - from > >

PACKAGE_VERSION should not be renamed

2023-11-12 Thread Gavin Smith
On Sun, Nov 05, 2023 at 12:13:00PM +0100, Arsen Arsenović wrote: > Oh, interesting. On my system, I'm using texinfo built from master, and > it completely lacks PACKAGE_VERSION! (if I rebuild from releases/7.1, > it's present). It looks like it got removed in >