Re: [Bug-wget] Segmentation fault with current development version of wget

2013-06-16 Thread Giuseppe Scrivano
thanks for your contribution, some comments inline: Darshit Shah dar...@gmail.com writes: - if (statcode == HTTP_STATUS_TEMPORARY_REDIRECT) -return NEWLOCATION_KEEP_POST; + switch (statcode) + { +case HTTP_STATUS_TEMPORARY_REDIRECT: +

Re: [Bug-wget] [PATCH] MinGW compatibility fixes

2013-06-16 Thread Giuseppe Scrivano
Giuseppe Scrivano gscriv...@gnu.org writes: In my understanding, all new general patches should go into 'master', those regarding metalink/multithreading should go into (experimental) 'parallel- wget' for later merging with 'master'. obviously it has to be into master too, thanks to have

Re: [Bug-wget] [PATCH] MinGW compatibility fixes

2013-06-16 Thread Tim Rühsen
Am Sonntag, 16. Juni 2013 schrieb Giuseppe Scrivano: Giuseppe Scrivano gscriv...@gnu.org writes: In my understanding, all new general patches should go into 'master', those regarding metalink/multithreading should go into (experimental) 'parallel- wget' for later merging with 'master'.

Re: [Bug-wget] Segmentation fault with current development version of wget

2013-06-16 Thread Giuseppe Scrivano
Thanks, the code seems correct but since you are going to write a lot of code during your Summer of Code project, I will be very pedantic. This time I have just amended the changes before push your patch. Darshit Shah dar...@gmail.com writes: Please be aware that Wget needs to know the size