Re: [Bug-wget] Bug Track

2014-10-19 Thread Tim Rühsen
Am Samstag, 18. Oktober 2014, 22:40:14 schrieb Tushar: Hi, I am a student who would like to contribute to GNU Project. I'm very passionate about GNU organization and would like to dedicate some time everyday for GNU. It was mentioned that I have to send an email to this address before

[Bug-wget] Send Content-Length with POST 0 length body

2014-10-19 Thread Matthew Atkinson
Hi I was looking through the list archives to find something that useful I could contribute to wget and get familiar with the code, I have attached a patch for the following. Darshit Shah darnir at gmail.com wrote on 2014-09-05 07:31:34 GMT The Content-Length Header is expected by the server

Re: [Bug-wget] [PATCH] V2 removed 'auto' SSLv3 also from OpenSSL code

2014-10-19 Thread Giuseppe Scrivano
Tim Rühsen tim.rueh...@gmx.de writes: patch V2 - removed SSLv3 from --secure-protocol=auto|pfs (GnuTLS code) - removed SSLv3 from --secure-protocol=auto (OpenSSL code) - amended the docs I am not an OpenSSL expert... please feel free to suggest improvements. same here,

Re: [Bug-wget] [PATCH] Small fix for limited number of strings (and potential garbage value) in arguments to concat_strings

2014-10-19 Thread Giuseppe Scrivano
Pär Karlsson feino...@gmail.com writes: Hi, I fould a potential gotcha when playing with clang's code analysis tool. The concat_strings function silently stopped counting string lengths when given more than 5 arguments. clang warned about potential garbage values in the saved_lengths array,

Re: [Bug-wget] Send Content-Length with POST 0 length body

2014-10-19 Thread Tim Rühsen
Am Sonntag, 19. Oktober 2014, 11:27:51 schrieb Matthew Atkinson: Hi I was looking through the list archives to find something that useful I could contribute to wget and get familiar with the code, I have attached a patch for the following. Darshit Shah darnir at gmail.com wrote on

Re: [Bug-wget] Transparent proxy URL ariation on -E -k options ?

2014-10-19 Thread Ángel González
Gabriel Somlo wrote: If I try to add --convert-links into the mix, the referencing link does get rewritten, but ends up looking like ../site.com/article.cgi?25.html which is designed for offline viewing via file://, and is unsuitable for actually hosting both the referencing and referenced

Re: [Bug-wget] please remove SSLv3 from being used until explicitly specified

2014-10-19 Thread Ángel González
Tim Rühsen wrote: Hi Ángel, thanks for your testing. I would like to reproduce it - can you tell me what you did exactly ? I used a simple server that printed the TLS Client Hello and closed the connection. Browsers automatically retried with lower SSL versions. wget aborted with an

Re: [Bug-wget] wget

2014-10-19 Thread Ángel González
Micah Cowan wrote: Hi! It should be noted that standard error is rather misleadingly named. By long-standing convention, it is generally where all logging and informational messages are meant to go. Standard output is (supposed to be) reserved for actual program output, suitable for potential

Re: [Bug-wget] [PATCH] V2 removed 'auto' SSLv3 also from OpenSSL code

2014-10-19 Thread Tim Rühsen
Am Sonntag, 19. Oktober 2014, 16:07:35 schrieb Giuseppe Scrivano: Tim Rühsen tim.rueh...@gmx.de writes: patch V2 - removed SSLv3 from --secure-protocol=auto|pfs (GnuTLS code) - removed SSLv3 from --secure-protocol=auto (OpenSSL code) - amended the docs I am not an

Re: [Bug-wget] please remove SSLv3 from being used until explicitly specified

2014-10-19 Thread Tim Rühsen
Am Sonntag, 19. Oktober 2014, 21:11:01 schrieb Ángel González: Tim Rühsen wrote: Hi Ángel, thanks for your testing. I would like to reproduce it - can you tell me what you did exactly ? I used a simple server that printed the TLS Client Hello and closed the connection. Browsers

Re: [Bug-wget] [PATCH] Add valgrind testing support via ./configure

2014-10-19 Thread Darshit Shah
On 10/09, Tim Rühsen wrote: Hence, hard coding the command actually reduces the amount of work a user needs to do in order to run the tests under valgrind. My suggestion is that we allow the configure option, but hard code the valgrind command into the test suites themselves, and not leave

[Bug-wget] [Bug-Wget] Summary of Pending Patches

2014-10-19 Thread Darshit Shah
I was going through my local repository and noticed that the following patches are currently pending. I wanted a final round of reviews on them so that we may merge them into mainline. I've tried to explain the context behind each patch below and have also resent the version of each patch I

Re: [Bug-wget] Send Content-Length with POST 0 length body

2014-10-19 Thread Matthew Atkinson
On 19/10/14 19:34, Tim Rühsen wrote: There two little things - well, just kinda organizational work: 1. Please also extend src/ChangeLog and include it in your patch 2. The maintainers will ask you for a 'git format-patch' output If you never worked with that: - git commit your