Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Tim, Am 17.11.2015 um 10:36 schrieb Tim Ruehsen : > On Monday 16 November 2015 22:34:53 Dagobert Michelsen wrote: >> Same here on Solaris 10 with Oracle Studio 12: >> >>> /opt/csw/bin/gcc -DHAVE_CONFIG_H -DSYSTEM_WGETRC=\"/usr/local/etc/wgetrc\" >>>

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Tim, Am 17.11.2015 um 13:14 schrieb Tim Ruehsen : > I guess, Darshit's patch also fixes this issue for Solaris. It does, excellent! https://buildfarm.opencsw.org/buildbot/builders/wget-solaris10-i386/builds/92/steps/shell_2/logs/stdio > I was more referring to >>

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Tim Ruehsen wrote: > BTW, I am pretty astonished that there are no Windows developers ever trying > to compile Wget before any release. How can we any longer support an OS > without any help from OS users ? I build Wget on Windows all the time w/o any problem with flock(). (LOCK_EX is defined

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Dagobert, On Tuesday 17 November 2015 14:12:33 Dagobert Michelsen wrote: > > I was more referring to > > > >> issues: http://lists.gnu.org/archive/html/bug-wget/2015-07/msg00068.html > > > > It seems that metalink.c has to include instead . > > Maybe could could give it try or otherwise let

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Tim, Am 17.11.2015 um 14:52 schrieb Tim Ruehsen : > I just pushed the change. Excellent, the build now runs cleanly. >> Now only one test is failing: >>> FAIL: unit-tests >> >> How does think unit-test-thing work? I can’t find a log or some debug >> output. > > For

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Dagobert, Thanks for running the tests and sharing that log. The unit-tests check specific functions for correctness. The test failing is the one that tests the hsts_store_entry() method in hsts.c. On a preliminary read, it seems like its trying to test something else, but we instead

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Dagobert, On Tuesday 17 November 2015 15:09:05 Dagobert Michelsen wrote: > >> Now only one test is failing: > >>> FAIL: unit-tests > >> > >> How does think unit-test-thing work? I can’t find a log or some debug > >> output. > > > > For every test you will have .log file in tests/ resp.

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Dagobert, On Tuesday 17 November 2015 12:16:15 Dagobert Michelsen wrote: > Hi Tim, > > Am 17.11.2015 um 10:36 schrieb Tim Ruehsen : > > On Monday 16 November 2015 22:34:53 Dagobert Michelsen wrote: > >> Same here on Solaris 10 with Oracle Studio 12: > >>> /opt/csw/bin/gcc

Re: [Bug-wget] Travis-CI updates and minor bug fixes

It's been a while since I shared these patches. The fixes to make distcheck went in before the last release, however, we still don't have Travis integration. The API Tim linked to is valid only for private builds which is a paid feature of Travis. Since the Turkish tests were failing due to a

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Dagobert, Am Dienstag, 17. November 2015, 15:09:05 schrieb Dagobert Michelsen: > > RUNNING TEST test_hsts_url_rewrite_superdomain... > > A new entry should've been created > > Tests run: 15 > > FAIL unit-tests (exit status: 1) > > So which test is failing? test_hsts_url_rewrite_superdomain ?

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Tim, Am 17.11.2015 um 21:17 schrieb Tim Rühsen : > Am Dienstag, 17. November 2015, 15:09:05 schrieb Dagobert Michelsen: >>> RUNNING TEST test_hsts_url_rewrite_superdomain... >>> A new entry should've been created >>> Tests run: 15 >>> FAIL unit-tests (exit status: 1) >> >>

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

On Tue, 17 Nov 2015, Tim Ruehsen wrote: BTW, I am pretty astonished that there are no Windows developers ever trying to compile Wget before any release. How can we any longer support an OS without any help from OS users ? Cross-compilation and testing with Wine is IMO not an option... I had

Re: [Bug-wget] wget-1.17: undefined references in ftp.c

This issue is affecting a lot mmore people. I'm going to push this patch in a couple of hours and add another test for the --disable-ipv6 configure option to check-hard. It seems to be a popularly used configure option that we don't check for. On 11/17, Darshit Shah wrote: Hi Lars, Thanks

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Darshit Shah writes: > I think it's because flock isn't implemented in Windows. The ideal > solution would be to use some WIN32 API to get it done. However, I saw > that gnulib actually provides an implementation of flock that can be > used on Windows. > Hence, maybe just using

[Bug-wget] compile error in wget 1.17

In src/ftp-basic.c, the #ifdefs for ENABLE_IPV6 and HAVE_SSL are wrapped in error. With HAVE_SSL but without ENABLE_IPV6, ftp_auth/ftp_pbsz/ftp_prot aren't included, so it won't link: ftp.o: In function `init_control_ssl_connection': ftp.c:(.text+0x3a5): undefined reference to `ftp_auth' ftp.o:

[Bug-wget] [PATCH] wget 1.17 doesn't build with --disable-ipv6

hi wget 1.17 doesn't build when --disable-ipv6 specified build fails on linking with following errors undefined reference to `ftp_auth' undefined reference to `ftp_pbsz' undefined reference to `ftp_prot' this little patch fix the issue --- wget-1.17/src/ftp-basic.c.orig 2015-11-16

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Dagobert, On Monday 16 November 2015 22:34:53 Dagobert Michelsen wrote: > Hi, > > Am 16.11.2015 um 14:53 schrieb Jernej Simončič : > > Looks like hsts.c tries to use flock with a parameter that doesn't > > work on Windows: > > > > x86_64-w64-mingw32-gcc

Re: [Bug-wget] compile error in wget 1.17

I've already shared a patch on another thread to fix this issue. You can try it out. I will be pushing the patch into master today if there are no complains. On 11/16, Todd Eigenschink wrote: In src/ftp-basic.c, the #ifdefs for ENABLE_IPV6 and HAVE_SSL are wrapped in error. With HAVE_SSL but

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Thanks for pointing out, Daniel ! Looks like a good option. Tim On Tuesday 17 November 2015 10:32:06 Daniel Stenberg wrote: > On Tue, 17 Nov 2015, Tim Ruehsen wrote: > > BTW, I am pretty astonished that there are no Windows developers ever > > trying to compile Wget before any release. How can