[Bug-wget] [bug #48193] Build fails unless -liconv set explicitly in LDFLAGS

2016-06-19 Thread Bruno Haible
Follow-up Comment #9, bug #48193 (project wget): Rather than LDADD = $(LIBOBJS) $(LTLIBICONV) ../lib/libgnu.a it would be better to write LDADD = $(LIBOBJS) ../lib/libgnu.a $(LTLIBICONV) The reason is that $(LTLIBICONV) refers to - more or less - a system library, and it can be a shared

Re: [Bug-wget] [PATCH] Trivial changes in HSTS

2016-06-19 Thread Tim Rühsen
On Friday 17 June 2016 22:50:27 Gisle Vanem wrote: > > +static bool > > +hsts_file_access_valid (const char *filename) > > +{ > > + struct_stat st; > > + > > + if (stat (filename, ) == -1) > > +return false; > > + > > + return !(st.st_mode & S_IWOTH) && S_ISREG (st.st_mode); > > Due to the