Re: [Bug-wget] Fwd: PATCH: bugs 20369 and 20389

2017-03-04 Thread Darshit Shah
Hi Vijo, Could you please send the patches as an attachment generated by `git format-patch`? Gmail more often than not tends to break line endings making it almost impossible to test the patches. I will currently let Eli look into the Windows and VMS compatibility for safe_{f,}open()

Re: [Bug-wget] Fwd: PATCH: bugs 20369 and 20389

2017-03-04 Thread Vijo Cherian
Thanks again Eli. Here is my revised patch, that addresses all except one of your concerns. One concern I didn't address is that of making file_exists_p() call inside fopen_stat(). That would require a lot more of code surgery than I should as I get familiar with wget code. But I can take on a

Re: [Bug-wget] Fwd: PATCH: bugs 20369 and 20389

2017-03-04 Thread Eli Zaretskii
> From: Vijo Cherian > Date: Fri, 3 Mar 2017 11:33:05 -0800 > Cc: bug-wget@gnu.org > > bool > file_exists_p (const char *filename, file_stats_t *fstats) > { > struct stat buf; > > #if defined(WINDOWS) || defined(__VMS) > return stat (filename, ) >= 0; > #else This

Re: [Bug-wget] recursive_retrieve()

2017-03-04 Thread Tim Rühsen
On Freitag, 3. März 2017 13:18:38 CET João Bernardo Sousa wrote: > Hello. > > I'm getting this error when debugging "Removing file due to recursive > rejection criteria in recursive_retrieve()". > > I'll be glad if you could help me: > >

Re: [Bug-wget] Patch: Always surround the "WARC-Target-URI" value with angle brackets

2017-03-04 Thread Tim Rühsen
Thanks, Bejamin, your patch is applied (trivial, no FSF copyright assignment required). Regards, Tim On Freitag, 3. März 2017 09:00:57 CET Benjamin Esham wrote: > Hello, > > When producing WARC files, Wget records the requested URI in the > "WARC-Target-URI" field. I noticed that Wget encloses

Re: [Bug-wget] How to download Wget software in windows?

2017-03-04 Thread Ander Juaristi
https://eternallybored.org/misc/wget/ On 03/03/17 00:57, Qu Bo wrote: > Would be helpful to give me a guidence. Many thanks! > Bo > > 发自 Windows 邮件 >