Am Montag, 21. Juli 2014, 15:35:10 schrieb Giuseppe Scrivano:
Darshit Shah dar...@gmail.com writes:
From a44841cbe2abe712de84d7413c31fc14b44225a7 Mon Sep 17 00:00:00 2001
From: Darshit Shah dar...@gmail.com
Date: Mon, 21 Jul 2014 13:25:54 +0530
Subject: [PATCH] Fix potential memory leak
Darshit Shah dar...@gmail.com writes:
From a44841cbe2abe712de84d7413c31fc14b44225a7 Mon Sep 17 00:00:00 2001
From: Darshit Shah dar...@gmail.com
Date: Mon, 21 Jul 2014 13:25:54 +0530
Subject: [PATCH] Fix potential memory leak and libpsl configure
---
ChangeLog | 4
configure.ac
On Mon, Jul 7, 2014 at 8:14 PM, Tim Ruehsen tim.rueh...@gmx.de wrote:
One more comment / idea.
The 'cookie_domain' comes from a HTTP Set-Cookie repsonse header and thus is
(must be) toASCII() encoded (=puncode). Of course this has to be checked when
normalizing the incoming cookie data. A
Am Montag, 21. Juli 2014, 00:58:49 schrieb Darshit Shah:
On Mon, Jul 7, 2014 at 8:14 PM, Tim Ruehsen tim.rueh...@gmx.de wrote:
One more comment / idea.
The 'cookie_domain' comes from a HTTP Set-Cookie repsonse header and thus
is (must be) toASCII() encoded (=puncode). Of course this has
Does anyone ack this patch? It's a memory leak that I would like to fix.
I'll work on Tim's suggestions next.
On Sat, Jul 5, 2014 at 4:38 PM, Darshit Shah dar...@gmail.com wrote:
I just pushed a slightly amended patch. However, here is what I propose:
diff --git a/src/cookies.c
ACK from here.
And please also amend
return true ? (is_acceptable == 1) : false;
to
return is_acceptable == 1;
Regards, Tim
Am Samstag, 19. Juli 2014, 22:05:26 schrieb Darshit Shah:
Does anyone ack this patch? It's a memory leak that I would like to fix.
I'll work on Tim's
On Saturday 05 July 2014 16:38:54 Darshit Shah wrote:
I just pushed a slightly amended patch. However, here is what I propose:
Where did you push it to ?
Git pull on master still has the previous version...
Tim
The version on origin/master is the latest version. The slight
amendment I made was using this snippet:
@@ -519,7 +531,21 @@ check_domain_match (const char *cookie_domain,
const char *host)
goto no_psl;
}
- is_acceptable = psl_is_cookie_domain_acceptable (psl, host, cookie_domain);
Hi,
I've attached 3 patches to this mail. The first one eliminates some of
the error codes in Wget as a first step to cleaning up the error
reporting method.
The second is siimply fixing indentation issues.
The third updates our usage of libpsl according to the latest release
version and
Hi Darshit,
few comments below:
Darshit Shah dar...@gmail.com writes:
Hi,
I've attached 3 patches to this mail. The first one eliminates some of
the error codes in Wget as a first step to cleaning up the error
reporting method.
The second is siimply fixing indentation issues.
The third
Darshit Shah dar...@gmail.com writes:
static bool
check_domain_match (const char *cookie_domain, const char *host)
@@ -509,6 +519,7 @@ check_domain_match (const char *cookie_domain, const
char *host)
#ifdef HAVE_LIBPSL
DEBUGP ((cdm: 1));
+ char * cookie_domain_lower, * host_lower;
I just pushed a slightly amended patch. However, here is what I propose:
diff --git a/src/cookies.c b/src/cookies.c
index 76301ac..3139671 100644
--- a/src/cookies.c
+++ b/src/cookies.c
@@ -549,6 +549,9 @@ check_domain_match (const char *cookie_domain,
const char *host)
return true ?
12 matches
Mail list logo
