[Bug-wget] [PATCH] remote_to_utf8: cut off part of condition always false

2014-11-21 Thread Daniel Stenberg
Hey Attached is a tiny patch that fixes a compiler warning as the right part of the condition always evaluates to true when a signed char is checked if it is larger than 127. -- / daniel.haxx.seFrom 15ef60d11b5444e005414ef513871de564eea18f Mon Sep 17 00:00:00 2001 From: Daniel Stenberg

Re: [Bug-wget] [PATCH] remote_to_utf8: cut off part of condition always false

2014-11-21 Thread Daniel Stenberg
On Fri, 21 Nov 2014, Daniel Stenberg wrote: Attached is a tiny patch that fixes a compiler warning as the right part of the condition always evaluates to true when a signed char is checked if it is larger than 127. Silly me, the patch title is correct. It always evaluates to *false*... --

Re: [Bug-wget] [PATCH] remote_to_utf8: cut off part of condition always false

2014-11-21 Thread Darshit Shah
On 11/21, Daniel Stenberg wrote: Hey Attached is a tiny patch that fixes a compiler warning as the right part of the condition always evaluates to true when a signed char is checked if it is larger than 127. Some would term this as defensive programming. Though I think if a signed char

Re: [Bug-wget] [PATCH] remote_to_utf8: cut off part of condition always false

2014-11-21 Thread Jakub Cajka
- From: Darshit Shah dar...@gmail.com To: Daniel Stenberg dan...@haxx.se Cc: bug-wget@gnu.org Sent: Friday, November 21, 2014 9:26:01 AM Subject: Re: [Bug-wget] [PATCH] remote_to_utf8: cut off part of condition always false On 11/21, Daniel Stenberg wrote: Hey Attached is a tiny patch