Re: [Bug-wget] [PATCH] replaced read_whole_file() by getline()

2013-05-17 Thread Giuseppe Scrivano
Tim Rühsen tim.rueh...@gmx.de writes: My diff is not a format-patch one (got some git technical problems), but I hope you can apply it. Be careful with src/ChangeLog, I guess you have to delete a few lines after patching. In addition to the first patch, I replaced some tab indents by

Re: [Bug-wget] [PATCH] replaced read_whole_file() by getline()

2013-05-14 Thread Tim Rühsen
Sorry, forgot to switch my IDE to GNU style. But now that I made all the requested changes to my working tree, how do I make a diff to some commit back in time or to upstream ? Especially with git format-patch ? Locally, I didn't create my own branch, so i am on master. (I have to read a git

Re: [Bug-wget] [PATCH] replaced read_whole_file() by getline()

2013-05-14 Thread Daniel Stenberg
On Tue, 14 May 2013, Tim Rühsen wrote: But now that I made all the requested changes to my working tree, how do I make a diff to some commit back in time or to upstream ? Especially with git format-patch ? Locally, I didn't create my own branch, so i am on master. (I have to read a git book

Re: [Bug-wget] [PATCH] replaced read_whole_file() by getline()

2013-05-14 Thread Tim Rühsen
Thank you and Angel for your answers. Am Dienstag, 14. Mai 2013 schrieb Daniel Stenberg: On Tue, 14 May 2013, Tim Rühsen wrote: But now that I made all the requested changes to my working tree, how do I make a diff to some commit back in time or to upstream ? Especially with git

[Bug-wget] [PATCH] replaced read_whole_file() by getline()

2013-05-11 Thread Tim Rühsen
Replaced read_whole_file(), which needs one malloc/free per line, by getline() which reuses a growable buffer. getline() is a GNU function (but Wget is a GNU tool, isn't it ? :-). Since Wget compiles/links with gnulib, I don't see a problem here. Regards, Tim From