Re: [Bug-wget] [PATCH 16/25] Bugfix: Remove surrounding quotes from Metalink/HTTP key's value

2016-09-13 Thread Matthew White
On Sun, 11 Sep 2016 23:10:55 +0200 Giuseppe Scrivano wrote: > Matthew White writes: > > > +/* > > + Remove the quotation surrounding a string. > > + > > + The string is permanently modified. > > + */ > > +void > > +dequote_metalink_string (char

Re: [Bug-wget] [PATCH 16/25] Bugfix: Remove surrounding quotes from Metalink/HTTP key's value

2016-09-11 Thread Giuseppe Scrivano
Matthew White writes: > +/* > + Remove the quotation surrounding a string. > + > + The string is permanently modified. > + */ > +void > +dequote_metalink_string (char **str) > +{ > + char *new, *beg, *end; > + size_t str_len, new_len; > + > + if (!str || !*str) > +

[Bug-wget] [PATCH 16/25] Bugfix: Remove surrounding quotes from Metalink/HTTP key's value

2016-09-10 Thread Matthew White
[Coverity Scan is ok, make syntax-check is ok, make check-valgrind is ok, contrib/check-hard is ok] This fixes problems introduced by processing a Metalink/HTTP header which contains quoted values. The following description is verbatim from the patch: - Some Metalink/HTTP keys, like "type"