It is ok for me.
Here is slightly different approach to set ENABLE_PSL.
Maybe you find it more readable / understandable.
ENABLE_PSL=no
AC_ARG_WITH(libpsl,
AS_HELP_STRING([--without-libpsl], [disable support for libpsl cookie
checking.]),
[],
[AC_SEARCH_LIBS(psl_builtin, psl,
Are there any issues with this patch? Or can we push this?
It worked just fine for me. I guess, we should update the others too.
On Thu, Jun 12, 2014 at 8:53 PM, Tim Rühsen wrote:
> Am Donnerstag, 12. Juni 2014, 13:24:02 schrieb Giuseppe Scrivano:
>> Darshit Shah writes:
>> > On Wed, Jun 11, 20
That patch works perfectly for me.
Maybe we should update the rest of the file along the same lines? It
would help to reduce some fragmentation.
On Thu, Jun 12, 2014 at 8:53 PM, Tim Rühsen wrote:
> Am Donnerstag, 12. Juni 2014, 13:24:02 schrieb Giuseppe Scrivano:
>> Darshit Shah writes:
>> > On
Am Donnerstag, 12. Juni 2014, 13:24:02 schrieb Giuseppe Scrivano:
> Darshit Shah writes:
> > On Wed, Jun 11, 2014 at 5:20 PM, Tim Rühsen wrote:
> >> Am Freitag, 6. Juni 2014, 13:39:32 schrieb Darshit Shah:
> >>> I'm facing an issue with the patch I submitted for libpsl and would be
> >>> glad if
Am Donnerstag, 12. Juni 2014, 07:16:13 schrieb Darshit Shah:
> Yes, the configure statements given by Tim work. I found out that the issue
> on machine was caching of configure values. Deleting the configure cache
> fixed the issue.
>
> I also agree with Giuseppe's point about not using the autoco
Yes, the configure statements given by Tim work. I found out that the issue on
machine was caching of configure values. Deleting the configure cache fixed the
issue.
I also agree with Giuseppe's point about not using the autoconf variables.
Let's fix the rest of them too.
Tim's patch however
Darshit Shah writes:
> On Wed, Jun 11, 2014 at 5:20 PM, Tim Rühsen wrote:
>> Am Freitag, 6. Juni 2014, 13:39:32 schrieb Darshit Shah:
>>> I'm facing an issue with the patch I submitted for libpsl and would be
>>> glad if someone could help me.
>>>
>>> The configure.ac file does not work as expec
Am Mittwoch, 11. Juni 2014, 18:57:13 schrieb Darshit Shah:
> On Wed, Jun 11, 2014 at 5:20 PM, Tim Rühsen wrote:
> > Am Freitag, 6. Juni 2014, 13:39:32 schrieb Darshit Shah:
> >> I'm facing an issue with the patch I submitted for libpsl and would be
> >> glad if someone could help me.
> >>
> >> Th
On Wed, Jun 11, 2014 at 5:20 PM, Tim Rühsen wrote:
> Am Freitag, 6. Juni 2014, 13:39:32 schrieb Darshit Shah:
>> I'm facing an issue with the patch I submitted for libpsl and would be
>> glad if someone could help me.
>>
>> The configure.ac file does not work as expected. When libpsl is not
>> ins
Am Mittwoch, 11. Juni 2014, 13:50:46 schrieb Tim Rühsen:
> Am Freitag, 6. Juni 2014, 13:39:32 schrieb Darshit Shah:
> > I'm facing an issue with the patch I submitted for libpsl and would be
> > glad if someone could help me.
> >
> > The configure.ac file does not work as expected. When libpsl is
Am Freitag, 6. Juni 2014, 13:39:32 schrieb Darshit Shah:
> I'm facing an issue with the patch I submitted for libpsl and would be
> glad if someone could help me.
>
> The configure.ac file does not work as expected. When libpsl is not
> installed on a system, the LDFLAGS does not contain -lpsl fla
Hi Giuseppe,
Thanks for the patch. But no, it doesn't solve the problem yes.
Here is the configure summary I get:
configure: Summary of build options:
Version: 1.15.28-854eb-dirty
Host OS: linux-gnu
Install prefix:/usr/local
Compiler: clang
CFlags:
Darshit Shah writes:
> I'm facing an issue with the patch I submitted for libpsl and would be
> glad if someone could help me.
>
> The configure.ac file does not work as expected. When libpsl is not
> installed on a system, the LDFLAGS does not contain -lpsl flag, but
> the configure summary show
Darshit Shah writes:
>> Not sure about using pkg-config in Wget's configure.ac. That would be an
>> option for detecting libpsl (and other libs as well, I guess). We can work
>> also on that later if there are no complaints against that.
>>
> I'm not sure about using pkg-config. I don't know much
I'm facing an issue with the patch I submitted for libpsl and would be
glad if someone could help me.
The configure.ac file does not work as expected. When libpsl is not
installed on a system, the LDFLAGS does not contain -lpsl flag, but
the configure summary shows LIBPSL: Yes.
There is some disc
On Thu, Jun 5, 2014 at 4:16 PM, Tim Ruehsen wrote:
> On Thursday 05 June 2014 15:27:21 Darshit Shah wrote:
>> Tim,
>>
>> As the author of libpsl, I'm waiting on you to ACK this, so we can merge.
>
> Sorry for letting you wait, Darshit.
Sure, no issues.
>
> The patch looks good to me though i am no
On Thursday 05 June 2014 15:27:21 Darshit Shah wrote:
> Tim,
>
> As the author of libpsl, I'm waiting on you to ACK this, so we can merge.
Sorry for letting you wait, Darshit.
The patch looks good to me though i am not able to test it right now. But i am
sure, you did it already ;-)
Not correct
Tim,
As the author of libpsl, I'm waiting on you to ACK this, so we can merge.
On Wed, Jun 4, 2014 at 4:30 PM, Giuseppe Scrivano wrote:
> Darshit Shah writes:
>
>> From 5b25217ecf6eb1897d769f2ee0aa5e922e6cbff4 Mon Sep 17 00:00:00 2001
>> From: Darshit Shah
>> Date: Fri, 30 May 2014 22:10:12 +0
Darshit Shah writes:
> From 5b25217ecf6eb1897d769f2ee0aa5e922e6cbff4 Mon Sep 17 00:00:00 2001
> From: Darshit Shah
> Date: Fri, 30 May 2014 22:10:12 +0530
> Subject: [PATCH] Support libpsl for cookie domain checking
>
> ---
> ChangeLog | 5 +
> NEWS| 2 ++
> READ
Hi,
I've updated the patch with a small change to add libpsl to the list
of "not absolutely required" dependencies.
On Sun, Jun 1, 2014 at 2:35 AM, Ángel González wrote:
> On 31/05/14 21:30, Darshit Shah wrote:
>>
>> + * [35]libpsl is (optionally) required for checking cookie domains.
>> +
>
Hi Tim,
I've already submitted an update version of the patch to match the new library
name. Do let me know if you haven't received it. I'll resend the email in that
case.
—
Thanking you,
Darshit Shah
Sent from mobile. Please excuse any errors.
On Sun, Jun 1, 2014 at 3:46 PM, Tim Rühsen w
Am Freitag, 30. Mai 2014, 22:24:19 schrieb Darshit Shah:
> I've attached a patch that adds support for using libpsl for cookie
> domain checking in Wget.
>
> The old heuristic checks still remain as a fallback. When the libpsl
> library on the system is built without the builtin list, Wget simply
On Sun, Jun 1, 2014 at 2:35 AM, Ángel González wrote:
> On 31/05/14 21:30, Darshit Shah wrote:
>>
>> + * [35]libpsl is (optionally) required for checking cookie domains.
>> +
>
> It's weird to have something "optionally required". I would remove
> "(optionally)"
> and add it at the list on the
On 31/05/14 21:30, Darshit Shah wrote:
+ * [35]libpsl is (optionally) required for checking cookie domains.
+
It's weird to have something "optionally required". I would remove
"(optionally)"
and add it at the list on the top of "not absolutely required" dependencies.
That file needs a bi
Hi,
This is an updated version of the patch to build against the latest
libpsl release which changes the so-numbers.
P.S.: In case anyone is trying to test this on a Arch Linux system,
I've uploaded libpsl to the AUR.
For users of debian and derivative systems, I think there's a package
coming ve
I've attached a patch that adds support for using libpsl for cookie
domain checking in Wget.
The old heuristic checks still remain as a fallback. When the libpsl
library on the system is built without the builtin list, Wget simply
fallsback to the old heuristic checks. Similarly, if wget is built
26 matches
Mail list logo
