Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-23 Thread Giuseppe Scrivano
Tim Rühsen writes: > Thanks, perfect. pushed! Giuseppe

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-23 Thread Tim Rühsen
Am Dienstag, 23. Juli 2013, 15:47:35 schrieb Giuseppe Scrivano: > Tim Rühsen writes: > > You changed my original patch in a way, that you won't need AM_CONDITIONAL > > any more. Try commenting it out - it should work. > > Thanks, it seems to work here. Are you ok with this commit? > > I have al

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-23 Thread Giuseppe Scrivano
Tim Rühsen writes: > You changed my original patch in a way, that you won't need AM_CONDITIONAL > any > more. Try commenting it out - it should work. Thanks, it seems to work here. Are you ok with this commit? I have also added a missing entry for the ChangeLog file. Giuseppe >From ffb94

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-23 Thread Tim Rühsen
Am Dienstag, 23. Juli 2013, 13:43:13 schrieb Giuseppe Scrivano: > Tim Rühsen writes: > > The above error puzzles me. > > > > Did you do an 'autoreconf' after you locally applied the commit ? > > > > Could someone explain that error to me ? > > I think you can reproduce it when you try to build

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-23 Thread Giuseppe Scrivano
Tim Rühsen writes: > The above error puzzles me. > > Did you do an 'autoreconf' after you locally applied the commit ? > > Could someone explain that error to me ? I think you can reproduce it when you try to build with openssl instead of gnutls. What do you get when you use "./configure --with

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-23 Thread Tim Rühsen
Am Montag, 22. Juli 2013, 23:13:17 schrieb Darshit Shah: This patch seems to break for normal builds. I get the following error on running make: configure: error: conditional "HAVE_NETTLE" was never defined. Usually this means the macro was only invoked conditionally. make: *** [config.statu

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-22 Thread Giuseppe Scrivano
Darshit Shah writes: > This patch seems to break for normal builds.  > > > I get the following error on running make: > > configure: error: conditional "HAVE_NETTLE" was never defined. > Usually this means the macro was only invoked conditionally. > make: *** [config.status] Error 1 Thanks to ha

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-22 Thread Darshit Shah
This patch seems to break for normal builds. I get the following error on running make: configure: error: conditional "HAVE_NETTLE" was never defined. Usually this means the macro was only invoked conditionally. make: *** [config.status] Error 1 On Mon, Jul 22, 2013 at 4:43 AM, Giuseppe Scrivan

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-21 Thread Giuseppe Scrivano
Tim Rühsen writes: > @Giuseppe: I will git format-patch the stuff this evening. > Is there anything missing ? sorry for my delayed answer. If the patch works for Tom, then let's apply it. Can you please send me the git format-patch version? Thanks for your contribution! Giuseppe

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-16 Thread Tony Lewis
NTLM has evolved over the years. The last time I looked at the code, wget only supported NTLM message types 1 and 2. It very well may be that the server you are connecting to requires type 3 messages. In 2009, I did a major refactoring of http_ntlm.c (against the wget 1.11.4 sources) to support NT

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-16 Thread Tom Merriam
On 07/16/2013 08:51 AM, Tim Rühsen wrote: > Am Dienstag, 16. Juli 2013, 08:34:28 schrieb Tom Merriam: >> I tried that, but had the same problem. I gave up, re-extracted the >> source from archive, and reapplied patch. I compiled it with configure >> && make and it works! >> >> I am able to authenti

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-16 Thread Tim Rühsen
Am Dienstag, 16. Juli 2013, 08:34:28 schrieb Tom Merriam: > I tried that, but had the same problem. I gave up, re-extracted the > source from archive, and reapplied patch. I compiled it with configure > && make and it works! > > I am able to authenticate with my Windows Server. > > GNU Wget 1.14

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-16 Thread Tom Merriam
On 07/16/2013 04:11 AM, Tim Rühsen wrote: > Am Montag, 15. Juli 2013, 16:48:36 schrieb Tom Merriam: When built with configure & make (with that patch): GNU Wget 1.14 built on linux-gnu. +digest +https +ipv6 -iri +large-file +nls -ntlm +opie +ssl/gnutls Wgetrc: >>>

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-16 Thread Tim Rühsen
Am Montag, 15. Juli 2013, 16:48:36 schrieb Tom Merriam: > >> When built with configure & make (with that patch): > >> > >> GNU Wget 1.14 built on linux-gnu. > >> > >> +digest +https +ipv6 -iri +large-file +nls -ntlm +opie +ssl/gnutls > >> > >> Wgetrc: > >> /usr/local/etc/wgetrc (system) > >>

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-15 Thread Tom Merriam
On 07/15/2013 04:06 PM, Tim Rühsen wrote: > Am Montag, 15. Juli 2013, 13:07:08 schrieb Tom Merriam: >> On 07/15/2013 11:19 AM, Tim Rühsen wrote: >>> Am Montag, 15. Juli 2013, 09:50:27 schrieb Tom Merriam: On 07/13/2013 08:00 AM, Tim Rühsen wrote: > Am Mittwoch, 10. Juli 2013 schrieb Hrvoje

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-15 Thread Tim Rühsen
Am Montag, 15. Juli 2013, 13:07:08 schrieb Tom Merriam: > On 07/15/2013 11:19 AM, Tim Rühsen wrote: > > Am Montag, 15. Juli 2013, 09:50:27 schrieb Tom Merriam: > >> On 07/13/2013 08:00 AM, Tim Rühsen wrote: > >>> Am Mittwoch, 10. Juli 2013 schrieb Hrvoje Niksic: > The NTLM code kindly donated

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-15 Thread Tom Merriam
On 07/15/2013 11:19 AM, Tim Rühsen wrote: > Am Montag, 15. Juli 2013, 09:50:27 schrieb Tom Merriam: >> On 07/13/2013 08:00 AM, Tim Rühsen wrote: >>> Am Mittwoch, 10. Juli 2013 schrieb Hrvoje Niksic: The NTLM code kindly donated by Daniel has always required OpenSSL. configure.ac says: >>>

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-15 Thread Tim Rühsen
Am Montag, 15. Juli 2013, 09:50:27 schrieb Tom Merriam: > On 07/13/2013 08:00 AM, Tim Rühsen wrote: > > Am Mittwoch, 10. Juli 2013 schrieb Hrvoje Niksic: > >> The NTLM code kindly donated by Daniel has always required OpenSSL. > >> configure.ac says: > >> > >> Updating the code to also support GNU

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-15 Thread Tom Merriam
On 07/13/2013 08:00 AM, Tim Rühsen wrote: > Am Mittwoch, 10. Juli 2013 schrieb Hrvoje Niksic: >> The NTLM code kindly donated by Daniel has always required OpenSSL. >> configure.ac says: >> >> Updating the code to also support GNU/TLS appears straightforward. > Here is a (quick) patch for testing u

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-13 Thread Tim Rühsen
Am Mittwoch, 10. Juli 2013 schrieb Hrvoje Niksic: > The NTLM code kindly donated by Daniel has always required OpenSSL. > configure.ac says: > > Updating the code to also support GNU/TLS appears straightforward. Here is a (quick) patch for testing using libnettle (which GnuTLS relies on anyway).

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-11 Thread Tim Rühsen
Am Mittwoch, 10. Juli 2013 schrieb Hrvoje Niksic: > The NTLM code kindly donated by Daniel has always required OpenSSL. > configure.ac says: > > dnl Enable NTLM if requested and if SSL is available. > if test x"$LIBSSL" != x || test "$ac_cv_lib_ssl32_SSL_connect" = yes > then > i

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-10 Thread Hrvoje Niksic
Giuseppe Scrivano writes: > Tom Merriam writes: > >> I built wget with openssl (configure --with-ssl=openssl && make) and I >> am able to authenticate against my server. >> >> Is this a bug with wget, gnutls, or with the way debian builds wget? > > I am quite sure that this is a bug in wget. Th

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-10 Thread Giuseppe Scrivano
Tom Merriam writes: > I built wget with openssl (configure --with-ssl=openssl && make) and I > am able to authenticate against my server. > > Is this a bug with wget, gnutls, or with the way debian builds wget? I am quite sure that this is a bug in wget. -- Giuseppe

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-10 Thread Tom Merriam
On 07/09/2013 05:20 PM, Giuseppe Scrivano wrote: > Tom Merriam writes: > >> I tried with 1.14 built from source and it has the same problem. It was >> built with gnutls. >> >> Unfortunately, this server is not publicly available for testing. > thanks for the quick feedback and the additional info

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-09 Thread Giuseppe Scrivano
Tom Merriam writes: > I tried with 1.14 built from source and it has the same problem. It was > built with gnutls. > > Unfortunately, this server is not publicly available for testing. thanks for the quick feedback and the additional info. Could it be possible to you to build wget using OpenSSL

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-09 Thread Tom Merriam
On 07/09/2013 04:24 PM, Giuseppe Scrivano wrote: > Tom Merriam writes: > >> After upgrading from squeeze to wheezy, NTLM authentication no longer >> works. A command such as >> >> wget --user=user --password=password --server-response >> http://server/page.aspx -O file.pdf >> >> fails with this ou

Re: [Bug-wget] NTLM auth broken in 1.13.4

2013-07-09 Thread Giuseppe Scrivano
Tom Merriam writes: > After upgrading from squeeze to wheezy, NTLM authentication no longer > works. A command such as > > wget --user=user --password=password --server-response > http://server/page.aspx -O file.pdf > > fails with this output: > > Connecting to 10.1.1.34:80... connected. > HTTP r

[Bug-wget] NTLM auth broken in 1.13.4

2013-07-02 Thread Tom Merriam
After upgrading from squeeze to wheezy, NTLM authentication no longer works. A command such as wget --user=user --password=password --server-response http://server/page.aspx -O file.pdf fails with this output: Connecting to 10.1.1.34:80... connected. HTTP request sent, awaiting response... HTT