Re: [Bug-wget] patch: Improve the rolling file name length for downloading progress image when without NLS

2017-02-17 Thread Eli Zaretskii
> Date: Fri, 17 Feb 2017 14:44:02 +0100 > From: "Andries E. Brouwer" > Cc: "Andries E. Brouwer" , tim.rueh...@gmx.de, > bug-wget@gnu.org, lifenjoi...@163.com > > On Fri, Feb 17, 2017 at 03:38:40PM +0200, Eli Zaretskii wrote: > > > Fonts

Re: [Bug-wget] patch: Improve the rolling file name length for downloading progress image when without NLS

2017-02-17 Thread Andries E. Brouwer
On Fri, Feb 17, 2017 at 03:38:40PM +0200, Eli Zaretskii wrote: > Fonts indeed can affect the visual width, but if we assume that the > terminal font is a fixed-pitch one, that problem is much less > significant, IME. Experience shows that one may get a single-width replacement symbol when the

Re: [Bug-wget] patch: Improve the rolling file name length for downloading progress image when without NLS

2017-02-17 Thread Tim Ruehsen
On Friday, February 17, 2017 12:11:54 AM CET YX Hao wrote: > Dear Tim, > > > > I think you may misunderstand my situation or just starting to reproduce the > issue. > > My configuration result is NO NLS support, that means 'USE_NLS_PROGRESS_BAR' > is undefined. Hi YX Hao, @Andries please

Re: [Bug-wget] patch: Improve the rolling file name length for downloading progress image when without NLS

2017-02-16 Thread YX Hao
Dear Tim, I think you may misunderstand my situation or just starting to reproduce the issue. My configuration result is NO NLS support, that means 'USE_NLS_PROGRESS_BAR' is undefined. I guess screenshot is necessary at this time. And it will always fall to the 'else' case of

Re: [Bug-wget] patch: Improve the rolling file name length for downloading progress image when without NLS

2017-02-16 Thread YX Hao
Hi Guys, The algorithm to locate the string sequence, which is for scrolling long file name in the downloading progress animation, is hard ;p The only problem is the 'cols_to_bytes' function for no NLS feature, which returns wrong bytes number should be copied! I guess. Will some body take a

[Bug-wget] patch: Improve the rolling file name length for downloading progress image when without NLS

2017-02-15 Thread YX Hao
Hi there, My configuration is without NLS feature, and got the bug with extra copying over the file name end, when the leftover length of the file name is less than the preset displaying length. And, with the ending '\0', the left part of the progress image won't be printed and updated.