Re: [Bug-wget] patch: Stored file name coversion logic correction

2017-02-16 Thread Tim Ruehsen
On Thursday, February 16, 2017 4:10:22 PM CET YX Hao wrote: > My bad! I made a stupid mistake! > Then, how can Tim's case pass the 'iconv' function? Maybe the > 'from_encoding' in 'convert_fname' function is the same as the > 'to_encoding'. Did he download from a same encoding server??? >

Re: [Bug-wget] patch: Stored file name coversion logic correction

2017-02-16 Thread Tim Ruehsen
On Thursday, February 16, 2017 4:10:22 PM CET YX Hao wrote: > My bad! I made a stupid mistake! > Then, how can Tim's case pass the 'iconv' function? Maybe the > 'from_encoding' in 'convert_fname' function is the same as the > 'to_encoding'. Did he download from a same encoding server??? >

Re: [Bug-wget] patch: Stored file name coversion logic correction

2017-02-16 Thread YX Hao
My bad! I made a stupid mistake! Then, how can Tim's case pass the 'iconv' function? Maybe the 'from_encoding' in 'convert_fname' function is the same as the 'to_encoding'. Did he download from a same encoding server??? 在2017年02月16 14时07分, "Eli Zaretskii"写道: > Date: Thu, 16

Re: [Bug-wget] patch: Stored file name coversion logic correction

2017-02-15 Thread Eli Zaretskii
> Date: Thu, 16 Feb 2017 12:42:23 +0800 (CST) > From: "YX Hao" > > I downloaded the 'mbox format' original, and found out the reason why you > can't reproduce the issue. > The non-ASCII characters you use is encoded in "iso-8859-1" in your email, > and should be displayed

Re: [Bug-wget] patch: Stored file name coversion logic correction

2017-02-15 Thread YX Hao
Hi Tim, I downloaded the 'mbox format' original, and found out the reason why you can't reproduce the issue. The non-ASCII characters you use is encoded in "iso-8859-1" in your email, and should be displayed correctly in your environment. So, your encoding is compatible with 'UTF8', which is

Re: [Bug-wget] patch: Stored file name coversion logic correction

2017-02-15 Thread lifenjoiner
Hi Tim, First, sorry for not subscribing the mailing lists. The reply is formatted manually, trying to keep the style :) >> Hi there, >> >> >> >> I got this on a non-ASCII environment. The local path contains non-ASCII >> characters with OEM ANSI encoded. So, we should convert the server

Re: [Bug-wget] patch: Stored file name coversion logic correction

2017-02-15 Thread Tim Ruehsen
On Wednesday, February 15, 2017 7:12:16 PM CET YX Hao wrote: > Hi there, > > > > I got this on a non-ASCII environment. The local path contains non-ASCII > characters with OEM ANSI encoded. So, we should convert the server responded > file name before it is concatenated to the local path. Not

[Bug-wget] patch: Stored file name coversion logic correction

2017-02-15 Thread YX Hao
Hi there, I got this on a non-ASCII environment. The local path contains non-ASCII characters with OEM ANSI encoded. So, we should convert the server responded file name before it is concatenated to the local path. Not after that. Or, it will cause error in the next 'iconv' function . Best