Re: [Bug-wget] bug #45790: wget prints it's progress even when background

Hi Piotr, Thanks for your interest in Wget. I shall review your patch soon. However, for future reference please do not send patches that are pasted into the mail like this. It makes it extremely difficult for us to apply the patch. I was unable to apply the provided diff after simply saving

[Bug-wget] Still Failing: darnir/wget#85 (master - a2c4849)

Build Update for darnir/wget - Build: #85 Status: Still Failing Duration: 7 minutes and 19 seconds Commit: a2c4849 (master) Author: Tim Rühsen Message: Fix crash on 'srcset' inline URIs * src/html-url.c (tag_handle_img): Check append_url() for NULL return

Re: [Bug-wget] bug #45790: wget prints it's progress even when background

Hi Darshit, Sorry for pasting patch into email incorrectly. I've send 2 other patches before, but as attachments, so they should be fine. Thanks Piotr W dniu 19.09.2016 o 17:28, Darshit Shah pisze: Hi Piotr, Thanks for your interest in Wget. I shall review your patch soon. However, for

Re: [Bug-wget] bug #45790: wget prints it's progress even when background

Ok, I'll fix that. Thanks Piotr W dniu 19.09.2016 o 19:30, Darshit Shah pisze: Hi Piotr, The patch looks fine. However, when Wget is foregrounded again, the progress bar remains invisible. When the process is foregrounded again, you should undo the effects of `redirect_output_signal()` *

Re: [Bug-wget] bug #48811: netrc password wins over interactive --ask-password

Sure. W dniu 19.09.2016 o 19:07, Darshit Shah pisze: This patch looks good. However, if we are touching this part of the code, I would like to take the opportunity to clean it up as well. From a brief glance it looks like the code for check for username and password can be abstracted into

Re: [Bug-wget] bug #46584: wget --spider always returns zero exit status

Hi Piotr, How did you create this patch? Because git refuses to accept it. Patch format detection fails. Please regenerate all your patches using `git format-patch` so that we can apply the patches locally. * Wajda, Piotr [160916 22:48]: Hi, I'd like to start

Re: [Bug-wget] bug #48811: netrc password wins over interactive --ask-password

This patch looks good. However, if we are touching this part of the code, I would like to take the opportunity to clean it up as well. From a brief glance it looks like the code for check for username and password can be abstracted into its own function. This way we can improve readability

Re: [Bug-wget] bug #46584: wget --spider always returns zero exit status

I'm not yet fully familiar with git format-patch (weird for me that it's adding email-like headers. Is it suppose to be email creation tool for patches?), I believe it will work for you. Thanks Piotr W dniu 19.09.2016 o 18:56, Darshit Shah pisze: Hi Piotr, How did you create this patch?

Re: [Bug-wget] bug #46584: wget --spider always returns zero exit status

Apart from the patch format, the patch itself looks good. @Giuseppe: We will require Copyright assignments for Piotr right? This patch may be small, but there are a couple others in the pipeline. * Wajda, Piotr [160916 22:48]: Hi, I'd like to start contributing to wget.

Re: [Bug-wget] bug #45790: wget prints it's progress even when background

Hi Piotr, The patch looks fine. However, when Wget is foregrounded again, the progress bar remains invisible. When the process is foregrounded again, you should undo the effects of `redirect_output_signal()` * pwa...@gmail.net.pl [160919 18:01]: Hi Darshit, Sorry for

Re: [Bug-wget] bug #46584: wget --spider always returns zero exit status

It's correct. That is because `git format-patch` is often used together with `git send-email`. It formats the patch as an email that can be directly passed to your MUA. What you sent is a correct form of the patch that is easy for us to apply. However, notice that you sent the patch on the