Re: [Bug-wget] WARC output

[Giuseppe Scrivano]

Hi Gijs,


Gijs van Tulder gvtul...@gmail.com writes:

 can you please send a complete diff against the current development
 tree version?

 Here's the diff of the WARC additions (1.9MB zipped) to revision 2565:

  http://dl.dropbox.com/u/365100/wget_warc-20110926-complete.patch.bz2

the patch is huge and I think we don't want to add some many files into
the wget tree.  Can't we assume the user will install the warc tools by
herself and let configure check if they are installed or not?  This will
require some more work but the result will be much less intrusive.  What
do you think?

Thanks,
Giuseppe

Re: [Bug-wget] WARC output

[Ángel González]

Giuseppe Scrivano wrote:

the patch is huge and I think we don't want to add some many files into
the wget tree.  Can't we assume the user will install the warc tools by
herself and let configure check if they are installed or not?  This will
require some more work but the result will be much less intrusive.  What
do you think?

Thanks,
Giuseppe

I don't think all those files are even remotely needed.
I am seeing for instance, python files for creating warc interacting 
with curl.

Why would that be useful in wget repository?
I -optimistically- think we could make warc files with a simpler 
implementation.

Also, the patch seems to duplicate code (compare lines 337731-337810 with
337944-338013 in the patch file). Surely that could be refactored?