[Bug-wget] empty VERSION in 1.13.4

2011-12-12 Thread Elan Ruusamäe

hi

i reported on irc, but apparently nobody listens there:

Day changed to 09 Dec  2011
22:07:16  glen 1.13.4 tarball is buggy. builds from it lack version id 
in user agent header

22:07:36  glen $ wget -q -O -  ifconfig.me/ua
22:07:44  glen this prints: Wget/ (linux-gnu)
22:08:03  glen seems the problem is that tarball does not contain this 
file: sh: build-aux/bzr-version-gen: not found

22:08:12  glen so regenerating autoconf creates empty @VERSION@
22:08:28  glen $ grep version.string src/version.c
22:08:28  glen const char *version_string = ;

in pld linux i workarounded:
http://cvs.pld-linux.org/cgi-bin/viewvc.cgi/cvs/packages/wget/wget.spec?r1=1.158r2=1.159 
http://cvs.pld-linux.org/cgi-bin/viewvc.cgi/cvs/packages/wget/wget.spec?r1=1.158r2=1.159



--
glen



Re: [Bug-wget] empty VERSION in 1.13.4

2011-12-12 Thread Giuseppe Scrivano
Elan Ruusamäe g...@pld-linux.org writes:

 hi

 i reported on irc, but apparently nobody listens there:

 Day changed to 09 Dec  2011
 22:07:16  glen 1.13.4 tarball is buggy. builds from it lack version
 id in user agent header
 22:07:36  glen $ wget -q -O -  ifconfig.me/ua
 22:07:44  glen this prints: Wget/ (linux-gnu)
 22:08:03  glen seems the problem is that tarball does not contain
 this file: sh: build-aux/bzr-version-gen: not found
 22:08:12  glen so regenerating autoconf creates empty @VERSION@
 22:08:28  glen $ grep version.string src/version.c
 22:08:28  glen const char *version_string = ;

 in pld linux i workarounded:
 http://cvs.pld-linux.org/cgi-bin/viewvc.cgi/cvs/packages/wget/wget.spec?r1=1.158r2=1.159
 http://cvs.pld-linux.org/cgi-bin/viewvc.cgi/cvs/packages/wget/wget.spec?r1=1.158r2=1.159

Thanks for the report, this one-line patch should fix the problem:

Cheers,
Giuseppe



=== modified file 'ChangeLog'
--- ChangeLog   2011-12-11 14:18:11 +
+++ ChangeLog   2011-12-12 20:24:25 +
@@ -1,3 +1,8 @@
+2011-12-12  Giuseppe Scrivano  gscriv...@gnu.org
+
+   * Makefile.am (EXTRA_DIST): Add build-aux/bzr-version-gen.
+   Reported by: Elan Ruusamäe g...@pld-linux.org.
+
 2011-12-11  Giuseppe Scrivano  gscriv...@gnu.org
 
* util/trunc.c (main): Call `close' on the fd and check for errors.

=== modified file 'Makefile.am'
--- Makefile.am 2011-01-01 12:19:37 +
+++ Makefile.am 2011-12-12 20:14:16 +
@@ -46,7 +46,7 @@
 EXTRA_DIST = ChangeLog.README MAILING-LIST \
  msdos/ChangeLog msdos/config.h msdos/Makefile.DJ \
  msdos/Makefile.WC ABOUT-NLS \
- build-aux/build_info.pl .version
+ build-aux/build_info.pl build-aux/bzr-version-gen .version
 
 CLEANFILES = *~ *.bak $(DISTNAME).tar.gz