From: Giuseppe Scrivano
> Yes, I was just waiting for an ACK from Steven if it works on VMS too.
Seems to, if ".1" is supposed to be the most recent and ".n" the
oldest. (VMS versions normally go the other way.) Around here, with a
quick CGI counter, after five runs of:
wgx -d --back
Tim Rühsen writes:
>> + realm = opaque = nonce = qop = NULL;
>> + algorithm = "MD5";
>
> Don't do that.
> 1. 'algorithm' will be xfreed later
> 2. this forces a 'algorithm="MD5" parameter even if it wasn't given before
> Instead use:
> if (algorithm != NULL && ! strcmp (algorithm, "MD5-ses
> + realm = opaque = nonce = qop = NULL;
> + algorithm = "MD5";
Don't do that.
1. 'algorithm' will be xfreed later
2. this forces a 'algorithm="MD5" parameter even if it wasn't given before
Instead use:
if (algorithm != NULL && ! strcmp (algorithm, "MD5-sess"))
The function does not free v
> can you please share your test case? It will be easier for me to
> reproduce it :-) Feel free to share it to your git repo, that works
> too.
>
> I cannot reproduce it anymore with the new commit on master. Will create a
reproducible test case if I see it again.
--
Thanking You,
Darshit Shah
Darshit Shah writes:
> Also, I keep wondering why Wget returns with a status code of -11
> instead of 6 Authentication Failure or 7 Protocol Error.
can you please share your test case? It will be easier for me to
reproduce it :-) Feel free to share it to your git repo, that works
too.
Giusepp
> From: Kevin Pacheco
>To: bug-wget@gnu.org
>Sent: Thursday, July 11, 2013 8:35 PM
>Subject: [Bug-wget] GnuWin32 wget.exe to stdout not working properly
>
>
>Below is a paste of a ticket I opened at SourceForge. My question for
>the list is whether there exists a compiled version of wget for
>W
> thanks for the feedback. I am pushing this to master:
>
> Thanks!
Also, I keep wondering why Wget returns with a status code of -11 instead
of 6 Authentication Failure or 7 Protocol Error.
--
Thanking You,
Darshit Shah
Darshit Shah writes:
> That diff fixes it. The Digest auth works now.
thanks for the feedback. I am pushing this to master:
>From e9cc8b2f7c4678b832ad56f7119bba86a8db08ef Mon Sep 17 00:00:00 2001
From: Giuseppe Scrivano
Date: Fri, 12 Jul 2013 19:07:22 +0200
Subject: [PATCH] Fix HTTP Digest au
> I think the fix should be:
>
>
That diff fixes it. The Digest auth works now.
--
Thanking You,
Darshit Shah
Tim Rühsen writes:
> we need a check in http.c:3759:
> if (algorithm != NULL && ! strcmp (algorithm, "MD5-sess"))
>
> else we strcmp() with algorithm being NULL.
>
> That should do it.
I think the fix should be:
diff --git a/src/http.c b/src/http.c
index a693355..9f274dc 100644
--- a/src/ht
Hi,
we need a check in http.c:3759:
if (algorithm != NULL && ! strcmp (algorithm, "MD5-sess"))
else we strcmp() with algorithm being NULL.
That should do it.
Regards, Tim
Am Freitag, 12. Juli 2013 schrieb Darshit Shah:
> >
> > I have tried this response and wget just crashes here. What is
>
> I have tried this response and wget just crashes here. What is the
> value for `algorithm' at http.c:3763 (current master version,
> b8f036d16c) when you run it?
>
> It doesn't crash for me. I am currently on HEAD^5 and Wget cleanly exits
here.
How do I debug Wget when calling it from inside t
Darshit Shah writes:
> I was writing a test for Digest Authentication. But I couldn't get Wget to
> respond correctly to a RFC 2067 Digest Authentication Header.
> The Header I was using was:
>
> WWW-Authenticate: Digest realm="Test", nonce="MC40OTIwNTM5NzAwMjA1ODk1",
> opaque="MC40NjY4ODkxODc1Nj
Below is a paste of a ticket I opened at SourceForge. My question for
the list is whether there exists a compiled version of wget for
Windows that's not terribly old and doesn't have this problem. (By the
way, I'm using Gmail. I read in a forum that Gmail is causing problems
with some mailing lists
Hi,
I was writing a test for Digest Authentication. But I couldn't get Wget to
respond correctly to a RFC 2067 Digest Authentication Header.
The Header I was using was:
WWW-Authenticate: Digest realm="Test", nonce="MC40OTIwNTM5NzAwMjA1ODk1",
opaque="MC40NjY4ODkxODc1NjEzMjUxNA=="
To this, Wget si
From: Giuseppe Scrivano
> > [...]
> > while ((line = read_whole_line (fp)) != NULL)
>
> read_whole_line is not used anymore, instead we are using getline from
> gnulib. I cannot find that line in the tarball, what file are you
> building?
Oops. All my fault. While I was dragging the VMS
Tomas Hozza writes:
> You are right. When I tested it I downloaded the site only twice. bakcups
> variable should be int. I hope this is the last piece of puzzle to get
> --backups documented and working.
yes, sorry, I forgot to include this last bit in the tarball I prepared
yesterday. Steven
- Original Message -
> From: Giuseppe Scrivano
>
> > thanks to have tested it, indeed it was working in a different way. I
> > don't think this feature had any user before, considering how broken it
> > is.
>
>I assumed that the VMS details were the only remaining mystery, so
> al
"Steven M. Schweda" writes:
> From: Giuseppe Scrivano
>
>> Yes Sir, here we go! A freshly baked tarball:
>>
>> http://it.gnu.org/~gscrivano/files/wget-1.14.62-9d54.tar.bz2
>
>Half-baked? Lost a few VMS-specific changes, but the first big
> problem was:
>
> while ((line = read_whole_line
Tomas Hozza writes:
> - Original Message -
>> Thanks to have submitted the patch. It looks fine (I have just a minor
>> comment below). Could I please ask you to provide also the entries for
>> the ChangeLog file as part of your patch? It is a boring task but this
>> is required by the
- Original Message -
> Thanks to have submitted the patch. It looks fine (I have just a minor
> comment below). Could I please ask you to provide also the entries for
> the ChangeLog file as part of your patch? It is a boring task but this
> is required by the GNU Coding standards[1]. I
21 matches
Mail list logo