Re: [Bug-wget] Script providing SOCKS proxy support

2014-07-19 Thread Tim Rühsen
Am Freitag, 18. Juli 2014, 23:58:58 schrieb Ángel González: > I have written a wrapping script for wget that -using tsocks- makes it > connect through a socks proxy if the environment variable socks_proxy > is set. > > I'm sharing it here as it may be of interest for a wider audience (or > should

Re: [Bug-wget] [Bug-Wget] Misc. patches

2014-07-19 Thread Tim Rühsen
ACK from here. And please also amend return true ? (is_acceptable == 1) : false; to return is_acceptable == 1; Regards, Tim Am Samstag, 19. Juli 2014, 22:05:26 schrieb Darshit Shah: > Does anyone ack this patch? It's a memory leak that I would like to fix. > > I'll work on Tim'

Re: [Bug-wget] Script providing SOCKS proxy support

2014-07-19 Thread Ángel González
On 19/07/14 18:39, Darshit Shah wrote: Maybe we can maintain a contrib/ directory like other projects? This directory could ship extensions and wrapper scripts that make of Wget in common use cases. That was my first thought, although I then noticed that util folder is very much like that.

Re: [Bug-wget] Dangling info->lfilename

2014-07-19 Thread Gisle Vanem
Could you please confirm if the above patch fixes the problem? Guiseppe have reverted that relevant change. I.e. it's now a buffer like it used to: So yes, that patch fixes the problem of the dangling pointer. --gv

Re: [Bug-wget] Dangling info->lfilename

2014-07-19 Thread Gisle Vanem
"Darshit Shah" wrote: Could you please confirm if the above patch fixes the problem? Guiseppe have reverted that relevant change. I.e. it's now a buffer like it used to: @@ -123,7 +123,7 @@ struct fake_fork_info { HANDLE event; bool logfile_changed; - char lfilename[MAX_PATH + 1]; + char *

[Bug-wget] (no subject)

2014-07-19 Thread Bipil Raut
hello sir.. not execute comment wget because some download file than this occurs error .

Re: [Bug-wget] [PATCH] Allow to redefine ciphers list for OpenSSL

2014-07-19 Thread Darshit Shah
I'm not sure, but looking at the patch, it /does/ seem like it tries to override the user settings, which IMO should not happen. If that is indeed the case, I do not support this patch either. @Giuseppe: About the failing test, that particular test seems to have some weird timing problems. I'm ass

Re: [Bug-wget] Dangling info->lfilename

2014-07-19 Thread Darshit Shah
Hi Gisle, Could you please confirm if the above patch fixes the problem? On Tue, Jun 17, 2014 at 7:29 PM, Giuseppe Scrivano wrote: > Hello, > > "Gisle Vanem" writes: > >> Hello Giuseppe. >> >> You patch to mswindows.c at >> >> http://git.savannah.gnu.org/cgit/wget.git/commit/src/mswindows.c?i

Re: [Bug-wget] Script providing SOCKS proxy support

2014-07-19 Thread Darshit Shah
Maybe we can maintain a contrib/ directory like other projects? This directory could ship extensions and wrapper scripts that make of Wget in common use cases. On Sat, Jul 19, 2014 at 3:28 AM, Ángel González wrote: > I have written a wrapping script for wget that -using tsocks- makes it > connect

Re: [Bug-wget] [Bug-Wget] Misc. patches

2014-07-19 Thread Darshit Shah
Does anyone ack this patch? It's a memory leak that I would like to fix. I'll work on Tim's suggestions next. On Sat, Jul 5, 2014 at 4:38 PM, Darshit Shah wrote: > I just pushed a slightly amended patch. However, here is what I propose: > > diff --git a/src/cookies.c b/src/cookies.c > index 7630