[Bug-wget] [PATCH] Stylistic and idiomatic cleanups in Perl tests

2014-10-31 Thread feinorgh
From: Pär Karlsson feino...@gmail.com --- tests/ChangeLog | 12 + tests/FTPServer.pm | 597 +++ tests/FTPTest.pm | 36 +-- tests/HTTPServer.pm | 208 +- tests/HTTPTest.pm

Re: [Bug-wget] let's fix the openssl backend once and for all

2014-10-31 Thread Ray Satiro
On 10/30/2014 7:18 AM, Giuseppe Scrivano wrote: Tim Rühsen tim.rueh...@gmx.de writes: as I wrote to Mike: It is the OpenSSL code within Wget. Wget compiled with GnuTLS does not show any problems. and this remembers us that maintaining two different backends is not a good idea. I am for just

Re: [Bug-wget] let's fix the openssl backend once and for all

2014-10-31 Thread Giuseppe Scrivano
Mike Frysinger vap...@gentoo.org writes: On 30 Oct 2014 12:18, Giuseppe Scrivano wrote: Tim Rühsen tim.rueh...@gmx.de writes: as I wrote to Mike: It is the OpenSSL code within Wget. Wget compiled with GnuTLS does not show any problems. and this remembers us that maintaining two

[Bug-wget] [PATCH] fix tests/Test-proxied-https-auth.px

2014-10-31 Thread Tim Ruehsen
Here is a fix for tests/Test-proxied-https-auth.px. - fixed the workflow of the test - sync client and server on startup - added valgrind support Please review / test it (with GnuTLS and OpenSSL compiled Wget). Tim From 12fd2c5b6ebc5afe04e85b156b2d13f2fdb56096 Mon Sep 17 00:00:00 2001 From:

Re: [Bug-wget] GNU wget 1.16 released

2014-10-31 Thread Giuseppe Scrivano
Hi Michael, Michael Felt aixto...@gmail.com writes: The build and packaging completed successfully. make check has some issues - see attachments for deeper details. Primary is the change needed in tests/Makefile (I am not smart enough to make changes in automake files, sorry) thanks for

Re: [Bug-wget] let's fix the openssl backend once and for all (was: Patch Test-proxied-https-auth.px)

2014-10-31 Thread Darshit Shah
On Thu, Oct 30, 2014 at 4:48 PM, Giuseppe Scrivano gscriv...@gnu.org wrote: Tim Rühsen tim.rueh...@gmx.de writes: as I wrote to Mike: It is the OpenSSL code within Wget. Wget compiled with GnuTLS does not show any problems. and this remembers us that maintaining two different backends is not

Re: [Bug-wget] let's fix the openssl backend once and for all

2014-10-31 Thread Daniel Stenberg
On Thu, 30 Oct 2014, Giuseppe Scrivano wrote: Do you think it would be possible to make a completely new library out of it? Maybe wget won't be the only user to take advantage of such library. I forgot, I also wrote about this topic a couple of years ago:

[Bug-wget] [PATCH] Stylistic and idiomatic cleanups in Perl tests

2014-10-31 Thread feinorgh
From: Pär Karlsson feino...@gmail.com A number of Perl-specific cleanups in the test suite perl modules. Most of these changes have no immediate functional difference but puts code in line with the same formatting (perltidy GNU style) for readability. A warning regarding invalid operators on

Re: [Bug-wget] let's fix the openssl backend once and for all (was: Patch Test-proxied-https-auth.px)

2014-10-31 Thread Mike Frysinger
On 30 Oct 2014 12:18, Giuseppe Scrivano wrote: Tim Rühsen tim.rueh...@gmx.de writes: as I wrote to Mike: It is the OpenSSL code within Wget. Wget compiled with GnuTLS does not show any problems. and this remembers us that maintaining two different backends is not a good idea. I am for

Re: [Bug-wget] let's fix the openssl backend once and for all

2014-10-31 Thread Daniel Stenberg
On Thu, 30 Oct 2014, Giuseppe Scrivano wrote: [1] = there would be some amount of work involved to make it happen, from both parties, but I think there would be mutual benefit. The code is somewhat separated in the libcurl code base already, but would need some further polish to get properly

Re: [Bug-wget] [PATCH] tests: fix skip exit code

2014-10-31 Thread Tim Ruehsen
On Monday 27 October 2014 14:55:10 Mike Frysinger wrote: The test harness looks for exit code 77 to mark tests as skipped, not exit 2. Switch over so we get SKIP instead of FAIL. --- tests/WgetFeature.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Bug-wget] [PATCH] openssl: fix implicit decl warning

2014-10-31 Thread Tim Ruehsen
On Monday 27 October 2014 14:55:14 Mike Frysinger wrote: Include the right header to fix: openssl.c: In function 'ssl_init': openssl.c:195:3: warning: implicit declaration of function 'ENGINE_load_builtin_engines' [-Wimplicit-function-declaration] ENGINE_load_builtin_engines();

Re: [Bug-wget] let's fix the openssl backend once and for all

2014-10-31 Thread Giuseppe Scrivano
Darshit Shah dar...@gmail.com writes: On Thu, Oct 30, 2014 at 4:48 PM, Giuseppe Scrivano gscriv...@gnu.org wrote: Tim Rühsen tim.rueh...@gmx.de writes: as I wrote to Mike: It is the OpenSSL code within Wget. Wget compiled with GnuTLS does not show any problems. and this remembers us that

Re: [Bug-wget] let's fix the openssl backend once and for all

2014-10-31 Thread Giuseppe Scrivano
Daniel Stenberg dan...@haxx.se writes: On Thu, 30 Oct 2014, Giuseppe Scrivano wrote: and this remembers us that maintaining two different backends is not a good idea. I am for just moving to GNU TLS and forget about OpenSSL. It is a bit drastic but I think it is a better move for the long

Re: [Bug-wget] Several little patches / fixes

2014-10-31 Thread Tim Ruehsen
Thanks for having a look at it. Fixed pushed. Tim On Thursday 30 October 2014 14:19:09 Mike Frysinger wrote: On 30 Oct 2014 09:18, Tim Ruehsen wrote: --- a/src/openssl.c +++ b/src/openssl.c @@ -570,6 +571,27 @@ pattern_match (const char *pattern, const char *string) return *n ==

Re: [Bug-wget] [Bug-Wget] Patch Test-proxied-https-auth.px

2014-10-31 Thread Daniel Stenberg
On Thu, 30 Oct 2014, Tim Ruehsen wrote: [*] = at least originally, until the MITM-ing proxies entered the scheme and complicated matters, but I prefer to view that as messed up SSL and not real SSL =) Yes, however, Wget has to be able to work with these (if users request it). From how I

Re: [Bug-wget] [Bug-Wget] Patch Test-proxied-https-auth.px

2014-10-31 Thread Tim Ruehsen
On Thursday 30 October 2014 14:43:58 Daniel Stenberg wrote: On Thu, 30 Oct 2014, Tim Ruehsen wrote: [*] = at least originally, until the MITM-ing proxies entered the scheme and complicated matters, but I prefer to view that as messed up SSL and not real SSL =) Yes, however, Wget has

Re: [Bug-wget] let's fix the openssl backend once and for all (was: Patch Test-proxied-https-auth.px)

2014-10-31 Thread Daniel Stenberg
On Thu, 30 Oct 2014, Giuseppe Scrivano wrote: and this remembers us that maintaining two different backends is not a good idea. I am for just moving to GNU TLS and forget about OpenSSL. It is a bit drastic but I think it is a better move for the long term. And we get rid of the copyright

Re: [Bug-wget] let's fix the openssl backend once and for all (was: Patch Test-proxied-https-auth.px)

2014-10-31 Thread Tim Ruehsen
On Thursday 30 October 2014 12:18:49 Giuseppe Scrivano wrote: Tim Rühsen tim.rueh...@gmx.de writes: as I wrote to Mike: It is the OpenSSL code within Wget. Wget compiled with GnuTLS does not show any problems. and this remembers us that maintaining two different backends is not a good

Re: [Bug-wget] Several little patches / fixes

2014-10-31 Thread Tim Rühsen
Am Donnerstag, 30. Oktober 2014, 14:19:09 schrieb Mike Frysinger: On 30 Oct 2014 09:18, Tim Ruehsen wrote: --- a/src/openssl.c +++ b/src/openssl.c @@ -570,6 +571,27 @@ pattern_match (const char *pattern, const char *string) return *n == '\0'; } +char

Re: [Bug-wget] [Win32 Patch] console-close events

2014-10-31 Thread Tim Ruehsen
On Monday 20 October 2014 21:34:07 Ángel González wrote: On 20/10/14 03:03, Darshit Shah wrote: On 06/17, Gisle Vanem wrote: Ángel González keis...@gmail.com wrote: PS. The above Sleep() seems to be ignored by WinCon. At least I failed to make it sleep more than ~500 msec. There

Re: [Bug-wget] [Bug-Wget] Patch Test-proxied-https-auth.px

2014-10-31 Thread Giuseppe Scrivano
Darshit Shah dar...@gmail.com writes: Ever since the Perl tests have been ported to the parallel test harness, Test-proxied-https-auth.px has always failed for me. In a prior thread, we'd identified the problem as a race between the HTTPS server being set-up and Wget sending the request.

Re: [Bug-wget] [PATCH] Stylistic and idiomatic cleanups in Perl tests

2014-10-31 Thread Pär Karlsson
Oh, and the test suite works on all stable versions of perl from 5.6 through 5.20. No problems with any of these versions: perl-5.6.2 perl-5.8.9 perl-5.10.1 perl-5.12.5 perl-5.14.4 perl-5.16.3 perl-5.18.4 perl-5.20.1 And I realize now I probably need some guidance how to format patches properly

Re: [Bug-wget] let's fix the openssl backend once and for all

2014-10-31 Thread Tim Rühsen
Am Freitag, 31. Oktober 2014, 11:00:00 schrieb Giuseppe Scrivano: Darshit Shah dar...@gmail.com writes: On Thu, Oct 30, 2014 at 4:48 PM, Giuseppe Scrivano gscriv...@gnu.org wrote: Tim Rühsen tim.rueh...@gmx.de writes: as I wrote to Mike: It is the OpenSSL code within Wget. Wget compiled

Re: [Bug-wget] [Bug-Wget] Patch Test-proxied-https-auth.px

2014-10-31 Thread Tim Rühsen
Am Freitag, 31. Oktober 2014, 16:32:28 schrieb Giuseppe Scrivano: Darshit Shah dar...@gmail.com writes: Ever since the Perl tests have been ported to the parallel test harness, Test-proxied-https-auth.px has always failed for me. In a prior thread, we'd identified the problem as a race

Re: [Bug-wget] [PATCH] Stylistic and idiomatic cleanups in Perl tests

2014-10-31 Thread Tim Rühsen
Am Freitag, 31. Oktober 2014, 18:44:03 schrieb Pär Karlsson: Oh, and the test suite works on all stable versions of perl from 5.6 through 5.20. No problems with any of these versions: perl-5.6.2 perl-5.8.9 perl-5.10.1 perl-5.12.5 perl-5.14.4 perl-5.16.3 perl-5.18.4 perl-5.20.1 And

[Bug-wget] Features request

2014-10-31 Thread taras.malivanc...@totaldefense.com
Hi all, I use wget, I think such features will be useful.Are there objections against the below, or something is already implemented and I did not find? 1) Maximal size of downloaded file (not all the batch) : do not download if value in header present and stop and delete otherwise if it is

Re: [Bug-wget] GNU wget 1.16 released

2014-10-31 Thread Michael Felt
The build and packaging completed successfully. make check has some issues - see attachments for deeper details. Primary is the change needed in tests/Makefile (I am not smart enough to make changes in automake files, sorry) As wget had compiled and packaged/installed correctly I was able to

Re: [Bug-wget] Features request

2014-10-31 Thread Darshit Shah
Hi Taras, Thanks for your interest in Wget. On 10/31, taras.malivanc...@totaldefense.com wrote: Hi all, I use wget, I think such features will be useful.Are there objections against the below, or something is already implemented and I did not find? 1) Maximal size of downloaded file (not

Re: [Bug-wget] [Bug-Wget] Patch Test-proxied-https-auth.px

2014-10-31 Thread Darshit Shah
On 10/31, Giuseppe Scrivano wrote: Darshit Shah dar...@gmail.com writes: Ever since the Perl tests have been ported to the parallel test harness, Test-proxied-https-auth.px has always failed for me. In a prior thread, we'd identified the problem as a race between the HTTPS server being set-up

[Bug-wget] [Bug-Wget] Policy on commit messages

2014-10-31 Thread Darshit Shah
Hi, In the last few days we've seen a huge flurry of activity and a large number of patches have been committed to the code base. As someone who was traveling and hence unable to keep up with the mailing lists, I tried to catch up by looking at the code base and the changes that have been

Re: [Bug-wget] let's fix the openssl backend once and for all (was: Patch Test-proxied-https-auth.px)

2014-10-31 Thread Darshit Shah
On 10/30, Daniel Stenberg wrote: On Thu, 30 Oct 2014, Giuseppe Scrivano wrote: and this remembers us that maintaining two different backends is not a good idea. I am for just moving to GNU TLS and forget about OpenSSL. It is a bit drastic but I think it is a better move for the long term.

Re: [Bug-wget] Features request

2014-10-31 Thread taras.malivanc...@totaldefense.com
Hi Darshit Shah , Darshit Shah wrote: Hi Taras, Thanks for your interest in Wget. On 10/31, taras.malivanc...@totaldefense.com wrote: Hi all, I use wget, I think such features will be useful.Are there objections against the below, or something is already implemented and I did not find?