Re: [Bug-wget] [PATCH] OpenSSL TLSv1+ regression in wget-1.16

2014-12-03 Thread Jérémie Courrèges-Anglas
Hi, Giuseppe Scrivano gscriv...@gnu.org writes: [...] we should also hide --rand-egd from wget --help and do not accept this option when HAVE_RAND_EGD is not set. I thought about that and took the lazy approach: the option is still available even if gnutls is used, even though it's a nop.

Re: [Bug-wget] [PATCH] Fixing C89 warnings

2014-12-03 Thread Gisle Vanem
That's really good news to me. But there are still lots more C99 errors. Espesially in main.c. Now another C99 error got into openssl.c. Patch: --- Git-latest/src/openssl.c2014-12-03 14:06:19 + +++ openssl.c 2014-12-03 14:14:37 + @@ -170,6 +170,7 @@ ssl_init (void) {

[Bug-wget] [Patch] xfree() in mswindows.c

2014-12-03 Thread Gisle Vanem
The change of the 'xfree()' macro should be reflected in mswindows.c: --- Git-latest/src/mswindows.c 2014-12-01 17:42:20 + +++ mswindows.c 2014-12-03 14:43:17 + @@ -89,7 +89,7 @@ static void ws_cleanup (void) { - xfree ((char*)exec_name); + xfree (exec_name); WSACleanup (); }

Re: [Bug-wget] [Patch] xfree() in mswindows.c

2014-12-03 Thread Tim Ruehsen
Thanks, Gisle. I pushed it. Tim On Wednesday 03 December 2014 13:49:18 Gisle Vanem wrote: The change of the 'xfree()' macro should be reflected in mswindows.c: --- Git-latest/src/mswindows.c 2014-12-01 17:42:20 + +++ mswindows.c 2014-12-03 14:43:17 + @@ -89,7 +89,7 @@ static

Re: [Bug-wget] [PATCH] Fixing C89 warnings

2014-12-03 Thread Jérémie Courrèges-Anglas
Gisle Vanem gva...@yahoo.no writes: That's really good news to me. But there are still lots more C99 errors. Espesially in main.c. Now another C99 error got into openssl.c. Patch: Heh, when I patched wget-1.16 I took example on the code around to decide where to declare the variable. And

Re: [Bug-wget] [PATCH] OpenSSL TLSv1+ regression in wget-1.16

2014-12-03 Thread Tim Rühsen
Am Mittwoch, 3. Dezember 2014, 12:36:33 schrieb Jérémie Courrèges-Anglas: Hi, Giuseppe Scrivano gscriv...@gnu.org writes: [...] we should also hide --rand-egd from wget --help and do not accept this option when HAVE_RAND_EGD is not set. I thought about that and took the lazy

Re: [Bug-wget] [PATCH] Fixing C89 warnings

2014-12-03 Thread Tim Rühsen
Thanks, Gisle. It is pushed. That's really good news to me. But there are still lots more C99 errors. Espesially in main.c. Feel free to send patches. Sadly, I can't work with -Werror (but use -std=c89 -pedantic -Wall -Wextra + more). And I also might oversee warnings because the