Re: [Bug-wget] [PATCH] UTF-8-ify contributors' names in wget.texi (#40472)

2015-03-17 Thread Rohan Prinja
Thank you :) On 17 March 2015 at 14:23, Giuseppe Scrivano wrote: > Rohan Prinja writes: > >> Yes, I encountered it, sorry for not checking first. >> >> Turns out some more changes were required. Attached is a new patch >> that also touches doc/texi2pod.pl and doc/Makefile.am, and builds >> witho

Re: [Bug-wget] [PATCH] two Coverity bugs fixed

2015-03-17 Thread Darshit Shah
Ack. They look fine to me On Tue, Mar 17, 2015 at 2:02 AM, Tim Rühsen wrote: > I would like to push these two patches tomorrow if nobody complains. > > Tim -- Thanking You, Darshit Shah

Re: [Bug-wget] --connect-timeout doesn't work on Windows

2015-03-17 Thread Eli Zaretskii
> Date: Sat, 14 Mar 2015 21:18:26 +0100 > From: Gisle Vanem > > I see the from the call-stack that connect() is hanging inside > Gnulib: >... >ntdll.dll!ZwWaitForSingleObject+0xc >ntdll.dll!RtlInterlockedPushEntrySList+0x32b >ntdll.dll!RtlInterlockedPushEntrySList+0x355 >ntdll

Re: [Bug-wget] [PATCH] Trust on first use

2015-03-17 Thread ekrell
If nobody has complains about this change, we should add some documentation, (possibly a test?), and rewrite the commit message to list the changes using a ChangeLog style. Giuseppe If this gets accepted, I would love the opportunity to write the corresponding test. Unless it would be prefer

[Bug-wget] [bug #44559] Configure flag --without-libiconv-prefix is not respected; libiconv is linked against despite the flag

2015-03-17 Thread Tim Ruehsen
Follow-up Comment #1, bug #44559 (project wget): Could you change configure.ac in a way that AM_ICONV is processed unconditionally ? e.g. moving it two lines up. AFAIR, I once had a similar problem but remeber no details. ___ Reply to thi

[Bug-wget] [bug #44559] Configure flag --without-libiconv-prefix is not respected; libiconv is linked against despite the flag

2015-03-17 Thread anonymous
Follow-up Comment #2, bug #44559 (project wget): One further observation. When I don't disable it, wget would depend on libidn and libintl which further depend on libiconv: > ldd /opt/csw/lib/libidn.so.11 libintl.so.8 => /opt/csw/lib/libintl.so.8 libiconv.so.2 => /opt/cs

Re: [Bug-wget] [PATCH] Trust on first use

2015-03-17 Thread Giuseppe Scrivano
Thanks for your contribution! I've some comments on the code: Molnár Géza writes: > diff --git a/src/gnutls.c b/src/gnutls.c > index 5a89e06..38bf2af 100644 > --- a/src/gnutls.c > +++ b/src/gnutls.c > @@ -76,6 +76,85 @@ key_type_to_gnutls_type (enum keyfile_type type) > preprocessor macro.

Re: [Bug-wget] [PATCH] UTF-8-ify contributors' names in wget.texi (#40472)

2015-03-17 Thread Giuseppe Scrivano
Rohan Prinja writes: > Yes, I encountered it, sorry for not checking first. > > Turns out some more changes were required. Attached is a new patch > that also touches doc/texi2pod.pl and doc/Makefile.am, and builds > without errors. I commit-amended before creating this patch instead of > creatin