Am Mittwoch, 8. April 2015, 21:09:28 schrieb Ángel González: > On 08/04/15 19:08, Hubert Tarasiuk wrote: > > W dniu 07.04.2015 o 00:11, Ángel González pisze: > >> On 06/04/15 22:15, Hubert Tarasiuk wrote: > >>> We should probably also fix this comment: > >>>> /* sXXXav : free new when needed ! */ > >>> > >>> As it presumably mentions the problem that we are going to repair. > >> > >> I thought it refered to idna_to_ascii_8z sometimes allocating memory on > >> error (that's > >> why I didn't touch it), but it may as well refer to this. > > > > That would make more sense based on the location of the comment. > > I looked at the current source code for idna_to_ascii_8z ( > > http://www.gnu.org/software/libidn/doxygen/idna_8c_source.html#l00572 ) > > and if I am not mistaken, it should not happen that the *output will be > > set to allocated memory, and the function will fail. > > (I did not find anything concerning this problem in the manual of this > > function.) > > Maybe the comment is out of date? (Commited in July 2008.) Is the author > > of it on this list? > > Saint Xavier was a GSoC contributor in 2008. He *was* subscribed in > January 2009 > (when he sent his last post), but I doubt he is still reading this > mailing list. > > Maybe Micah knows. > > 9a2ea39 added that comment at the same time as the remote_to_utf8 call. > So it may be refering to its allocation, or simply mean he noticed a > idna_to_ascii_8z > when preparing that code. :/
Hmmm, if the bug in idna_to_ascii_8z() has been fixed (as Hubert says), we should simply remove the comment (as Hubert suggests). Hubert, could you amend the patch ? Preferably with Ángel's variable renaming. Regards, Tim
signature.asc
Description: This is a digitally signed message part.