Re: [Bug-wget] [PATCH] wget: Add --ssh-askpass support

* Tim R?hsen [160724 05:19]: > Thanks for your contribution, Liam. > I think it is a good feature. > > A few questions, some have already been mentioned by Eli and Jeremie. > > * what about posix_spawn instead of fork ? It is covered by gnulib... I am not familiar with this

Re: [Bug-wget] [PATCH] wget: Add --ssh-askpass support

I don't think the name --ssh-askpass is appropriate. It would be better to have a parameter to --ask-password like --ask-password=external or receive the name of the environment variable to use. Plus I also agree that something like popen would be preferable.

Re: [Bug-wget] [PATCH] wget: Add --ssh-askpass support

Thanks for your contribution, Liam. I think it is a good feature. A few questions, some have already been mentioned by Eli and Jeremie. * what about posix_spawn instead of fork ? It is covered by gnulib... * the 'strace' is left over from your tests !? * could you attach your patch as a file,