Re: [Bug-wget] [PATCH 25/25] New: --metalink-over-http Content-Type/Disposition Metalink/XML processing

Matthew White writes: > From ec75cdd3f0e748523c64856f01b28128f806fb16 Mon Sep 17 00:00:00 2001 > From: Matthew White > Date: Mon, 29 Aug 2016 20:59:35 +0200 > Subject: [PATCH 25/25] New: --metalink-over-http Content-Type/Disposition >

Re: [Bug-wget] [PATCH 24/25] Bugfix: Set NULL variable due to --content-disposition to Metalink origin

> [Coverity Scan is ok, make syntax-check is ok, make check-valgrind is ok, > contrib/check-hard is ok] > > This solves a segmentation fault when local_file is not properly set, i.e. > due to the use of the option --content-disposition. > > The segmentation fault was generated trying to

Re: [Bug-wget] [PATCH 22/25] Bugfix: Detect when a metalink:file doesn't have any hash

Matthew White writes: > From 3555fe04ab1fc22c93d48f88584c7116d0356bb5 Mon Sep 17 00:00:00 2001 > From: Matthew White > Date: Sun, 28 Aug 2016 14:03:56 +0200 > Subject: [PATCH 22/25] Bugfix: Detect when a metalink:file doesn't have any > hash

Re: [Bug-wget] [PATCH 23/25] New: --trust-server-names saves Metalink/HTTP xml files using the "name" field

Hi Matthew, Matthew White writes: > [Coverity Scan is ok, make syntax-check is ok, make check-valgrind is ok, > contrib/check-hard is ok] > > This allows to use the value of the "name" field, part of a Metalink/HTTP > application/metalink4+xml Link, as file name for

Re: [Bug-wget] [PATCH 19/25] Bugfix: Prevent sorting of unallocated metalink resource/metaurl

Matthew White writes: > diff --git a/src/main.c b/src/main.c > index ac6ee2c..11ea86d 100644 > --- a/src/main.c > +++ b/src/main.c > @@ -2136,10 +2136,11 @@ only if outputting to a regular file.\n")); >for (mres_ptr = mfile->resources; *mres_ptr;

Re: [Bug-wget] [PATCH 19/25] Bugfix: Prevent sorting of unallocated metalink resource/metaurl

Matthew White writes: > From cbed79d8394c8c0a74b2f65cb92d01178184e5fe Mon Sep 17 00:00:00 2001 > From: Matthew White > Date: Thu, 25 Aug 2016 15:26:18 +0200 > Subject: [PATCH 19/25] Bugfix: Prevent sorting of unallocated metalink >

Re: [Bug-wget] [PATCH 18/25] New: Parse Metalink/HTTP header for application/metalink4+xml

Matthew White writes: > [Coverity Scan is ok, make syntax-check is ok, contrib/check-hard is ok] > > `make check-valgrind` fails the following metalink tests due to the bugs > which will be fixed in '[PATCH 19/25] Bugfix: Prevent sorting of unallocated > metalink

Re: [Bug-wget] [PATCH 17/25] New test: Metalink shall not concatenate '/' to an empty directory prefix

Hi Matthew, Matthew White writes: > Matthew White > > From 9f1492729e3771405b13b9375be45e76fdffad62 Mon Sep 17 00:00:00 2001 > From: Matthew White > Date: Sat, 27 Aug 2016 16:16:35 +0200 > Subject: [PATCH 17/25] New

Re: [Bug-wget] [PATCH 16/25] Bugfix: Remove surrounding quotes from Metalink/HTTP key's value

Matthew White writes: > +/* > + Remove the quotation surrounding a string. > + > + The string is permanently modified. > + */ > +void > +dequote_metalink_string (char **str) > +{ > + char *new, *beg, *end; > + size_t str_len, new_len; > + > + if (!str || !*str) > +

Re: [Bug-wget] [PATCH 15/25] Bugfix: Process Metalink/XML url strings containing white spaces and CRLF

Matthew White writes: > +void > +clean_metalink_string (char **str) > +{ > + int c; > + size_t len; > + char *new, *beg, *end; > + > + if (!str || !*str) > +return; > + > + beg = *str; > + > + while ((c = *beg) && (c == '\n' || c == '\r' || c == '\t' || c == '

Re: [Bug-wget] [PATCH 14/25] New test: Detect when there are no good Metalink url resources

Matthew White writes: > [Coverity Scan is ok, make syntax-check is ok, make check-valgrind is ok, > contrib/check-hard is ok] > > This adds a new Metalink test. > > The following description is verbatim from the patch: > - > Test if when there are no good Metalink

Re: [Bug-wget] [PATCH 13/25] New: Metalink file size mismatch returns error code METALINK_SIZE_ERROR

Matthew White writes: > From 448e3c06cd9589509cd3914a43fe4c7e93e9d622 Mon Sep 17 00:00:00 2001 > From: Matthew White > Date: Mon, 22 Aug 2016 09:13:52 +0200 > Subject: [PATCH 13/25] New: Metalink file size mismatch returns error code >

Re: [Bug-wget] [PATCH 12/25] New test: --continue shall keep fully retrieved Metalink files (HTTP 416)

Hi Matthew, Matthew White writes: > [Coverity Scan is ok, make syntax-check is ok, make check-valgrind is ok, > contrib/check-hard is ok] > > This introduces a new Metalink test to verify that when --continue is used, > after a HTTP 416 answer a file that fails a

Re: [Bug-wget] [PATCH 10/25] New document: Metalink/XML and Metalink/HTTP standard reference

Matthew White writes: > [Coverity Scan is ok, make syntax-check is ok, make check-valgrind is ok, > contrib/check-hard is ok] > > This introduces the new document doc/metalink-standard.txt. > > The purpose of the document is to serve as a Metalink/XML and Metalink/HTTP

Re: [Bug-wget] [PATCH 08/25] Implement Metalink/XML --directory-prefix option in Metalink module

> + /* The directory prefix for opt.metalink_over_http is handled by > + src/url.c (url_file_name), do not add it a second time. */ > + if (!metalink->origin && opt.dir_prefix && strlen (opt.dir_prefix)) > +filename = aprintf("%s/%s", opt.dir_prefix, mfile->name);

Re: [Bug-wget] [PATCH 07/25] Change mfile->name to filename in Metalink module's messages

Hi Matthew, Matthew White writes: > From 0a41d7a593bf8b1be7231146af2b8bdf7755e4fa Mon Sep 17 00:00:00 2001 > From: Matthew White > Date: Tue, 16 Aug 2016 23:18:46 +0200 > Subject: [PATCH 07/25] Change mfile->name to filename in Metalink

Re: [Bug-wget] [PATCH 06/25] Add file size computation in Metalink module

Hi Matthew, Matthew White writes: > Matthew White > > From f9da9729d70d79ce245877672a2d611ca9c4667f Mon Sep 17 00:00:00 2001 > From: Matthew White > Date: Tue, 16 Aug 2016 23:12:56 +0200 > Subject: [PATCH 06/25] Add

Re: [Bug-wget] [PATCH 05/25] Update Metalink/XML tests and add a new test for home paths

Matthew White writes: > + same as before, can be just another test in the same file, not a complete new test file. Giuseppe

Re: [Bug-wget] [PATCH 04/25] Bugfix: Keep the download progress when alternating metalink:url

Matthew White writes: > From f9fc03c0788675275041d0876d3e7fffd3f50eee Mon Sep 17 00:00:00 2001 > From: Matthew White > Date: Thu, 4 Aug 2016 11:35:42 +0200 > Subject: [PATCH 04/25] Bugfix: Keep the download progress when alternating >

Re: [Bug-wget] [PATCH 03/25] Bugfix: Fix NULL filename and output_stream in Metalink module

Matthew White writes: > + */ > + if (!output_stream && (output_stream = fopen (filename, "rb"))) > +{ > + fclose (output_stream); > + output_stream = fopen (filename, "ab"); > +}

Re: [Bug-wget] [PATCH 02/25] Add metalink description

Hi Matthew, Matthew White writes: > Matthew White > > From 2a418049a0678f781ff03cecd4bde4ecfdffec2e Mon Sep 17 00:00:00 2001 > From: Matthew White > Date: Fri, 5 Aug 2016 20:10:19 +0200 > Subject: [PATCH 02/25] Add

Re: [Bug-wget] [PATCH 01/25] Add two Metalink/XML tests

Hi Matthew, thanks for all your work, I am going to comment on each patch separately: Matthew White writes: > index 000..041d772 > --- /dev/null > +++ b/testenv/Test-metalink-xml-relpath.py > @@ -0,0 +1,87 @@ > +#!/usr/bin/env python3 > +from sys import exit >