Re: [Bug-wget] Meet Wget maintainers at FOSDEM

2019-02-01 Thread Giuseppe Scrivano
I am going to be around, but in the containers room :-) I'll poke at you on Twitter. For anyone else, I am "@gscrivano" on Twitter and Telegram. Regards, Giuseppe Tim Rühsen writes: > Everybody who likes to meet me at FOSDEM is encouraged to do so ! > > DM me on Twitter via @ruehsen or ask

Re: [Bug-wget] Add support to bind to a local port

2018-05-03 Thread Giuseppe Scrivano
Hi, some minor comments: Darshit Shah writes: > +@cindex bind port > +@cindex client port number > +@cindex IP address, client, port > +@item --bind-port=@var{PORT} > +When making client TCP/IP connections using @samp{--bind-address}, > additionally > +bind to a specific

Re: [Bug-wget] Patch: Call WSACleanup for Windows when sockets finished

2017-11-28 Thread Giuseppe Scrivano
Hi Yuxi, "Yuxi Hao" writes: > +#ifdef WINDOWS > + ws_cleanup (); > +#endif > + >cleanup (); ws_cleanup is registered using an atexit callback. Have you observed any issue with it? Isn't that triggered? Giuseppe

Re: [Bug-wget] Wget1 Gzip Compression

2017-07-26 Thread Giuseppe Scrivano
Hi Tim, Tim Schlueter writes: > Hi, > > I was wondering if there is any interest here in adding gzip compression > support to wget1. > > I recently came across a misconfigured web server which would gzip all > responses regardless of the accept-encoding HTTP request

Re: [Bug-wget] [PATCH 3/3] Add command line option to disable use of .netrc

2017-05-16 Thread Giuseppe Scrivano
Tomas Hozza writes: > The option to turn off reading .netrc by configuration in .wgetrc is > still there. This command line option was supposed to be just > something extra. Anyway Tim already merged the change. Do you want to > revert it? Tim, are you in favor of this

Re: [Bug-wget] [PATCH 3/3] Add command line option to disable use of .netrc

2017-05-16 Thread Giuseppe Scrivano
Hi Tomas, Tomas Hozza writes: > If you don't want to add new option, maybe just documenting the possibility > to turn off reading of .netrc would be good enough. > > Please let me know what is your preference as I don't have one. I'd prefer if we just document how to turn

Re: [Bug-wget] [PATCH 3/3] Add command line option to disable use of .netrc

2017-05-12 Thread Giuseppe Scrivano
Hi Tomas, Tomas Hozza writes: > Although internally code uses option for (not) reading .netrc for > credentials, it was not possible to turn this behavior off on command > line. Note that it was possible to turn it off using wgetrc. > > Idea for this change came from Bruce

Re: [Bug-wget] Article explaining Wget in German computer magazin c't

2017-03-31 Thread Giuseppe Scrivano
Hi Tim, Tim Rühsen writes: > FYI, > > c't 8/2017 has a 4 paged article explaining Wget and several kinds of > usages (German language only). cool! Is there any online version of it? Regards, Giuseppe

Re: [Bug-wget] [PATCH] Add support for --retry-http503

2017-01-31 Thread Giuseppe Scrivano
Hi Tom, > Sure, that is entirely doable from a technical point of view. > > However, I have thought about this beforehand, and to me, 503 and 504 > were the only 5xx errors potentially worth retrying. All the others > signal fatal conditions. And Wget already retries 504 without any > patch.

Re: [Bug-wget] [PATCH] Add support for --retry-http503

2017-01-31 Thread Giuseppe Scrivano
Hi Tom, Tom Szilagyi writes: > Consider HTTP 503 (Service unavailable) as a non-fatal, transient > error. Normally Wget gives up immediately on receiving this HTTP > response. Certain special use cases might require Wget to retry even > in the face of this error. With

Re: [Bug-wget] Why does wget send all messages to stderr?

2017-01-25 Thread Giuseppe Scrivano
V for Vortex writes: > wget sends all messages to stderr, not just errors. Why is that? differently than what the name suggests, stderr is the destination for diagnostic messages not only errors, while stdout is where you get the expected output. In the case of wget,

Re: [Bug-wget] [PATCH v2 01/27] new Metalink functionalities

2016-10-03 Thread Giuseppe Scrivano
Tim Ruehsen writes: > @Giuseppe Please go ahead with merging. I've just pushed the series. Regards, Giuseppe

Re: [Bug-wget] [PATCH v2 01/27] new Metalink functionalities

2016-09-29 Thread Giuseppe Scrivano
Hi Matthew, Matthew White writes: > Series of patches to implement new Metalink functionalities. > > In response to Giuseppe > http://lists.gnu.org/archive/html/bug-wget/2016-09/msg00127.html , here you > find my revised series of patches. > > Posting with `git

Re: [Bug-wget] [PATCH 27/27] New: Metalink/XML v3 python class, update tests to use this class

2016-09-29 Thread Giuseppe Scrivano
Matthew White writes: > * NEWS: Mention the Metalink/XML v3 python class > * testenv/misc/metalinkv3_xml.py: New Metalink/XML v3 python class I think this should not be included. NEWS is for users to know what changed in a new release, we don't add internal changes.

Re: [Bug-wget] [PATCH 21/27] New option --metalink-index to process Metalink application/metalink4+xml

2016-09-29 Thread Giuseppe Scrivano
Hi Matthew, Matthew White writes: > diff --git a/src/init.c b/src/init.c > index 6729c5a..26f3886 100644 > --- a/src/init.c > +++ b/src/init.c > @@ -248,6 +248,7 @@ static const struct { >{ "login",_user, cmd_string },/* deprecated*/ >{

Re: [Bug-wget] [PATCH 25/25] New: --metalink-over-http Content-Type/Disposition Metalink/XML processing

2016-09-26 Thread Giuseppe Scrivano
Hi, Matthew White writes: >> Could you please re-send the updated series? > > You may find the series of patches in my branch > https://github.com/mehw/wget/tree/metalink_staging . it works for me, I will take a look soon at them. > > There's a new Metalink/XML v3

Re: [Bug-wget] bug #46584: wget --spider always returns zero exit status

2016-09-25 Thread Giuseppe Scrivano
Darshit Shah writes: > Apart from the patch format, the patch itself looks good. > > @Giuseppe: We will require Copyright assignments for Piotr right? This > patch may be small, but there are a couple others in the pipeline. yes, I think we will need that. The sum of all the

Re: [Bug-wget] [PATCH 25/25] New: --metalink-over-http Content-Type/Disposition Metalink/XML processing

2016-09-25 Thread Giuseppe Scrivano
Hi Matthew, Matthew White writes: > [Coverity Scan is ok, make syntax-check is ok, make check-valgrind is ok, > contrib/check-hard is ok] > > This implements the auto-processing of Metalink files part of a > "Content-Type: application/metalink4+xml" header answer. >

Re: [Bug-wget] [PATCH 20/25] New option --metalink-index to process Metalink application/metalink4+xml

2016-09-15 Thread Giuseppe Scrivano
Hi Matthew, Matthew White writes: >> > Function amended to modify *name in place. >> > >> > Followed Tim's suggestions for Patch 09/25 about different environments >> > compatibility, the function now uses last_component() to detect the >> > basename: >> >

Re: [Bug-wget] [PATCH 20/25] New option --metalink-index to process Metalink application/metalink4+xml

2016-09-14 Thread Giuseppe Scrivano
Hi Matthew, Matthew White <mehw.is...@inventati.org> writes: > On Sun, 11 Sep 2016 23:39:09 +0200 > Giuseppe Scrivano <gscriv...@gnu.org> wrote: > >> Hi Matthew, >> >> Matthew White <mehw.is...@inventati.org> writes: >> >> > +

Re: [Bug-wget] [PATCH 01/25] Add two Metalink/XML tests

2016-09-13 Thread Giuseppe Scrivano
Hi Matthew, Matthew White writes: > Next patches add more conditions to testenv/Test-metalink-xml-relpath.py. > > Also variants are introduced, like: > * testenv/Test-metalink-xml-trust.py > * testenv/Test-metalink-xml-homepath.py > *

Re: [Bug-wget] [PATCH 25/25] New: --metalink-over-http Content-Type/Disposition Metalink/XML processing

2016-09-11 Thread Giuseppe Scrivano
Matthew White writes: > From ec75cdd3f0e748523c64856f01b28128f806fb16 Mon Sep 17 00:00:00 2001 > From: Matthew White > Date: Mon, 29 Aug 2016 20:59:35 +0200 > Subject: [PATCH 25/25] New: --metalink-over-http Content-Type/Disposition >

Re: [Bug-wget] [PATCH 24/25] Bugfix: Set NULL variable due to --content-disposition to Metalink origin

2016-09-11 Thread Giuseppe Scrivano
> [Coverity Scan is ok, make syntax-check is ok, make check-valgrind is ok, > contrib/check-hard is ok] > > This solves a segmentation fault when local_file is not properly set, i.e. > due to the use of the option --content-disposition. > > The segmentation fault was generated trying to

Re: [Bug-wget] [PATCH 22/25] Bugfix: Detect when a metalink:file doesn't have any hash

2016-09-11 Thread Giuseppe Scrivano
Matthew White writes: > From 3555fe04ab1fc22c93d48f88584c7116d0356bb5 Mon Sep 17 00:00:00 2001 > From: Matthew White > Date: Sun, 28 Aug 2016 14:03:56 +0200 > Subject: [PATCH 22/25] Bugfix: Detect when a metalink:file doesn't have any > hash

Re: [Bug-wget] [PATCH 23/25] New: --trust-server-names saves Metalink/HTTP xml files using the "name" field

2016-09-11 Thread Giuseppe Scrivano
Hi Matthew, Matthew White writes: > [Coverity Scan is ok, make syntax-check is ok, make check-valgrind is ok, > contrib/check-hard is ok] > > This allows to use the value of the "name" field, part of a Metalink/HTTP > application/metalink4+xml Link, as file name for

Re: [Bug-wget] [PATCH 19/25] Bugfix: Prevent sorting of unallocated metalink resource/metaurl

2016-09-11 Thread Giuseppe Scrivano
Matthew White writes: > diff --git a/src/main.c b/src/main.c > index ac6ee2c..11ea86d 100644 > --- a/src/main.c > +++ b/src/main.c > @@ -2136,10 +2136,11 @@ only if outputting to a regular file.\n")); >for (mres_ptr = mfile->resources; *mres_ptr;

Re: [Bug-wget] [PATCH 19/25] Bugfix: Prevent sorting of unallocated metalink resource/metaurl

2016-09-11 Thread Giuseppe Scrivano
Matthew White writes: > From cbed79d8394c8c0a74b2f65cb92d01178184e5fe Mon Sep 17 00:00:00 2001 > From: Matthew White > Date: Thu, 25 Aug 2016 15:26:18 +0200 > Subject: [PATCH 19/25] Bugfix: Prevent sorting of unallocated metalink >

Re: [Bug-wget] [PATCH 18/25] New: Parse Metalink/HTTP header for application/metalink4+xml

2016-09-11 Thread Giuseppe Scrivano
Matthew White writes: > [Coverity Scan is ok, make syntax-check is ok, contrib/check-hard is ok] > > `make check-valgrind` fails the following metalink tests due to the bugs > which will be fixed in '[PATCH 19/25] Bugfix: Prevent sorting of unallocated > metalink

Re: [Bug-wget] [PATCH 17/25] New test: Metalink shall not concatenate '/' to an empty directory prefix

2016-09-11 Thread Giuseppe Scrivano
Hi Matthew, Matthew White writes: > Matthew White > > From 9f1492729e3771405b13b9375be45e76fdffad62 Mon Sep 17 00:00:00 2001 > From: Matthew White > Date: Sat, 27 Aug 2016 16:16:35 +0200 > Subject: [PATCH 17/25] New

Re: [Bug-wget] [PATCH 16/25] Bugfix: Remove surrounding quotes from Metalink/HTTP key's value

2016-09-11 Thread Giuseppe Scrivano
Matthew White writes: > +/* > + Remove the quotation surrounding a string. > + > + The string is permanently modified. > + */ > +void > +dequote_metalink_string (char **str) > +{ > + char *new, *beg, *end; > + size_t str_len, new_len; > + > + if (!str || !*str) > +

Re: [Bug-wget] [PATCH 15/25] Bugfix: Process Metalink/XML url strings containing white spaces and CRLF

2016-09-11 Thread Giuseppe Scrivano
Matthew White writes: > +void > +clean_metalink_string (char **str) > +{ > + int c; > + size_t len; > + char *new, *beg, *end; > + > + if (!str || !*str) > +return; > + > + beg = *str; > + > + while ((c = *beg) && (c == '\n' || c == '\r' || c == '\t' || c == '

Re: [Bug-wget] [PATCH 14/25] New test: Detect when there are no good Metalink url resources

2016-09-11 Thread Giuseppe Scrivano
Matthew White writes: > [Coverity Scan is ok, make syntax-check is ok, make check-valgrind is ok, > contrib/check-hard is ok] > > This adds a new Metalink test. > > The following description is verbatim from the patch: > - > Test if when there are no good Metalink

Re: [Bug-wget] [PATCH 13/25] New: Metalink file size mismatch returns error code METALINK_SIZE_ERROR

2016-09-11 Thread Giuseppe Scrivano
Matthew White writes: > From 448e3c06cd9589509cd3914a43fe4c7e93e9d622 Mon Sep 17 00:00:00 2001 > From: Matthew White > Date: Mon, 22 Aug 2016 09:13:52 +0200 > Subject: [PATCH 13/25] New: Metalink file size mismatch returns error code >

Re: [Bug-wget] [PATCH 12/25] New test: --continue shall keep fully retrieved Metalink files (HTTP 416)

2016-09-11 Thread Giuseppe Scrivano
Hi Matthew, Matthew White writes: > [Coverity Scan is ok, make syntax-check is ok, make check-valgrind is ok, > contrib/check-hard is ok] > > This introduces a new Metalink test to verify that when --continue is used, > after a HTTP 416 answer a file that fails a

Re: [Bug-wget] [PATCH 10/25] New document: Metalink/XML and Metalink/HTTP standard reference

2016-09-11 Thread Giuseppe Scrivano
Matthew White writes: > [Coverity Scan is ok, make syntax-check is ok, make check-valgrind is ok, > contrib/check-hard is ok] > > This introduces the new document doc/metalink-standard.txt. > > The purpose of the document is to serve as a Metalink/XML and Metalink/HTTP

Re: [Bug-wget] [PATCH 08/25] Implement Metalink/XML --directory-prefix option in Metalink module

2016-09-11 Thread Giuseppe Scrivano
> + /* The directory prefix for opt.metalink_over_http is handled by > + src/url.c (url_file_name), do not add it a second time. */ > + if (!metalink->origin && opt.dir_prefix && strlen (opt.dir_prefix)) > +filename = aprintf("%s/%s", opt.dir_prefix, mfile->name);

Re: [Bug-wget] [PATCH 07/25] Change mfile->name to filename in Metalink module's messages

2016-09-11 Thread Giuseppe Scrivano
Hi Matthew, Matthew White writes: > From 0a41d7a593bf8b1be7231146af2b8bdf7755e4fa Mon Sep 17 00:00:00 2001 > From: Matthew White > Date: Tue, 16 Aug 2016 23:18:46 +0200 > Subject: [PATCH 07/25] Change mfile->name to filename in Metalink

Re: [Bug-wget] [PATCH 06/25] Add file size computation in Metalink module

2016-09-11 Thread Giuseppe Scrivano
Hi Matthew, Matthew White writes: > Matthew White > > From f9da9729d70d79ce245877672a2d611ca9c4667f Mon Sep 17 00:00:00 2001 > From: Matthew White > Date: Tue, 16 Aug 2016 23:12:56 +0200 > Subject: [PATCH 06/25] Add

Re: [Bug-wget] [PATCH 05/25] Update Metalink/XML tests and add a new test for home paths

2016-09-11 Thread Giuseppe Scrivano
Matthew White writes: > + same as before, can be just another test in the same file, not a complete new test file. Giuseppe

Re: [Bug-wget] [PATCH 04/25] Bugfix: Keep the download progress when alternating metalink:url

2016-09-11 Thread Giuseppe Scrivano
Matthew White writes: > From f9fc03c0788675275041d0876d3e7fffd3f50eee Mon Sep 17 00:00:00 2001 > From: Matthew White > Date: Thu, 4 Aug 2016 11:35:42 +0200 > Subject: [PATCH 04/25] Bugfix: Keep the download progress when alternating >

Re: [Bug-wget] [PATCH 03/25] Bugfix: Fix NULL filename and output_stream in Metalink module

2016-09-11 Thread Giuseppe Scrivano
Matthew White writes: > + */ > + if (!output_stream && (output_stream = fopen (filename, "rb"))) > +{ > + fclose (output_stream); > + output_stream = fopen (filename, "ab"); > +}

Re: [Bug-wget] [PATCH 02/25] Add metalink description

2016-09-11 Thread Giuseppe Scrivano
Hi Matthew, Matthew White writes: > Matthew White > > From 2a418049a0678f781ff03cecd4bde4ecfdffec2e Mon Sep 17 00:00:00 2001 > From: Matthew White > Date: Fri, 5 Aug 2016 20:10:19 +0200 > Subject: [PATCH 02/25] Add

Re: [Bug-wget] [PATCH 01/25] Add two Metalink/XML tests

2016-09-11 Thread Giuseppe Scrivano
Hi Matthew, thanks for all your work, I am going to comment on each patch separately: Matthew White writes: > index 000..041d772 > --- /dev/null > +++ b/testenv/Test-metalink-xml-relpath.py > @@ -0,0 +1,87 @@ > +#!/usr/bin/env python3 > +from sys import exit >

Re: [Bug-wget] [PATCH] Patch to change behavior with redirects under --recurse.

2016-08-26 Thread Giuseppe Scrivano
Hi Dale, wor...@alum.mit.edu (Dale R. Worley) writes: > This is the change that I'm interested in. I don't expect this to be > put into the distribution without a lot of discussion. > > This version changes the behavior of --recurse: If a file is > downloaded, it will be scanned for links to

Re: [Bug-wget] Wget - acess list bypass / race condition PoC

2016-08-24 Thread Giuseppe Scrivano
Hi, Eli Zaretskii writes: >> #else /* def __VMS */ >> - *fp = fopen (hs->local_file, "wb"); >> + if (opt.delete_after >> +|| opt.spider /* opt.recursive is implicitely true */ >> +|| !acceptable (hs->local_file)) >> +{ >> +

Re: [Bug-wget] Wget - acess list bypass / race condition PoC

2016-08-21 Thread Giuseppe Scrivano
Hi Eli, Eli Zaretskii <e...@gnu.org> writes: >> From: Giuseppe Scrivano <gscriv...@gnu.org> >> Date: Sun, 21 Aug 2016 15:26:58 +0200 >> Cc: "bug-wget@gnu.org" <bug-wget@gnu.org>, >> Dawid Golunski <da...@legalhackers.com>, >>

Re: [Bug-wget] Wget - acess list bypass / race condition PoC

2016-08-21 Thread Giuseppe Scrivano
+|| opt.spider /* opt.recursive is implicitely true */ +|| !acceptable (hs->local_file)) +{ + *fp = fdopen (open (hs->local_file, O_CREAT | O_TRUNC | O_WRONLY, S_IRUSR | S_IWUSR), "wb"); +} + else +{ + *fp = fopen (

Re: [Bug-wget] Wget - acess list bypass / race condition PoC

2016-08-18 Thread Giuseppe Scrivano
Hi, Tim Rühsen writes: > Please review / test this patch. > > Please check the 'Reported-by' in the commit message and if you got a CVE > number, please report for inclusion into the commit message (and/or the code). > > Regards, Tim > > On Mittwoch, 17. August 2016

Re: [Bug-wget] [PATCH] Fix signal race condition

2016-08-09 Thread Giuseppe Scrivano
Hi Tobias, Tobias Stoeckmann writes: > - signal (SIGALRM, abort_run_with_timeout); >if (SETJMP (run_with_timeout_env) != 0) > { >/* Longjumped out of FUN with a timeout. */ >signal (SIGALRM, SIG_DFL); >return true; > } > + else > +

[Bug-wget] GNU wget 1.18 released

2016-06-09 Thread Giuseppe Scrivano
Hello, We are pleased to announce the new version of GNU wget. This version fixes a security vulnerability (CVE-2016-4971) present in all old versions of wget. The vulnerability was discovered by Dawid Golunski which were reported to us by Beyond Security's SecuriTeam. On a server redirect

Re: [Bug-wget] New test

2016-06-03 Thread Giuseppe Scrivano
Hi Tim, Tim Ruehsen writes: > functionality as your test and just pushed it. I mention you in the commit > message. what do you think if we rename tests -> old-tests and testenv -> tests? It will probably be clearer for contributors to not touch them. Regards, Giuseppe

Re: [Bug-wget] New test

2016-06-03 Thread Giuseppe Scrivano
Hi Zdenek, Zdenek Dohnal writes: > Hello, > > I was fixing a bug from old version of wget (1.12), which is fixed in newer > version wget, and I created script in perl to test it. > Script tests return value of "missing scheme" case. Do you want to add it > into your

Re: [Bug-wget] [PATCH] Fix python test suite

2016-04-09 Thread Giuseppe Scrivano
Hi Tim, Tim Ruehsen writes: > @@ -27,7 +28,7 @@ class BaseTest: > Define the class-wide variables (or attributes). > Attributes should not be defined outside __init__. > """ > -self.name = name > +self.name =

Re: [Bug-wget] [PATCH] Trivial changes in HSTS

2016-04-07 Thread Giuseppe Scrivano
Hi Juaristi, "Juaristi Álamos, Ander" writes: > - if (file_exists_p (filename)) > + if (file_exists_p (filename) && hsts_file_access_valid (filename)) can the file_exists_p check just be moved to hsts_file_access_valid that doesn't return an error on ENOENT? In

Re: [Bug-wget] [PATCH] Anyone want to add libcares support to wget?

2016-03-21 Thread Giuseppe Scrivano
Hi Tim, Tim Rühsen writes: > diff --git a/README.checkout b/README.checkout > index 3265c81..45c0585 100644 > --- a/README.checkout > +++ b/README.checkout > @@ -99,6 +99,9 @@ Compiling From Repository Sources > > * [47]GnuPG with GPGME is used to verify GPG-signed

Re: [Bug-wget] Anyone want to add libcares support to wget?

2016-03-19 Thread Giuseppe Scrivano
Hi Ben, Ben Greear writes: >> Did you consider using a container (e.g. docker) for such a task ? Easy to >> set >> up and you'll have your feature not only for wget. IMO, that is much more >> flexible. (It was Giuseppe's idea during a private talk). > > Containers will

Re: [Bug-wget] Anyone want to add libcares support to wget?

2016-03-19 Thread Giuseppe Scrivano
Hi Ben, Ben Greear writes: > wget can already bind to a local IP. It might be nice to add support for > SO_BINDTODEVICE, but not sure > it is required for what I need. > > The rest of your suggestions are total hacks! have you tried to run wget from a container?

[Bug-wget] [bug #46611] log errors with --trust-server-names

2016-03-19 Thread Giuseppe Scrivano
Follow-up Comment #8, bug #46611 (project wget): I think it is too risky to change this behavior now and for something that is not clear. Who knows how many scripts we are going to break with such a change. ___ Reply to this item at:

Re: [Bug-wget] Patch for understanding srcset= on img tags.

2016-03-03 Thread Giuseppe Scrivano
Maksim Orlovich writes: >> should the condition be (c == ')' && in_paren) ? > > Indeed. > > Thanks, > Maks Thanks for the changes, I am going to push it shortly. Regards, Giuseppe

Re: [Bug-wget] Google Summer of Code 2016

2016-03-01 Thread Giuseppe Scrivano
Kushagra Singh writes: > Hi, > > Will we be taking part in GSoC this year? I would really like to work on a > project related to Wget this summer. Any specific ideas that are of > importance to the community presently? yes, we will be take part in GSoC. I think

Re: [Bug-wget] Patch for understanding srcset= on img tags.

2016-03-01 Thread Giuseppe Scrivano
Hi Maksim, Maksim Orlovich writes: > Hi... wget currently doesn't understand HTML5's srcset= attribute on > images. The attached adds support for it. > This is under Google copyright, so should be covered by the company's > copyright assignment with the FSF. > > If you

Re: [Bug-wget] Support non-ASCII URLs

2016-01-12 Thread Giuseppe Scrivano
Eli Zaretskii <e...@gnu.org> writes: >> From: Tim Rühsen <tim.rueh...@gmx.de> >> Cc: Giuseppe Scrivano <gscriv...@gnu.org>, Eli Zaretskii <e...@gnu.org> >> Date: Fri, 18 Dec 2015 22:41:29 +0100 >> >> 1. Maybe do_conversion() should take a cha

Re: [Bug-wget] Support non-ASCII URLs

2016-01-12 Thread Giuseppe Scrivano
Eli Zaretskii writes: > This was fixed by Tim in the meantime. Are you running the current > Git version? sorry my mistake, I was using an outdated version. All works now for me as well. Regards, Giuseppe

Re: [Bug-wget] short option for --content-disposition (feature request)

2016-01-05 Thread Giuseppe Scrivano
Hanno Böck writes: > Hi, > > I quite often use the --content-disposition command line option of wget. > It's a bit annoying to type in, but currently it seems there is no > short option for it. > Could such a short option be added? > > c and d are already taken and I think also

Re: [Bug-wget] Support non-ASCII URLs

2015-12-18 Thread Giuseppe Scrivano
Tim Rühsen <tim.rueh...@gmx.de> writes: > Am Donnerstag, 17. Dezember 2015, 20:09:56 schrieb Eli Zaretskii: >> > From: Tim Ruehsen <tim.rueh...@gmx.de> >> > Cc: Giuseppe Scrivano <gscriv...@gnu.org> >> > Date: Thu, 17 Dec 2015 17:50:47 +0100

Re: [Bug-wget] Support non-ASCII URLs

2015-12-18 Thread Giuseppe Scrivano
Eli Zaretskii writes: > Attached. great, thanks! Tim, do you have any objections or can we push it? Regards, Giuseppe

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-17 Thread Giuseppe Scrivano
Tim Rühsen writes: >> but we can perhaps use this when flock is not available. > > Sounds like doing gnulib's job !? > > If flock() is not available, gnulib throws in it's flock() emulation. They > already check for flock and fcntl being available. Not sure, what problem >

Re: [Bug-wget] Support non-ASCII URLs

2015-12-17 Thread Giuseppe Scrivano
Hi Tim, thanks to have worked on this: Tim Ruehsen writes: > diff --git a/src/iri.c b/src/iri.c > index 6c6e8d3..354bfd9 100644 > --- a/src/iri.c > +++ b/src/iri.c > @@ -180,16 +180,10 @@ do_conversion (const char *tocode, const char > *fromcode, char const *in_org, siz >

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-16 Thread Giuseppe Scrivano
Tim Ruehsen <tim.rueh...@gmx.de> writes: > On Wednesday 16 December 2015 10:31:33 Giuseppe Scrivano wrote: >> Tim Ruehsen <tim.rueh...@gmx.de> writes: >> > On Tuesday 15 December 2015 21:55:53 Kiyoshi KANAZAWA wrote: >> >> 2. about #error "Com

Re: [Bug-wget] Marking Release v1.17.1?

2015-12-16 Thread Giuseppe Scrivano
Eli Zaretskii <e...@gnu.org> writes: >> From: Giuseppe Scrivano <gscriv...@gnu.org> >> Cc: Gisle Vanem <gva...@yahoo.no>, bug-wget@gnu.org >> Date: Wed, 16 Dec 2015 10:34:12 +0100 >> >> do you mind to send it in the git am format with a ChangeLo

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-16 Thread Giuseppe Scrivano
Tim Ruehsen writes: > On Tuesday 15 December 2015 21:55:53 Kiyoshi KANAZAWA wrote: >> 2. about #error "Compiler or options invalid for pre-UNIX 03 X/Open >> applications" This error may depends on compilers. >> Both of "solarisstudio12.4" & "gcc-4.8.5" can build

Re: [Bug-wget] Marking Release v1.17.1?

2015-12-16 Thread Giuseppe Scrivano
Eli Zaretskii writes: > If we call fd_close here with a socket that failed to connect, wget > hangs inside Gnulib's close_fd_maybe_socket, waiting for > WSAEnumNetworkEvents that never returns. Why it never returns, I > don't know, but I suspect that a failed connection and a

Re: [Bug-wget] Support non-ASCII URLs

2015-12-16 Thread Giuseppe Scrivano
Hi Eli, thanks for working on it, I have a few questions: Eli Zaretskii writes: > This second part is the main part of the change. It uses 'iconv', > when available, to convert the file names to the local encoding, > before saving the files. Note that the same function I

Re: [Bug-wget] Marking Release v1.17.1?

2015-12-11 Thread Giuseppe Scrivano
Jernej Simončič writes: > On Tuesday, December 8, 2015, 21:45:31, Darshit Shah wrote: > >> With my last set of patches, we have fixed all the issues reported / >> identified >> after the 1.17 release. Hence, maybe we should consider releasing a 1.17.1 >> bugfix

[Bug-wget] GNU wget 1.17.1 released

2015-12-11 Thread Giuseppe Scrivano
Hello, I am pleased to announce the new version of GNU wget. We consider it a bug fixes release as it addresses issues found in 1.17, which contained quite a few new features. It is available for download here: ftp://ftp.gnu.org/gnu/wget/wget-1.17.1.tar.gz

Re: [Bug-wget] --no-check-cert does not avoid cert warning

2015-12-10 Thread Giuseppe Scrivano
Ángel González <keis...@gmail.com> writes: > Giuseppe Scrivano wrote: >> Hi Ángel, >> >> >> thanks for the suggestion, it looks fine to me. I already pushed the >> patch, could you prepare a new one that adds this part? >> >> Regards, >> G

Re: [Bug-wget] Fixing progress bar assertions in multibyte locales

2015-12-09 Thread Giuseppe Scrivano
Darshit Shah writes: > Hi everyone, > > As mentioned earlier, there was a bug in the progress bar > implementation that caused the tests in multi-byte and multi-column > locales to fail. I've rectified the issue by re-working each part of > the progress bar to ensure that they

Re: [Bug-wget] Marking Release v1.17.1?

2015-12-08 Thread Giuseppe Scrivano
Darshit Shah writes: > With my last set of patches, we have fixed all the issues reported / > identified after the 1.17 release. Hence, maybe we should consider > releasing a 1.17.1 bugfix release? yes, we should do that. I can tag a new release tomorrow or on Friday.

Re: [Bug-wget] --no-check-cert does not avoid cert warning

2015-12-03 Thread Giuseppe Scrivano
Hi Karl, Karl Berry writes: > the right thing to do is to listen to the Tim's opinion, > > Sure. I meant no disrespect! Everything he said was perfectly > reasonable, just insufficient for my purposes :). (Thanks Tim.) > > since he is one of the

Re: [Bug-wget] metalink for wget releases & tests

2015-12-03 Thread Giuseppe Scrivano
Darshit Shah writes: > From 2d440d5b4f9abeb84d17fc5474d0102f2fffbcc3 Mon Sep 17 00:00:00 2001 > From: Darshit Shah > Date: Thu, 3 Dec 2015 10:49:37 +0100 > Subject: [PATCH] Include Metalink and GPG information in version > > * src/build_info.c.in: Include the

Re: [Bug-wget] --no-check-cert does not avoid cert warning

2015-12-02 Thread Giuseppe Scrivano
Hi Karl, Karl Berry writes: > { wget -d xxx 2>&1 1>&3 | grep -v Saving 1>&2; } 3>&1 > > This changes the exit value, so that's no good. Sure, with even more > complexity the exit status could be preserved too, but IMHO wrapping > wget in layers of shell mechanisms to

Re: [Bug-wget] --no-check-cert does not avoid cert warning

2015-12-01 Thread Giuseppe Scrivano
Ángel González writes: > On 30/11/15 22:33, Tim Rühsen wrote: >> There is the situation where --no-check-cert is implicitly set (.wgetrc, >> /etc/wgetrc, alias) and the user isn't aware of it. Just downloading without >> a >> warning opens a huge security hole because you

Re: [Bug-wget] --no-check-cert does not avoid cert warning

2015-11-30 Thread Giuseppe Scrivano
Hi Karl, Karl Berry writes: > With wget 1.17 (at least), > > $ wget -nv --no-check-cert https://www.gnu.org -O /dev/null > WARNING: cannot verify www.gnu.org's certificate, issued by 'CN=Gandi > Standard SSL CA 2,O=Gandi,L=Paris,ST=Paris,C=FR': > Unable to locally

[Bug-wget] [bug #46479] null pointer dereference: gnutls_free (ctx->session_data->data)

2015-11-20 Thread Giuseppe Scrivano
Update of bug #46479 (project wget): Open/Closed:Open => Closed ___ Follow-up Comment #2: thanks, the patch looks correct and I pushed it.

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

2015-11-17 Thread Giuseppe Scrivano
Darshit Shah writes: > I think it's because flock isn't implemented in Windows. The ideal > solution would be to use some WIN32 API to get it done. However, I saw > that gnulib actually provides an implementation of flock that can be > used on Windows. > Hence, maybe just using

[Bug-wget] GNU wget 1.17 released

2015-11-16 Thread Giuseppe Scrivano
Hello, I am pleased to announce the new version of GNU wget. It is available for download here: ftp://ftp.gnu.org/gnu/wget/wget-1.17.tar.gz ftp://ftp.gnu.org/gnu/wget/wget-1.17.tar.xz and the GPG detached signatures using the key E163E1EA: ftp://ftp.gnu.org/gnu/wget/wget-1.17.tar.gz.sig

Re: [Bug-wget] Cygwin

2015-11-13 Thread Giuseppe Scrivano
Jim Macaulay writes: > I am using Cygwin . If i use wget command i am getting and error as , > > wget http://google.co.in/ > --2015-11-13 14:04:35-- http://google.co.in/ > Resolving google.co.in (google.co.in)... 216.58.196.163, > 2404:6800:4003:809::2003 > Connecting

[Bug-wget] [bug #46061] wget https://contributors.debian.org fails with "No data received."

2015-09-28 Thread Giuseppe Scrivano
Follow-up Comment #3, bug #46061 (project wget): Good analysis Tim! I have attacheda patch that solves the problem for me (file #35002) ___ Additional Item Attachment: File name: 0001-gnutls-honor-error-GNUTLS_E_REHANDSHAKE.patch Size:4

Re: [Bug-wget] [PATCH] [bug #46061] wget https://contributors.debian.org fails with "No data received."

2015-09-28 Thread Giuseppe Scrivano
Tim Ruehsen writes: > Please review / test this patch. we basically wrote the same patch :) It looks fine to me, just please add a space in the function calls: "_do_handshake(" -> "_do_handshake (" and feel free to push it. Regards, Giuseppe

Re: [Bug-wget] [PATCH] [bug #46061] wget https://contributors.debian.org fails with "No data received."

2015-09-28 Thread Giuseppe Scrivano
Tim Ruehsen writes: > Please review / test this patch. > > BTW, I am not sure if contributors.debian.org is configured correctly. > The rehandshake occurs right after the HTTP request and it has a pretty heavy > > impact on download duration. > > Regards, Tim > > On Sunday

Re: [Bug-wget] [PATCH] [bug #46061] wget https://contributors.debian.org fails with "No data received."

2015-09-28 Thread Giuseppe Scrivano
Tim Ruehsen writes: > wgnutls_write is called without timeout. So, what can we do here ? > > But maybe we don't have to check for GNUTLS_E_REHANDSHAKE at this point at > all. Regarding > http://www.gnutls.org/manual/html_node/Re_002dauthentication.html, only >

Re: [Bug-wget] [GSoC 2015] Basic HTTP/2 support

2015-08-26 Thread Giuseppe Scrivano
Daniel Stenberg dan...@haxx.se writes: On Thu, 30 Apr 2015, Daniel Stenberg wrote: Did anything happen with this project? As far I know, nothing happened with it, but maybe Miquel has more details about it. Regards, Giuseppe

Re: [Bug-wget] [bug #45790] wget prints it's progress even when background

2015-08-18 Thread Giuseppe Scrivano
Darshit Shah dar...@gmail.com writes: This affects an invokation using the shell's background operator () too. E.g.: wget http://cdimage.debian.org/debian-cd/current/multi-arch/iso-cd/debian-8.1.0-amd64-i386-netinst.iso will cause the logging output and progress bar to be displayed on the

Re: [Bug-wget] FTP PORT command code in v1.16.3?

2015-08-11 Thread Giuseppe Scrivano
Tim Ruehsen tim.rueh...@gmx.de writes: From d8d545994be399705c483ea924e71c3e6348d99d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim=20R=C3=BChsen?= tim.rueh...@gmx.de Date: Tue, 11 Aug 2015 16:48:08 +0200 Subject: [PATCH] Fix IP address exposure in FTP code * src/ftp.c (getftp): Do not use

Re: [Bug-wget] FTP PORT command code in v1.16.3?

2015-08-11 Thread Giuseppe Scrivano
Tim Ruehsen tim.rueh...@gmx.de writes: On Tuesday 11 August 2015 17:24:42 Giuseppe Scrivano wrote: Tim Ruehsen tim.rueh...@gmx.de writes: * src/ftp.c (getftp): Do not use PORT when PASV fails. * tests/FTPServer.px: Add pasv_not_supported server flag. * tests/Makefile.am: Add Test-ftp-pasv

Re: [Bug-wget] [PATCH 2/2] Rewrite the --rejected-log test using the new framework.

2015-08-07 Thread Giuseppe Scrivano
Jookia 166...@gmail.com writes: * tests/Test--rejected-log.px: Remove old test. * testenv/Test--rejected-log.py: Create new test. --- testenv/Makefile.am | 1 + testenv/Test--rejected-log.py | 104 +++ tests/Makefile.am | 1 -

Re: [Bug-wget] [PATCH] Add option to write URL rejections to a tab-delimited CSV log.

2015-08-06 Thread Giuseppe Scrivano
Jookia 166...@gmail.com writes: * main.c: Add --rejected-log option. * init.c: Add rejectedlog command. * options.h: Add rejected_log parameter string. * wget.texi: Add brief documentation on new --rejected-log option. * recur.c: Optionally log details of URLs not traversed. Add

Re: [Bug-wget] [PATCH] rejected-log: Add option to dump URL rejections to a log.

2015-07-27 Thread Giuseppe Scrivano
Jookia 166...@gmail.com writes: This allows you to figure out why URLs are being rejected and some context around it. --- doc/wget.texi | 5 ++ src/init.c| 2 + src/main.c| 3 ++ src/options.h | 2 + src/recur.c | 149

Re: [Bug-wget] [bug #20398] Save a list of the links that were not followed

2015-07-21 Thread Giuseppe Scrivano
Jookia 166...@gmail.com writes: On Mon, Jul 20, 2015 at 09:31:45AM +0200, Giuseppe Scrivano wrote: Jookia 166...@gmail.com writes: Hello again! A few days ago I was informed that my assignment letter was received by the FSF. Is it possible to move forward with this patch now

Re: [Bug-wget] [bug #20398] Save a list of the links that were not followed

2015-07-20 Thread Giuseppe Scrivano
Jookia 166...@gmail.com writes: Hello again! A few days ago I was informed that my assignment letter was received by the FSF. Is it possible to move forward with this patch now that any work I create for Wget can be legally included? I'm happy to make modifications as needed. could you

  1   2   3   4   5   6   7   8   >