Re: [Bug-wget] [PATCH] UTF-8-ify contributors' names in wget.texi (#40472)

2015-03-17 Thread Giuseppe Scrivano
Rohan Prinja rohan.pri...@gmail.com writes:

 Yes, I encountered it, sorry for not checking first.

 Turns out some more changes were required. Attached is a new patch
 that also touches doc/texi2pod.pl and doc/Makefile.am, and builds
 without errors. I commit-amended before creating this patch instead of
 creating a new commit, I hope that was the right thing to do.

yes, I've tweaked the commit message to include the changes to
Makefile.am and pushed your patch.

Congratulations on your first contribution!

Giuseppe



Re: [Bug-wget] [PATCH] UTF-8-ify contributors' names in wget.texi (#40472)

2015-03-17 Thread Rohan Prinja
Thank you :)

On 17 March 2015 at 14:23, Giuseppe Scrivano gscriv...@gnu.org wrote:
 Rohan Prinja rohan.pri...@gmail.com writes:

 Yes, I encountered it, sorry for not checking first.

 Turns out some more changes were required. Attached is a new patch
 that also touches doc/texi2pod.pl and doc/Makefile.am, and builds
 without errors. I commit-amended before creating this patch instead of
 creating a new commit, I hope that was the right thing to do.

 yes, I've tweaked the commit message to include the changes to
 Makefile.am and pushed your patch.

 Congratulations on your first contribution!

 Giuseppe



Re: [Bug-wget] [PATCH] UTF-8-ify contributors' names in wget.texi (#40472)

2015-03-16 Thread Giuseppe Scrivano
Rohan Prinja rohan.pri...@gmail.com writes:

 Updated patch file, this time using git-diff.

 On 15 March 2015 at 10:15, Rohan Prinja rohan.pri...@gmail.com wrote:
 Hi everyone,

 This is my first time submitting a patch (I'm used to contributing to
 projects via Github) so I hope I'm not making any mistakes. Attached
 is a patch for bug #40472: https://savannah.gnu.org/bugs/?40472. PTAL,
 thank you.

thanks for your contribution.  Could you please send it using the git
format-patch output.

You can do like:

git format-patch HEAD~1

and attach the outputted file to the email.  Please add a commit message
that is formatted using the GNU ChangeLog style.  In your case it could
simple be one like as * doc/wget.texi: convert to UTF-8

Regards,
Giuseppe



Re: [Bug-wget] [PATCH] UTF-8-ify contributors' names in wget.texi (#40472)

2015-03-16 Thread Petr Pisar
On Mon, Mar 16, 2015 at 07:55:47PM +0100, Giuseppe Scrivano wrote:
 ./texi2pod.pl -D VERSION=1.16.3.6-b74a-dirty ./wget.texi wget.pod
 /usr/bin/pod2man --center=GNU Wget --release=GNU Wget 1.16.3.6-b74a-dirty 
 wget.pod  wget.1
 Wide character in printf at /usr/share/perl5/vendor_perl/Pod/Simple.pm line 
 541.
 wget.pod around line 2395: Non-ASCII character seen before =encoding in 
 'Nikšić'. Assuming UTF-8
 POD document had syntax errors at /usr/bin/pod2man line 69.
 
A year or so, podlators require to specify POD encoding if the POD is not
ASCII or ISO-8859-1. Future versions will default to CP1251. I recommend to
write:

=encoding utf8

above first POD line.

Also for some time, podlators have pretty verbose diagnosis and complains on
things which older versions did not complain. The actuall output depends on
how old your perl or CPAN installation is.

-- Petr


signature.asc
Description: PGP signature


Re: [Bug-wget] [PATCH] UTF-8-ify contributors' names in wget.texi (#40472)

2015-03-16 Thread Giuseppe Scrivano
Rohan Prinja rohan.pri...@gmail.com writes:

 Done, thank you for the pointers.

I get this problem now when I run make:

./texi2pod.pl -D VERSION=1.16.3.6-b74a-dirty ./wget.texi wget.pod
/usr/bin/pod2man --center=GNU Wget --release=GNU Wget 1.16.3.6-b74a-dirty 
wget.pod  wget.1
Wide character in printf at /usr/share/perl5/vendor_perl/Pod/Simple.pm line 541.
wget.pod around line 2395: Non-ASCII character seen before =encoding in 
'Nikšić'. Assuming UTF-8
POD document had syntax errors at /usr/bin/pod2man line 69.

Have you encountered it?

Thanks,
Giuseppe



Re: [Bug-wget] [PATCH] UTF-8-ify contributors' names in wget.texi (#40472)

2015-03-15 Thread Rohan Prinja
Updated patch file, this time using git-diff.

On 15 March 2015 at 10:15, Rohan Prinja rohan.pri...@gmail.com wrote:
 Hi everyone,

 This is my first time submitting a patch (I'm used to contributing to
 projects via Github) so I hope I'm not making any mistakes. Attached
 is a patch for bug #40472: https://savannah.gnu.org/bugs/?40472. PTAL,
 thank you.

 Regards,
 Rohan



-- 
Rohan Prinja
Fourth Year, CS Undergrad
IIT Bombay
diff --git a/doc/wget.texi b/doc/wget.texi
index 5a214cf..73ffa6d 100644
--- a/doc/wget.texi
+++ b/doc/wget.texi
@@ -2,6 +2,7 @@
 
 @c %**start of header
 @setfilename wget.info
+@documentencoding UTF-8
 @include version.texi
 @settitle GNU Wget @value{VERSION} Manual
 @c Disable the monstrous rectangles beside overfull hbox-es.
@@ -59,11 +60,11 @@ Texts.  A copy of the license is included in the section entitled
 @title GNU Wget @value{VERSION}
 @subtitle The non-interactive download utility
 @subtitle Updated for Wget @value{VERSION}, @value{UPDATED}
-@author by Hrvoje Nik@v{s}i@'{c} and others
+@author by Hrvoje Nikšić and others
 
 @ignore
 @c man begin AUTHOR
-Originally written by Hrvoje Niksic hnik...@xemacs.org.
+Originally written by Hrvoje Nikšić hnik...@xemacs.org.
 @c man end
 @c man begin SEEALSO
 This is @strong{not} the complete manual for GNU Wget.
@@ -4101,12 +4102,7 @@ me).
 @section Contributors
 @cindex contributors
 
-@iftex
-GNU Wget was written by Hrvoje Nik@v{s}i@'{c} @email{hniksic@@xemacs.org},
-@end iftex
-@ifnottex
-GNU Wget was written by Hrvoje Niksic @email{hniksic@@xemacs.org}.
-@end ifnottex
+GNU Wget was written by Hrvoje Nikšić @email{hniksic@@xemacs.org},
 
 However, the development of Wget could never have gone as far as it has, were
 it not for the help of many people, either with bug reports, feature proposals,
@@ -4146,14 +4142,8 @@ portability fixes.
 Gordon Matzigkeit---@file{.netrc} support.
 
 @item
-@iftex
-Zlatko @v{C}alu@v{s}i@'{c}, Tomislav Vujec and Dra@v{z}en
-Ka@v{c}ar---feature suggestions and ``philosophical'' discussions.
-@end iftex
-@ifnottex
-Zlatko Calusic, Tomislav Vujec and Drazen Kacar---feature suggestions
-and ``philosophical'' discussions.
-@end ifnottex
+Zlatko Čalušić, Tomislav Vujec and Dražen
+Kačar---feature suggestions and ``philosophical'' discussions.
 
 @item
 Darko Budor---initial port to Windows.
@@ -4163,21 +4153,11 @@ Antonio Rosella---help and suggestions, plus the initial Italian
 translation.
 
 @item
-@iftex
-Tomislav Petrovi@'{c}, Mario Miko@v{c}evi@'{c}---many bug reports and
+Tomislav Petrović, Mario Mikočević---many bug reports and
 suggestions.
-@end iftex
-@ifnottex
-Tomislav Petrovic, Mario Mikocevic---many bug reports and suggestions.
-@end ifnottex
 
 @item
-@iftex
-Fran@,{c}ois Pinard---many thorough bug reports and discussions.
-@end iftex
-@ifnottex
-Francois Pinard---many thorough bug reports and discussions.
-@end ifnottex
+François Pinard---many thorough bug reports and discussions.
 
 @item
 Karl Eichwalder---lots of help with internationalization, Makefile
@@ -4240,12 +4220,7 @@ Wanderlei Cavassin,
 Gilles Cedoc,
 Tim Charron,
 Noel Cragg,
-@iftex
-Kristijan @v{C}onka@v{s},
-@end iftex
-@ifnottex
-Kristijan Conkas,
-@end ifnottex
+Kristijan Čonkaš,
 John Daily,
 Andreas Damm,
 Ahmon Dancy,
@@ -4255,27 +4230,12 @@ Alexander Dergachev,
 Andrew Deryabin,
 Ulrich Drepper,
 Marc Duponcheel,
-@iftex
-Damir D@v{z}eko,
-@end iftex
-@ifnottex
-Damir Dzeko,
-@end ifnottex
+Damir Džeko,
 Alan Eldridge,
 Hans-Andreas Engel,
-@iftex
-Aleksandar Erkalovi@'{c},
-@end iftex
-@ifnottex
-Aleksandar Erkalovic,
-@end ifnottex
+Aleksandar Erkalović,
 Andy Eskilsson,
-@iftex
-Jo@~{a}o Ferreira,
-@end iftex
-@ifnottex
-Joao Ferreira,
-@end ifnottex
+João Ferreira,
 Christian Fraenkel,
 David Fritz,
 Mike Frysinger,
@@ -4300,25 +4260,10 @@ Richard Huveneers,
 Jonas Jensen,
 Larry Jones,
 Simon Josefsson,
-@iftex
-Mario Juri@'{c},
-@end iftex
-@ifnottex
-Mario Juric,
-@end ifnottex
-@iftex
-Hack Kampbj@o rn,
-@end iftex
-@ifnottex
-Hack Kampbjorn,
-@end ifnottex
+Mario Jurić,
+Hack Kampbjørn,
 Const Kaplinsky,
-@iftex
-Goran Kezunovi@'{c},
-@end iftex
-@ifnottex
-Goran Kezunovic,
-@end ifnottex
+Goran Kezunović,
 Igor Khristophorov,
 Robert Kleine,
 KOJIMA Haime,
@@ -4327,31 +4272,14 @@ Alexander Kourakos,
 Martin Kraemer,
 Sami Krank,
 Jay Krell,
-@tex
-$\Sigma\acute{\iota}\mu o\varsigma\;
-\Xi\varepsilon\nu\iota\tau\acute{\epsilon}\lambda\lambda\eta\varsigma$
-(Simos KSenitellis),
-@end tex
-@ifnottex
-Simos KSenitellis,
-@end ifnottex
+Σίμος Ξενιτέλλης (Simos KSenitellis),
 Christian Lackas,
 Hrvoje Lacko,
 Daniel S.@: Lewart,
-@iftex
-Nicol@'{a}s Lichtmeier,
-@end iftex
-@ifnottex
-Nicolas Lichtmeier,
-@end ifnottex
+Nicolás Lichtmeier,
 Dave Love,
 Alexander V.@: Lukyanov,
-@iftex
-Thomas Lu@ss{}nig,
-@end iftex
-@ifnottex
-Thomas Lussnig,
-@end ifnottex
+Thomas Lußnig,
 Andre Majorel,
 Aurelien Marchand,
 Matthew J.@: Mellon,
@@ -4372,31 +4300,15 @@ Leonid Petrov,
 Simone Piunno,
 Andrew Pollock,
 Steve