Re: [Bug-wget] [Bug-Wget][BUG] Progress bar does not support multibyte characters

2014-09-18 Thread Giuseppe Scrivano
Darshit Shah writes: > Any updates? > > I'll push this patch if there are no objections. sorry for the delay, the patch looks fine, feel free to push it. Thanks, Giuseppe

Re: [Bug-wget] [Bug-Wget][BUG] Progress bar does not support multibyte characters

2014-09-18 Thread Darshit Shah
Any updates? I'll push this patch if there are no objections. On Sun, Sep 14, 2014 at 4:27 PM, Darshit Shah wrote: > I've fixed a couple of corner cases that were left out in the > refactoring and also changed the variables to better reflect their > purpose. > > I urge everyone to please try out

Re: [Bug-wget] [Bug-Wget][BUG] Progress bar does not support multibyte characters

2014-09-14 Thread Darshit Shah
I've fixed a couple of corner cases that were left out in the refactoring and also changed the variables to better reflect their purpose. I urge everyone to please try out this patch so that we can merge it into master ASAP. On Fri, Sep 12, 2014 at 3:50 PM, Darshit Shah wrote: > I managed to hac

Re: [Bug-wget] [Bug-Wget][BUG] Progress bar does not support multibyte characters

2014-09-14 Thread Darshit Shah
I've fixed a couple of corner cases that were left out in the refactoring and also changed the variables to better reflect their purpose. I urge everyone to please try out this patch so that we can merge it into master ASAP. On Fri, Sep 12, 2014 at 3:50 PM, Darshit Shah wrote: > I managed to hac

Re: [Bug-wget] [Bug-Wget][BUG] Progress bar does not support multibyte characters

2014-09-12 Thread Darshit Shah
I managed to hack together a fix for the issue. It wasn't as straightforward as I was expecting it to be. I've attached a preliminary version of the patch here for a review. Please review the patch and test it out to ensure that it works correctly. I'll clean up the variable names and write the re

Re: [Bug-wget] [Bug-Wget][BUG] Progress bar does not support multibyte characters

2014-09-04 Thread Giuseppe Scrivano
Darshit Shah writes: > Yes, I guess I'm looking for UTF-8 strings, because other character > encodings wouldn't create this problem, (I think?) > I'll look at the Wiki page again and see of GNULib has anything, Right > now, I'm trying to implement a solution based on wide characters > through wch

Re: [Bug-wget] [Bug-Wget][BUG] Progress bar does not support multibyte characters

2014-08-30 Thread Darshit Shah
On Sat, Aug 30, 2014 at 9:57 PM, Tim Rühsen wrote: > Am Samstag, 30. August 2014, 09:23:08 schrieb Darshit Shah: >> Earlier this year, I implemented a new, more concise form of the >> progress bar. However, I've just been given a bug report regarding the >> same, which I was unable to fix. >> >> T

Re: [Bug-wget] [Bug-Wget][BUG] Progress bar does not support multibyte characters

2014-08-30 Thread Tim Rühsen
Am Samstag, 30. August 2014, 09:23:08 schrieb Darshit Shah: > Earlier this year, I implemented a new, more concise form of the > progress bar. However, I've just been given a bug report regarding the > same, which I was unable to fix. > > The currently implemented progress bar shows only upto 15 c

[Bug-wget] [Bug-Wget][BUG] Progress bar does not support multibyte characters

2014-08-29 Thread Darshit Shah
Earlier this year, I implemented a new, more concise form of the progress bar. However, I've just been given a bug report regarding the same, which I was unable to fix. The currently implemented progress bar shows only upto 15 characters of the URL. In case of longer URLs, we scroll the filename l