Re: [Bug-wget] [Bug-Wget] Use of maltipart/form-data when using body-file command

2013-04-16 Thread Daniel Stenberg
On Tue, 16 Apr 2013, Tim Ruehsen wrote: The boundary string Giuseppe mentioned isn't really such a big deal if you ask me. You can easily make it in the same style as the browsers do it (a - prefix and a series of random letters) and if you like curl use 12 random hex letters it still

Re: [Bug-wget] [Bug-Wget] Use of maltipart/form-data when using body-file command

2013-04-16 Thread Tim Ruehsen
Am Tuesday 16 April 2013 schrieb Daniel Stenberg: > On Sun, 14 Apr 2013, Tim Rühsen wrote: > >> I wanted to propose that we use Content-Type: multipart/form-data and > >> send the whole file as-is when using the --body-file option. This > >> allows us to add the long missing functionality to send f

Re: [Bug-wget] [Bug-Wget] Use of maltipart/form-data when using body-file command

2013-04-15 Thread Daniel Stenberg
On Sun, 14 Apr 2013, Tim Rühsen wrote: I wanted to propose that we use Content-Type: multipart/form-data and send the whole file as-is when using the --body-file option. This allows us to add the long missing functionality to send files as attachments through wget, without having to change the

Re: [Bug-wget] [Bug-Wget] Use of maltipart/form-data when using body-file command

2013-04-14 Thread Tim Rühsen
Am Sonntag, 14. April 2013 schrieb Darshit Shah: > Assuming that my previous patch adding --method, --body-file and > --body-data options is accepted and merged into master, > I wanted to propose that we use Content-Type: multipart/form-data and send > the whole file as-is when using the --body-fil

Re: [Bug-wget] [Bug-Wget] Use of maltipart/form-data when using body-file command

2013-04-14 Thread Darshit Shah
> > I don't think this is a good idea. It will create confusion, I prefer > them to work exactly in the same way so one day we can drop the --post-* > commands. > > Okay, in that case, we could have a new command, something like: --body-attach to signify an attached file. I was more thinking of h

Re: [Bug-wget] [Bug-Wget] Use of maltipart/form-data when using body-file command

2013-04-14 Thread Giuseppe Scrivano
Darshit Shah writes: > this change will break backward compatibility, we need a new option for > that and leave the default unchanged. > > I am not suggesting that we change the working of --post-file and --post-data > commands. Unlike the patch I just submitted, we could could de-couple

Re: [Bug-wget] [Bug-Wget] Use of maltipart/form-data when using body-file command

2013-04-14 Thread Darshit Shah
> this change will break backward compatibility, we need a new option for > that and leave the default unchanged. > Why will it break backward compatibility? The --method option has just been pushed, not released as yet. As long as we implement this before the next release of Wget, I don't see why

Re: [Bug-wget] [Bug-Wget] Use of maltipart/form-data when using body-file command

2013-04-14 Thread Giuseppe Scrivano
Darshit Shah writes: > Assuming that my previous patch adding --method, --body-file and > --body-data options is accepted and merged into master, > I wanted to propose that we use Content-Type: multipart/form-data and send > the whole file as-is when using the --body-file option. > This allows us

[Bug-wget] [Bug-Wget] Use of maltipart/form-data when using body-file command

2013-04-13 Thread Darshit Shah
Assuming that my previous patch adding --method, --body-file and --body-data options is accepted and merged into master, I wanted to propose that we use Content-Type: multipart/form-data and send the whole file as-is when using the --body-file option. This allows us to add the long missing function