Re: [Bug-wget] Disable assertions by default

2014-11-22 Thread Tim Rühsen
Am Samstag, 22. November 2014, 09:55:23 schrieb Darshit Shah: On 11/21, Tim Rühsen wrote: Let's get this patch through first and others to handle the old assertions can flow in over the next week. Yes, looks good to me. Go push it. More comments below. Tim On Friday 21 November

Re: [Bug-wget] Disable assertions by default

2014-11-21 Thread Tim Ruehsen
On Friday 21 November 2014 13:19:18 Darshit Shah wrote: On 11/20, Ángel González wrote: On 20/11/14 15:29, Darshit Shah wrote: --- a/src/progress.c +++ b/src/progress.c @@ -992,6 +992,7 @@ create_image (struct bar_progress *bp, double dl_total_time, bool done) { int

Re: [Bug-wget] Disable assertions by default

2014-11-21 Thread Darshit Shah
On 11/21, Tim Rühsen wrote: On Friday 21 November 2014 13:19:18 Darshit Shah wrote: On 11/20, Ángel González wrote: On 20/11/14 15:29, Darshit Shah wrote: --- a/src/progress.c +++ b/src/progress.c @@ -992,6 +992,7 @@ create_image (struct bar_progress *bp, double dl_total_time, bool done)

Re: [Bug-wget] Disable assertions by default

2014-11-21 Thread Tim Ruehsen
Let's get this patch through first and others to handle the old assertions can flow in over the next week. Yes, looks good to me. Go push it. More comments below. Tim On Friday 21 November 2014 15:46:36 Darshit Shah wrote: On 11/21, Tim Rühsen wrote: On Friday 21 November 2014 13:19:18

Re: [Bug-wget] Disable assertions by default

2014-11-21 Thread Darshit Shah
On 11/21, Tim Rühsen wrote: Let's get this patch through first and others to handle the old assertions can flow in over the next week. Yes, looks good to me. Go push it. More comments below. Tim On Friday 21 November 2014 15:46:36 Darshit Shah wrote: On 11/21, Tim Rühsen wrote: On Friday

[Bug-wget] Disable assertions by default

2014-11-20 Thread Darshit Shah
Based on comments from various packagers, I've set assertions to be the disabled by default. Anybody who is interested in hacking on Wget *should* configure their Wget builds with --enable-assert. This patch will change the configure file and cause autoreconf to run for everybody. This

Re: [Bug-wget] Disable assertions by default

2014-11-20 Thread Darshit Shah
On 11/20, Ángel González wrote: On 20/11/14 15:29, Darshit Shah wrote: --- a/src/progress.c +++ b/src/progress.c @@ -992,6 +992,7 @@ create_image (struct bar_progress *bp, double dl_total_time, bool done) { int percentage = 100.0 * size / bp-total_length; assert