Re: [Bug-wget] Fwd: [PATCH] [wget-bug #33210], Add an option to output bandwidth in bits

2012-01-28 Thread Giuseppe Scrivano
hi, I will take a deeper look after your copyright assignment process is completed. As a suggestion for the futur: it will be better if you ask on the mailing list before start working on a task next time (unless it is a bug). Not all new feature requests can be accepted into wget. Cheers,

[Bug-wget] Fwd: [PATCH] [wget-bug #33210], Add an option to output bandwidth in bits

2012-01-27 Thread Sasikanth
Modified the calc_rate function to calculate bandwidth in powers of ten (SI-prefix format) for --bits option. Please review the changes Thanks Sasi -- Forwarded message -- From: Sasikanth sasikanth@gmail.com Date: Wed, Jan 18, 2012 at 5:43 PM Subject: Re: [Bug-wget]

Re: [Bug-wget] Fwd: [PATCH] [wget-bug #33210], Add an option to output bandwidth in bits

2012-01-11 Thread Giuseppe Scrivano
Thanks for the patch, except some minor esthetic changes, like an empty space between the function name and '(', that I can fix before apply it, the patch seems ok. Before I can apply it though, you need to get copyright assignments with the FSF. I am going to send more information in private to

Re: [Bug-wget] Fwd: [PATCH] [wget-bug #33210], Add an option to output bandwidth in bits

2012-01-11 Thread Sasikanth
I addressed esthetic changes in the patch. please find the modified patch attached. Thanks Sasi On Wed, Jan 11, 2012 at 8:06 PM, Giuseppe Scrivano gscriv...@gnu.orgwrote: Thanks for the patch, except some minor esthetic changes, like an empty space between the function name and '(', that I