Re: [Bug-wget] General Testsuite issue

2014-01-24 Thread Darshit Shah
On Thu, Jan 23, 2014 at 2:47 PM, Tim Ruehsen wrote: > On Thursday 23 January 2014 09:03:36 Darshit Shah wrote: > > > > Do you have any ideas that we > > > > could use to implement this? > > > > > > Well, yes. Read everything in a straight order, beginning at > > > > > > SYSCONFDIR"wgetrc"

Re: [Bug-wget] General Testsuite issue

2014-01-23 Thread Tim Ruehsen
On Thursday 23 January 2014 09:03:36 Darshit Shah wrote: > > > Do you have any ideas that we > > > could use to implement this? > > > > Well, yes. Read everything in a straight order, beginning at > > > > SYSCONFDIR"wgetrc" > > > > following 'chooseconfig' directives within ('include' wo

Re: [Bug-wget] General Testsuite issue

2014-01-22 Thread Darshit Shah
> > > The --config option is detected just before the other options by > running > > > > the same loop a little earlier. However, to same CPU cycles, we break > > > > out > > > > of the loop as soon as --config is identified. I have extended that > loop > > What do you think, how many CPU cycles ca

Re: [Bug-wget] General Testsuite issue

2014-01-22 Thread Giuseppe Scrivano
Darshit Shah writes: > Till we decide on a restructure, here is the patch for --no-config. > > This patch is made against master, but is required in parallel-wget too. > @Giuseppe: Maybe you could cherry pick this? Or merge master into > parallel-wget, especially since we've just released a new v

Re: [Bug-wget] General Testsuite issue

2014-01-22 Thread Tim Ruehsen
On Tuesday 21 January 2014 08:17:45 Darshit Shah wrote: > > > The --config option is detected just before the other options by running > > > the same loop a little earlier. However, to same CPU cycles, we break > > > out > > > of the loop as soon as --config is identified. I have extended that loop

Re: [Bug-wget] General Testsuite issue

2014-01-21 Thread Darshit Shah
Till we decide on a restructure, here is the patch for --no-config. This patch is made against master, but is required in parallel-wget too. @Giuseppe: Maybe you could cherry pick this? Or merge master into parallel-wget, especially since we've just released a new version. On Tue, Jan 21, 2014 a

Re: [Bug-wget] General Testsuite issue

2014-01-20 Thread Darshit Shah
> > > The --config option is detected just before the other options by running > > the same loop a little earlier. However, to same CPU cycles, we break out > > of the loop as soon as --config is identified. I have extended that loop > so > > that it detects --no-config too and breaks out the momen

Re: [Bug-wget] General Testsuite issue

2014-01-20 Thread Tim Ruehsen
On Saturday 18 January 2014 23:51:07 Darshit Shah wrote: > On Sat, Jan 18, 2014 at 2:05 AM, Tim Rühsen wrote: > > Am Freitag, 17. Januar 2014, 11:42:41 schrieb Tony Lewis: > > > Darshit Shah wrote: > > > > In case both the --config and --no-config commands are issued, the one > > > > > > that > >

Re: [Bug-wget] General Testsuite issue

2014-01-18 Thread Darshit Shah
On Sat, Jan 18, 2014 at 2:05 AM, Tim Rühsen wrote: > Am Freitag, 17. Januar 2014, 11:42:41 schrieb Tony Lewis: > > Darshit Shah wrote: > > > In case both the --config and --no-config commands are issued, the one > > > > that > > > > > appears first on the command will be considered and the other

Re: [Bug-wget] General Testsuite issue

2014-01-17 Thread Tim Rühsen
Am Freitag, 17. Januar 2014, 11:42:41 schrieb Tony Lewis: > Darshit Shah wrote: > > In case both the --config and --no-config commands are issued, the one > > that > > > appears first on the command will be considered and the other ignored. > > Given my memory of the way the parsing loop works,

Re: [Bug-wget] General Testsuite issue

2014-01-17 Thread Tony Lewis
Darshit Shah wrote: > In case both the --config and --no-config commands are issued, the one that > appears first on the command will be considered and the other ignored. Given my memory of the way the parsing loop works, I would expect that it would use the last one that appears. How do GNU comm

Re: [Bug-wget] General Testsuite issue

2014-01-17 Thread Darshit Shah
Hi Tim, Yes, that is an eventuality I did not consider when writing this test. A user configured option that may override the settings intended for the test. Maybe we should have a --no-config option to ensure that the tests are run on the compiled defaults only. Having a uniform environment for

[Bug-wget] General Testsuite issue

2014-01-17 Thread Tim Ruehsen
Hi, I just discovered that Test--spider-r.py fails here (parallel-wget branch). The reason is 'robots=off' in ~./wgetrc. But that leads the the question, how can we prevent any user (and global /etc/wgetrc) settings dropping in, possibly making the tests fail. An option like --no-config could