Re: [Bug-wget] Metalink support

2015-09-03 Thread Hubert Tarasiuk
I mentioned libmetalink and GnuPG in the README.checkout. W dniu 02.09.2015 o 00:18, Tim Ruehsen pisze: > Thanks, pushed. > > Tim > > On Tuesday 01 September 2015 23:37:46 Hubert Tarasiuk wrote: >> Here is a small fix to Metalink support in main function. >> The bug was that if the Metalink

Re: [Bug-wget] Metalink support

2015-09-02 Thread Hubert Tarasiuk
Here is a small fix to Metalink support in main function. The bug was that if the Metalink file parsing failed, there would be a free() call for non-initialized memory pointer. W dniu 24.06.2015 o 08:06, Hubert Tarasiuk pisze: > I have prepared a Metalink patch for Wget. The two main features

Re: [Bug-wget] Metalink support

2015-07-24 Thread Ander Juaristi
Hi, I don't know if I should awake this thread, but anyway. Wget fails to build (at least for me) when using OpenSSL as the backend: $ ./configure --with-ssl=openssl $ make output trimmed In file included from openssl.c:49:0: utils.h:160:6: error: conflicting types for 'hex_to_string' void

Re: [Bug-wget] Metalink support

2015-07-24 Thread Darshit Shah
I just came across the same issue when trying to test the code. I've locally renamed the function to `wg_hex_to_string`. I'll push the patch to master right away so that builds stop failing. On Fri, Jul 24, 2015 at 10:51 PM, Ander Juaristi ajuari...@gmx.es wrote: Hi, I don't know if I should

Re: [Bug-wget] Metalink support

2015-07-20 Thread Giuseppe Scrivano
Hubert Tarasiuk hubert.taras...@gmail.com writes: W dniu 04.07.2015 o 00:15, Anthony Bryan pisze: Of course it works for me, but we are not talking about me :-) The main question is: what does the typical wget user expect ? I would thinks (s)he expects the download of the file described by

Re: [Bug-wget] Metalink support

2015-07-04 Thread Tim Rühsen
Am Freitag, 3. Juli 2015, 18:15:27 schrieb Anthony Bryan: $ wget --input-metalink=http://www.metalinker.org/samples/dsl-3.3.iso.metalink I'm not sure what the typical wget user expects, but here are some examples. if you keep the current behavior, it might be helpful to print to the

Re: [Bug-wget] Metalink support

2015-07-03 Thread Tim Ruehsen
Hi Hubert, thanks for rebasing. git am works smoothly now :-) On Friday 03 July 2015 13:54:43 Hubert Tarasiuk wrote: - I had to find out that I need libgpgme11-dev package (on Debian here), else ./boostrap and/or ./configure would not work. Please add this information to README.checkout.

Re: [Bug-wget] Metalink support

2015-07-03 Thread Hubert Tarasiuk
W dniu 03.07.2015 o 17:12, Tim Ruehsen pisze: To copy GPGME m4 macro, I have to install libgpgme11-dev. And if I do that, a ./bootstrap (maybe just a configure) does the job for me. Actually I meant copying over the m4 GPGME macro and adding it to Wget's repository, so that it would be

Re: [Bug-wget] Metalink support

2015-07-03 Thread Anthony Bryan
On Fri, Jul 3, 2015 at 5:21 PM, Tim Rühsen tim.rueh...@gmx.de wrote: Am Freitag, 3. Juli 2015, 20:23:00 schrieb Hubert Tarasiuk: W dniu 03.07.2015 o 17:12, Tim Ruehsen pisze: To copy GPGME m4 macro, I have to install libgpgme11-dev. And if I do that, a ./bootstrap (maybe just a configure)

Re: [Bug-wget] Metalink support

2015-07-03 Thread Hubert Tarasiuk
W dniu 04.07.2015 o 00:15, Anthony Bryan pisze: Of course it works for me, but we are not talking about me :-) The main question is: what does the typical wget user expect ? I would thinks (s)he expects the download of the file described by the .metalink file. Of course a few users really

Re: [Bug-wget] Metalink support

2015-07-03 Thread Tim Rühsen
Am Freitag, 3. Juli 2015, 20:23:00 schrieb Hubert Tarasiuk: W dniu 03.07.2015 o 17:12, Tim Ruehsen pisze: To copy GPGME m4 macro, I have to install libgpgme11-dev. And if I do that, a ./bootstrap (maybe just a configure) does the job for me. Actually I meant copying over the m4 GPGME macro

Re: [Bug-wget] Metalink support

2015-07-03 Thread Tim Ruehsen
Hi Hubert, thanks for all your work on Metalink support ! Just a few minor points I stumbled upon when I tried to apply your patches :-) - they don't apply smoothly on latest master. Could you rebase your work on current master ? (What I did it is 'git am 00*' with your patches) - I had to

Re: [Bug-wget] Metalink support

2015-07-03 Thread Hubert Tarasiuk
Hi Tim, W dniu 03.07.2015 o 10:17, Tim Ruehsen pisze: Just a few minor points I stumbled upon when I tried to apply your patches :-) - they don't apply smoothly on latest master. Could you rebase your work on current master ? (What I did it is 'git am 00*' with your patches) That was my

Re: [Bug-wget] Metalink support

2015-07-02 Thread Hubert Tarasiuk
I have adjusted some comments to reflect the current libmetalink situation. Moreover, I added another option: --preferred-location=location that can be used to give priority to certain Metalink resources based on their location. These changes are presented in three additional commits (10, 11,

Re: [Bug-wget] Metalink support

2015-06-28 Thread Hubert Tarasiuk
W dniu 27.06.2015 o 18:11, Anthony Bryan pisze: libmetalink moved to github yesterday released a new version (0.1.3), hopefully fixing the signature bug you came across (thanks for reporting that as well) https://github.com/metalink-dev/libmetalink Thanks for the fix! I have tested the

Re: [Bug-wget] Metalink support

2015-06-27 Thread Anthony Bryan
On Thu, Jun 25, 2015 at 8:44 PM, Hubert Tarasiuk hubert.taras...@gmail.com wrote: Here comes an updated version of the patches. I have applied some minor changes based on Giuseppe's suggestions posted on Github (thanks for the review!). Another patch is added (9/9) to move some helper

Re: [Bug-wget] Metalink support

2015-06-25 Thread Hubert Tarasiuk
Here comes an updated version of the patches. I have applied some minor changes based on Giuseppe's suggestions posted on Github (thanks for the review!). Another patch is added (9/9) to move some helper functions used for Metalink-over-HTTP from http.c to metalink.c. They are also made

Re: [Bug-wget] Metalink support

2015-06-25 Thread Giuseppe Scrivano
Hubert Tarasiuk hubert.taras...@gmail.com writes: I have prepared a Metalink patch for Wget. The two main features are: - support Metalink v3 and Metalink v4 XML files: https://tools.ietf.org/html/rfc5854 using libmetalink parser: https://launchpad.net/libmetalink - support Metalink in

[Bug-wget] Metalink support

2015-06-24 Thread Hubert Tarasiuk
I have prepared a Metalink patch for Wget. The two main features are: - support Metalink v3 and Metalink v4 XML files: https://tools.ietf.org/html/rfc5854 using libmetalink parser: https://launchpad.net/libmetalink - support Metalink in HTTP headers: http://tools.ietf.org/html/rfc6249