Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Ander, Am 19.11.2015 um 10:41 schrieb Ander Juaristi : > On 11/18/2015 11:09 AM, Tim Ruehsen wrote: >> Hi Dagobert, hi Ander, >> >> I could reproduce and fix the problem on a 32bit Debian wheezy VM. >> >> @Dagobert Please check if the attached patch works on Solaris as well

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Thanks - good catch, Ander ! I pushed the patch. Tim On Thursday 19 November 2015 10:41:28 Ander Juaristi wrote: > Hi Tim, > > On 11/18/2015 11:09 AM, Tim Ruehsen wrote: > > Hi Dagobert, hi Ander, > > > > I could reproduce and fix the problem on a 32bit Debian wheezy VM. > > > > @Dagobert

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Ups, sorry the German text. The mail should have gone directly to Dagobert... On Solaris 11, Wget works fine. On Solaris 10 I could reproduce the problem. I just configured without GPG/metalink, and now it's fine. @Dagobert: As you mentioned, it looks like a problem in the GPG build. Tim On

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Tim, Am 19.11.2015 um 12:25 schrieb Tim Ruehsen : > Thanks - good catch, Ander ! Now Solaris 10 i386 passes cleanly but Sparc dumps core. The core looks like this: > buildbot@unstable10s [unstable10s]:~/slave/wget-solaris10-sparc/build/tests > > pstack core > core

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hallo Dago, auf unstable11s funktioinert es. Auf unstable10s bekomme ich: > ./bootstrap ./bootstrap: syntax error at line 88: `me_=$' unexpected Kannst du mir hier weiterhelfen ? Tim On Thursday 19 November 2015 14:22:42 Dagobert Michelsen wrote: > Hi Tim, > > Am 19.11.2015 um 12:25

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Tim, Am 18.11.2015 um 11:09 schrieb Tim Ruehsen : > Hi Dagobert, hi Ander, > > I could reproduce and fix the problem on a 32bit Debian wheezy VM. > > @Dagobert Please check if the attached patch works on Solaris as well Yes, this fixes the issue. The testsuite now

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Tim, Am 17.11.2015 um 10:36 schrieb Tim Ruehsen : > On Monday 16 November 2015 22:34:53 Dagobert Michelsen wrote: >> Same here on Solaris 10 with Oracle Studio 12: >> >>> /opt/csw/bin/gcc -DHAVE_CONFIG_H -DSYSTEM_WGETRC=\"/usr/local/etc/wgetrc\" >>>

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Tim, Am 17.11.2015 um 13:14 schrieb Tim Ruehsen : > I guess, Darshit's patch also fixes this issue for Solaris. It does, excellent! https://buildfarm.opencsw.org/buildbot/builders/wget-solaris10-i386/builds/92/steps/shell_2/logs/stdio > I was more referring to >>

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Tim Ruehsen wrote: > BTW, I am pretty astonished that there are no Windows developers ever trying > to compile Wget before any release. How can we any longer support an OS > without any help from OS users ? I build Wget on Windows all the time w/o any problem with flock(). (LOCK_EX is defined

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Dagobert, On Tuesday 17 November 2015 14:12:33 Dagobert Michelsen wrote: > > I was more referring to > > > >> issues: http://lists.gnu.org/archive/html/bug-wget/2015-07/msg00068.html > > > > It seems that metalink.c has to include instead . > > Maybe could could give it try or otherwise let

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Tim, Am 17.11.2015 um 14:52 schrieb Tim Ruehsen : > I just pushed the change. Excellent, the build now runs cleanly. >> Now only one test is failing: >>> FAIL: unit-tests >> >> How does think unit-test-thing work? I can’t find a log or some debug >> output. > > For

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Dagobert, Thanks for running the tests and sharing that log. The unit-tests check specific functions for correctness. The test failing is the one that tests the hsts_store_entry() method in hsts.c. On a preliminary read, it seems like its trying to test something else, but we instead

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Dagobert, On Tuesday 17 November 2015 15:09:05 Dagobert Michelsen wrote: > >> Now only one test is failing: > >>> FAIL: unit-tests > >> > >> How does think unit-test-thing work? I can’t find a log or some debug > >> output. > > > > For every test you will have .log file in tests/ resp.

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Dagobert, On Tuesday 17 November 2015 12:16:15 Dagobert Michelsen wrote: > Hi Tim, > > Am 17.11.2015 um 10:36 schrieb Tim Ruehsen : > > On Monday 16 November 2015 22:34:53 Dagobert Michelsen wrote: > >> Same here on Solaris 10 with Oracle Studio 12: > >>> /opt/csw/bin/gcc

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Dagobert, Am Dienstag, 17. November 2015, 15:09:05 schrieb Dagobert Michelsen: > > RUNNING TEST test_hsts_url_rewrite_superdomain... > > A new entry should've been created > > Tests run: 15 > > FAIL unit-tests (exit status: 1) > > So which test is failing? test_hsts_url_rewrite_superdomain ?

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Tim, Am 17.11.2015 um 21:17 schrieb Tim Rühsen : > Am Dienstag, 17. November 2015, 15:09:05 schrieb Dagobert Michelsen: >>> RUNNING TEST test_hsts_url_rewrite_superdomain... >>> A new entry should've been created >>> Tests run: 15 >>> FAIL unit-tests (exit status: 1) >> >>

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

On Tue, 17 Nov 2015, Tim Ruehsen wrote: BTW, I am pretty astonished that there are no Windows developers ever trying to compile Wget before any release. How can we any longer support an OS without any help from OS users ? Cross-compilation and testing with Wine is IMO not an option... I had

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Darshit Shah writes: > I think it's because flock isn't implemented in Windows. The ideal > solution would be to use some WIN32 API to get it done. However, I saw > that gnulib actually provides an implementation of flock that can be > used on Windows. > Hence, maybe just using

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi Dagobert, On Monday 16 November 2015 22:34:53 Dagobert Michelsen wrote: > Hi, > > Am 16.11.2015 um 14:53 schrieb Jernej Simončič : > > Looks like hsts.c tries to use flock with a parameter that doesn't > > work on Windows: > > > > x86_64-w64-mingw32-gcc

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Thanks for pointing out, Daniel ! Looks like a good option. Tim On Tuesday 17 November 2015 10:32:06 Daniel Stenberg wrote: > On Tue, 17 Nov 2015, Tim Ruehsen wrote: > > BTW, I am pretty astonished that there are no Windows developers ever > > trying to compile Wget before any release. How can

[Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Looks like hsts.c tries to use flock with a parameter that doesn't work on Windows: x86_64-w64-mingw32-gcc -DHAVE_CONFIG_H -DSYSTEM_WGETRC=\"/win32dev/misc/wget/out64/etc/wgetrc\" -DLOCALEDIR=\"/win32dev/misc/wget/out64/share/locale\" -I. -I../lib -I../lib -I/win32dev/misc/wget/out64/include

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

Hi, Am 16.11.2015 um 14:53 schrieb Jernej Simončič : > Looks like hsts.c tries to use flock with a parameter that doesn't > work on Windows: > > x86_64-w64-mingw32-gcc -DHAVE_CONFIG_H > -DSYSTEM_WGETRC=\"/win32dev/misc/wget/out64/etc/wgetrc\" >

Re: [Bug-wget] Wget 1.17 doesn't compile on Windows (hsts.c)

I think it's because flock isn't implemented in Windows. The ideal solution would be to use some WIN32 API to get it done. However, I saw that gnulib actually provides an implementation of flock that can be used on Windows. Hence, maybe just using the gnulib module may work. @Giuseppe, @Tim: