Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-17 Thread Giuseppe Scrivano
Tim Rühsen writes: >> but we can perhaps use this when flock is not available. > > Sounds like doing gnulib's job !? > > If flock() is not available, gnulib throws in it's flock() emulation. They > already check for flock and fcntl being available. Not sure, what problem >

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-17 Thread Tim Ruehsen
Thanks for your feedback, Kiyoshi. Tim On Thursday 17 December 2015 20:25:47 Kiyoshi KANAZAWA wrote: > Hello, Tim. > > Fine. > It is simple and clear resolution if you have no reason to keep #define > _XOPEN_SOURCE. > > On Solaris 10 x11 & solarisstudio12.4, > I confirmed make & make check

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-17 Thread Tim Ruehsen
The change is pushed. Tim On Thursday 17 December 2015 09:12:29 Giuseppe Scrivano wrote: > > What Christian and I experience is this (just got it on OpenCSW Solaris > > 11): > > > > /opt/csw/lib/gcc/i386-pc-solaris2.10/5.2.0/include- > > fixed/sys/feature_tests.h:346:2: error: #error "Compiler

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-17 Thread Kiyoshi KANAZAWA
Hello, Tim. Fine. It is simple and clear resolution if you have no reason to keep #define _XOPEN_SOURCE. On Solaris 10 x11 & solarisstudio12.4, I confirmed make & make check passes for the followings all: - with -std=c89 - with -std=c99 - with -std=c11 - without -std= --- Kiyoshi

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-16 Thread Dagobert Michelsen
Hi folks, Am 16.12.2015 um 21:01 schrieb Tim Rühsen : > Seems pretty clear - gcc 5 has C99 as default standard (and Solaris has gcc > 5.2). > But we explicitely define _XOPEN_SOURCE 500 in src/sysdep.h, which says we > want 'X/Open 5, POSIX 1995' functions and nothing newer. >

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-16 Thread Tim Rühsen
Am Mittwoch, 16. Dezember 2015, 12:13:46 schrieb Giuseppe Scrivano: > Tim Ruehsen writes: > > On Wednesday 16 December 2015 10:31:33 Giuseppe Scrivano wrote: > >> Tim Ruehsen writes: > >> > On Tuesday 15 December 2015 21:55:53 Kiyoshi KANAZAWA wrote: > >>

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-16 Thread Giuseppe Scrivano
Tim Ruehsen writes: > On Wednesday 16 December 2015 10:31:33 Giuseppe Scrivano wrote: >> Tim Ruehsen writes: >> > On Tuesday 15 December 2015 21:55:53 Kiyoshi KANAZAWA wrote: >> >> 2. about #error "Compiler or options invalid for pre-UNIX 03 X/Open >> >>

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-16 Thread Giuseppe Scrivano
Tim Ruehsen writes: > On Tuesday 15 December 2015 21:55:53 Kiyoshi KANAZAWA wrote: >> 2. about #error "Compiler or options invalid for pre-UNIX 03 X/Open >> applications" This error may depends on compilers. >> Both of "solarisstudio12.4" & "gcc-4.8.5" can build

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-16 Thread Tim Ruehsen
On Wednesday 16 December 2015 10:31:33 Giuseppe Scrivano wrote: > Tim Ruehsen writes: > > On Tuesday 15 December 2015 21:55:53 Kiyoshi KANAZAWA wrote: > >> 2. about #error "Compiler or options invalid for pre-UNIX 03 X/Open > >> applications" This error may depends on

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-16 Thread Dagobert Michelsen
Hi Tim, Am 16.12.2015 um 10:52 schrieb Tim Ruehsen : > On Wednesday 16 December 2015 10:31:33 Giuseppe Scrivano wrote: >> the gnulib documentation for flock says: >> >> Portability problems not fixed by Gnulib: >> >>This function is missing on some platforms: >>AIX

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-15 Thread Kiyoshi KANAZAWA
Hello, Tim. std=c89 is not needed on my environment:  Solaris 10 x86 & (solarisstudio12.4 & gcc-4.8.5). I can make wget wget-1.17.1 without it. This is only for hint, why Christian needs -std=c89. Default of solarisstudio12.4 cc is c11. But, if I use -std=c11 or -std=c99 explicitly, make

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-15 Thread Tim Ruehsen
On Tuesday 15 December 2015 21:55:53 Kiyoshi KANAZAWA wrote: > 2. about #error "Compiler or options invalid for pre-UNIX 03 X/Open > applications" This error may depends on compilers. > Both of "solarisstudio12.4" & "gcc-4.8.5" can build wget-1.17.1 without > errors. > > But I once experienced

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-15 Thread Kiyoshi KANAZAWA
Hello, I built wget-1.17.1 on solaris 10 x86/x64, with compiler solarisstudio12.4 & gcc-4.8.5. 1. "'LOCK_EX' undeclared" is not detected in tar ball ftp://ftp.gnu.org/gnu/wget/wget-1.17.1.tar.xz This problem seems to be the same as mentioned for wget-1.17 last month in subject "Wget 1.17

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-12 Thread Christian Jullien
Hi Tim, I confirm that: #!/bin/bash CFLAGS="-std=c89" PKG_CONFIG_PATH=/usr/local/lib/pkgconfig/ ./configure --with-ssl=openssl && make Works. I don't understand quite well how -std=c89, which is related to a given C revision compliance and -D_XPG6, which is related to X/Open Portability Guide,

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-12 Thread Tim Rühsen
You might be right, thanks for pointing out (I never use tarballs, that's why I don't have them in mind). Giuseppe created the tarballs on a system with flock() available. AFAIK, gnulib jumps in only when needed. Maybe the gnulib-flock implementation didn't find it's into the tarball ? We

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-12 Thread Tim Rühsen
Am Samstag, 12. Dezember 2015, 17:57:00 schrieb Darshit Shah: > Didn't we fix this by using the Gnulib module? > I thought all the tests were passing on Solaris after that. What went > wrong with the release? > Immediately after the release, even the Solaris buildbot complained > about a broken

[Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-12 Thread Christian Jullien
Hi, trying to compile wget-1.17 and now wget-1.17.1 on solaris 10 sparc using gcc 5.2.0 , I get: hsts.c:505:11: warning: implicit declaration of function 'flock' [-Wimplicit-function-declaration] flock (fd, LOCK_EX); ^ hsts.c:505:22: error: 'LOCK_EX' undeclared (first

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-12 Thread Darshit Shah
Didn't we fix this by using the Gnulib module? I thought all the tests were passing on Solaris after that. What went wrong with the release? Immediately after the release, even the Solaris buildbot complained about a broken build. On 12 December 2015 at 17:42, Christian Jullien

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-12 Thread Darshit Shah
Exactly! But I checked the gnulib changelog. Nothing major seems to have changed that causes such a fault. Most of the commits seem to be documentation related only. Also, like you said, the compiler message is not helpful at all. Need someone who is more experienced in such systems to take alook

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-12 Thread Tim Rühsen
Hi Christian, did you ./bootstrap, ./configure, make clean, make after updating ? Especially without ./bootstrap flock might not be taken from gnulib (which call lockf if flock is not available). Regards, Tim Am Samstag, 12. Dezember 2015, 17:42:10 schrieb Christian Jullien: > Hi, trying to

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-12 Thread Darshit Shah
I should think not. As far as I'm aware, bootstrap will copy all the used modules to lib/ and they can be used at compile time if needed. If the environment affects the tarball being created, we have a bug in the system On 12 December 2015 at 18:39, Tim Rühsen wrote: > You

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-12 Thread Darshit Shah
If he's talking about releases, he is probably using the release tarballs. Those don't need ./bootstrap On 12 December 2015 at 18:15, Tim Rühsen wrote: > Hi Christian, > > did you ./bootstrap, ./configure, make clean, make after updating ? > > Especially without ./bootstrap

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-12 Thread Tim Rühsen
It is just the compiler/compiler flags that the buildbot uses. CC and CFLAGS not set and the error is reproducible. With CC=gcc and CFLAGS="-std=c89 -Wall -O2" the build runs fine. I'll make some more tests to find the exact point. I guess Dagobert might adjust some settings for the buildbot.

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-12 Thread Christian Jullien
I'm using wget-1.17.1.tar.gz pushed yesterday on http://ftp.gnu.org/pub/gnu Here are my attempts to make wget compile on Solaris 10 (sol-10-u11-ga-sparc-dvd.iso) [jullien@pastre]wget-1.17.1$ uname -a SunOS pastre 5.10 Generic_147147-26 sun4u sparc SUNW,Ultra-5_10 Solaris [jullien@pastre]~$ gcc

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-12 Thread Tim Rühsen
Just for the record: Wget from tarball compiles on Solaris 10 x86 and Sparc (OpenCSW build farm) with CFLAGS="-std=c89" set (@Dagobert: Could you set this flag for the build bot ?). ./configure says: checking for flock... no So the fallback from gnulib jumps in and voila. Tim Am Samstag,

Re: [Bug-wget] flock is not available on solaris 10 (at least sparc)

2015-12-12 Thread Tim Rühsen
Am Samstag, 12. Dezember 2015, 20:23:17 schrieb Christian Jullien: > => Ok, _XPG6 is now required, 3rd attempt > $ CFLAGS="-D_XPG6" PKG_CONFIG_PATH=/usr/local/lib/pkgconfig/ ./configure; > make Could you try -std=c89 instead of -D_XPG6 ? Tim