[Bug-wget] gnutls link failure, ssl

2011-08-10 Thread Karl Berry
My initial build of wget failed due to gnutls version problems.
configure said:
..
checking for main in -lgnutls... yes
configure: compiling in support for SSL via GnuTLS

But then the link failed with:
gcc  -O2 -Wall   -o wget cmpt.o connect.o convert.o cookies.o ftp.o css.o 
css-url.o ftp-basic.o ftp-ls.o hash.o host.o html-parse.o html-url.o http.o 
init.o log.o main.o netrc.o progress.o ptimer.o recur.o res.o retr.o spider.o 
url.o utils.o exits.o build_info.o iri.o version.o ftp-opie.o gnutls.o 
../lib/libgnu.a -lgnutls -lgcrypt -lgpg-error -lz  -lidn -lrt
gnutls.o: In function `ssl_connect_wget':
gnutls.c:(.text+0x4b0): undefined reference to `gnutls_priority_set_direct'
gnutls.c:(.text+0x528): undefined reference to `gnutls_priority_set_direct'
collect2: ld returned 1 exit status

Evidently configure should check for gnutls_priority_set_direct also.
And if it fails, hopefully it will fall back to openssl.
(This was on CentOS 5.6, but presumably that doesn't especially matter.)

Related, there used to be an option --with-libssl-prefix.  I'm not sure
when it was removed, but it was useful.

Also, configure --help does not mention the possibility of
--with-ssl=openssl.

Finally, the NEWS file doesn't say anything about either of these:
preferring tls to openssl or the --with-ssl=openssl option.  I didn't
look to see if there were other configure options that didn't make to
the --help and/or NEWS.

Thanks,
Karl




Re: [Bug-wget] gnutls link failure, ssl

2011-08-10 Thread Giuseppe Scrivano
Hello Karl,

thanks to have reported it.  It looks like a very ugly one, I think it
depends from last change:

revno: 2517
committer: Giuseppe Scrivano gscriv...@gnu.org
branch nick: wget
timestamp: Fri 2011-08-05 21:36:08 +0200
message:
  gnutls: do not use a deprecated function.

I'll rollback to the deprecated function when
`gnutls_priority_set_direct' is not available.

I will amend your comments into the NEWS file and configure --help.

I think it is too late now to replace packages, and to avoid
synchronization problems with mirrors, I'll go for 1.13.1.  I had the
feeling that 1.13 wasn't going to be released :-)

Thanks,
Giuseppe



k...@freefriends.org (Karl Berry) writes:

 My initial build of wget failed due to gnutls version problems.
 configure said:
 ..
 checking for main in -lgnutls... yes
 configure: compiling in support for SSL via GnuTLS

 But then the link failed with:
 gcc -O2 -Wall -o wget cmpt.o connect.o convert.o cookies.o ftp.o css.o
 css-url.o ftp-basic.o ftp-ls.o hash.o host.o html-parse.o html-url.o
 http.o init.o log.o main.o netrc.o progress.o ptimer.o recur.o res.o
 retr.o spider.o url.o utils.o exits.o build_info.o iri.o version.o
 ftp-opie.o gnutls.o ../lib/libgnu.a -lgnutls -lgcrypt -lgpg-error -lz
 -lidn -lrt
 gnutls.o: In function `ssl_connect_wget':
 gnutls.c:(.text+0x4b0): undefined reference to `gnutls_priority_set_direct'
 gnutls.c:(.text+0x528): undefined reference to `gnutls_priority_set_direct'
 collect2: ld returned 1 exit status

 Evidently configure should check for gnutls_priority_set_direct also.
 And if it fails, hopefully it will fall back to openssl.
 (This was on CentOS 5.6, but presumably that doesn't especially matter.)

 Related, there used to be an option --with-libssl-prefix.  I'm not sure
 when it was removed, but it was useful.

 Also, configure --help does not mention the possibility of
 --with-ssl=openssl.

 Finally, the NEWS file doesn't say anything about either of these:
 preferring tls to openssl or the --with-ssl=openssl option.  I didn't
 look to see if there were other configure options that didn't make to
 the --help and/or NEWS.

 Thanks,
 Karl