Please find attached a new patch incorporating your comments.
could you avoid this global? Can we propagate instead a pointer as
create_authorization_line and digest_authentication_encode param?
Fixed as a pointer that is sent to create_authorization_line and
digest_authentication_encode as a
Darshit Shah dar...@gmail.com writes:
Should we xfree_null (qop) before setting it to NULL?
qop will ALWAYS be xfree'd if it is explicitly set to NULL. The if
statement on the next line takes care of that.
sorry, I still don't understand it. Won't xfree_null (qop) be a NOP
On Mon, Jul 22, 2013 at 5:33 PM, Giuseppe Scrivano gscriv...@gnu.orgwrote:
Darshit Shah dar...@gmail.com writes:
Should we xfree_null (qop) before setting it to NULL?
qop will ALWAYS be xfree'd if it is explicitly set to NULL. The if
statement on the next line takes care of that.
Darshit Shah dar...@gmail.com writes:
Fixed the SIGSEGV issue that propped up. It was caused because wget
entered a code region that it should never reach in that use-case. Was
occurring because I replaced qop = NULL with xfree_null (qop) instead
of xfree-ing qop and then setting it to NULL.
This patch seems to break for normal builds.
I get the following error on running make:
configure: error: conditional HAVE_NETTLE was never defined.
Usually this means the macro was only invoked conditionally.
make: *** [config.status] Error 1
On Mon, Jul 22, 2013 at 4:43 AM, Giuseppe Scrivano
Darshit Shah dar...@gmail.com writes:
This patch seems to break for normal builds.
I get the following error on running make:
configure: error: conditional HAVE_NETTLE was never defined.
Usually this means the macro was only invoked conditionally.
make: *** [config.status] Error 1
